From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E83933E022B for ; Mon, 23 Mar 2026 20:59:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774299560; cv=none; b=HHZNnTf1kqHdvKbS39mgk/WCk4Lrv4mE06KYLadZZ0HQsE8BdhMPAsxS4dX/N0d3Xb6wrbGvhLukT9GHEd+Ts8uyNQpaRJY/wcLmEf8WMiwLDQZ12ckwDySnPoRbYg4LKWlG7IlK3cGor81qbFpI8AN8QDH044Kbnsru/7eGf1E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774299560; c=relaxed/simple; bh=IKUYy6h7E6OacLnO0SCP+Gf6jvCT2VvxqJLPXFXcJuI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VThpl+9UDXhNKqRnbqLbRgdzsn9vpFgYeBr2qda7S8MXDYjaYPelwtme7yD9Aby4S77ds8U/Iwgu1PTHeBQkoasbI+gDfc3CWrVF33gT0PE092rew62rZHWlqb/kFCs7Y10McVO7aAqnKx+7GCUiwRbCNOku6T/KcLJxP3k1o6M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Rru906PN; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Rru906PN" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2aeab6ff148so9155ad.1 for ; Mon, 23 Mar 2026 13:59:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1774299558; x=1774904358; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GfEbQ9zMwITLJ6hWqGMJubvK51p36l2V00YC6g9wwEI=; b=Rru906PNRkCWsCtlmGzoMkHOi6OAtwI/Anp0Xx0XyL3l7hOaN2/fDv0ZLP29/oZ54D dVSizdmFl74/ryhVhRnDfHLw43kGYPDddAROhzBa1Zgg9xayPM/zTbLuNb9leMs37kH9 OBQ0k0KMbeuMoUgeHUYJ3p8fn60xAL+CLbG9hwnBY1o8Q6zcZV1B43+fieg+7Lnf225k YO+reEXxAE0Ct3jMZicS5WCDhHYac6em1X4/oEgDoDsZdmr3jQ6HDecEkTVuH4/VpRHV nwy1lMV5cb7GfXN4ITWwUGRH6Ac78AjA+u720IwnZnMfrrxxMtgrNtsbXVaycRHDJKH3 gLzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774299558; x=1774904358; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GfEbQ9zMwITLJ6hWqGMJubvK51p36l2V00YC6g9wwEI=; b=njhteGK9Ho2sfpfQnGf74JKnNAkleSYc5+6h5zQahKWK9zaSywobTmKu/McqGdadza nCEZRO4cT3pselvVJplszpihC8lHhd3o34MDuCV8xd9Ztq4gPebpGoh/acO91VjHONvT S2vJaa774YkF3Tnkc0OnfqbjfC4msg8w0L0nruHsrPt1/iYenIJfRAjrdBlnZB/1q5MP zL4Dij6qYBYSg6199zuScpFfq7Vtb2wnPGuu2PLJSwSrYhZFTlrscBfl/cKwv+k1vhMz 1IkN83QljZ/to1RLoDAdDLlD0MzquSe9WJGGcgut/EjwWKZMhhBO6wxzbYjfWn6GD20k frjw== X-Forwarded-Encrypted: i=1; AJvYcCUkPIWbeHilQs+yiOI1ylhj9S1WfkGKzPQDPVv5hk02j2Ot0wUIyY4u0HybDq9SlPFIFhAU29gkLwgB81U=@vger.kernel.org X-Gm-Message-State: AOJu0YwGYt8lId4kv581Aga7qRdmqY5wsGJy4r6saFv7fS+6UmzOrynj 5NExtp/SzL+2aR0VPgPz52DQYbYfJkQDMif+xlH/e4F3aBJbiPkhM1JEKiCAyCFFyQ== X-Gm-Gg: ATEYQzxQD6oRdpwImw4VD/XzqzuDDF6P74Zo4OCvbfK21JYJm2CCdn/AoepabIpNRiP 1g9OPxWT6VItL2MgfVE9EQ9ZGNDc39gFNh1fLm1BgfYakT9B+/AzLt/rjMCGNIq0xJtrRXW887x r1t1ftOx9LBI7gVAqbXE7MtWy8MKUcVgczPqxa3xM645NdNlKTi0/Fm8ZBm7laHqT6BwOD1o1Td RREEKsP4eKXyEurJuj7fLP3f/vAOnc1wcIUigvF936JgfJvaIv+QgohfWiQRrMg8NAX899ccKzH QNSAqn2V2mPR5Guu6SiccQ98AqQAeQsWoDPB/Hr3I53caYReH9u3bmhR8POMJHNO6ZYV+v/yoT4 uBxXzLyJH/Vq9/fyG9+bB7V9j8pmc1hgYJQexsVNxVnNeLBxS/c6w9dc+nDQ63Lkp2xBgPUNrJ4 jbgCcYlMO+w7r+6O5wM/uRZjOnBcUQYiKH6qvLDnOp1zzxNzxEPq/rVsaLVw== X-Received: by 2002:a17:902:e80f:b0:2ae:4453:3674 with SMTP id d9443c01a7336-2b0a53e76f6mr951935ad.4.1774299557926; Mon, 23 Mar 2026 13:59:17 -0700 (PDT) Received: from google.com (60.89.247.35.bc.googleusercontent.com. [35.247.89.60]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c015cd6b8sm101179a91.0.2026.03.23.13.59.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 13:59:17 -0700 (PDT) Date: Mon, 23 Mar 2026 13:59:13 -0700 From: Vipin Sharma To: Samiullah Khawaja Cc: David Woodhouse , Lu Baolu , Joerg Roedel , Will Deacon , Jason Gunthorpe , Robin Murphy , Kevin Tian , Alex Williamson , Shuah Khan , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Saeed Mahameed , Adithya Jayachandran , Parav Pandit , Leon Romanovsky , William Tu , Pratyush Yadav , Pasha Tatashin , David Matlack , Andrew Morton , Chris Li , Pranjal Shrivastava , YiFei Zhu Subject: Re: [PATCH 12/14] iommufd: Add APIs to preserve/unpreserve a vfio cdev Message-ID: <20260323203818.GA2571566.vipinsh@google.com> References: <20260203220948.2176157-1-skhawaja@google.com> <20260203220948.2176157-13-skhawaja@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260203220948.2176157-13-skhawaja@google.com> On Tue, Feb 03, 2026 at 10:09:46PM +0000, Samiullah Khawaja wrote: > diff --git a/drivers/iommu/iommufd/device.c b/drivers/iommu/iommufd/device.c > +#ifdef CONFIG_IOMMU_LIVEUPDATE > +int iommufd_device_preserve(struct liveupdate_session *s, > + struct iommufd_device *idev, > + u64 *tokenp) > +{ > + struct iommufd_group *igroup = idev->igroup; > + struct iommufd_hwpt_paging *hwpt_paging; > + struct iommufd_hw_pagetable *hwpt; > + struct iommufd_attach *attach; > + int ret; > + > + mutex_lock(&igroup->lock); > + attach = xa_load(&igroup->pasid_attach, IOMMU_NO_PASID); > + if (!attach) { > + ret = -ENOENT; > + goto out; > + } Should VFIO in its can_preserve() add this check? > +void iommufd_device_unpreserve(struct liveupdate_session *s, > + struct iommufd_device *idev, > + u64 token) Where is token used in this function?