From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51B5F38238F for ; Tue, 24 Mar 2026 13:54:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774360481; cv=none; b=dw+ao1hCLea43Rpcf1+gkGAS2EG7hhv07w5/2PA7S+/jN8/QFsWqial/PoSHZLWtGpilHeSdpCl6bNyWzKDtlTBKyAF/Tw6x8mk1s3CgDsA49svLb2G7V62IKsoNpKVvhuaQQnmj+G2m0QNRxZP32eYXGS+Qi3OTio1JseG9dEo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774360481; c=relaxed/simple; bh=mjEq1PLPEBk6WppdYqh8OnJbPCI24wJUo693CNzhVxg=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=bFar1RW5Hj8wntdwFkXM4v4HkK9xt51ol4rXPlOyvwxJEnYHACD6pXjI5cpmS/3fITuRP5SP3syQA2stwrIZGM6lknC3qvSMDs/l1qhxHuI30Ohuhyi+V+kdsLv2MvuimKW3tHZgeWTaHlOxyEioqN2jyOL2/1b2LOq6IvjwCUs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XSqH2/TR; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XSqH2/TR" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-5a2967e5de4so914049e87.3 for ; Tue, 24 Mar 2026 06:54:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774360478; x=1774965278; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=QRP8waOAFbU/kyinDmGT7grAQld1bjZSxa4dUhXQ9j8=; b=XSqH2/TRAyBtNPSffScUZ3JGUAMjNeK/hYWOhAH3WgdqS6o7O3JWZO0j8cBBaTOOt2 A4CUXrCwQ6rEv+b0ZXsJfAVcThenW0CLteYiE63KZCcbrQUdBviQJudTpFWhOfZ+DLOe PED6WFzPcYHPFeuBRq5zs29PU8Qhnk0YHRMDWMMt6qt9cwbdSNShwLA07JCnoejePIty 3J+PEkziOOxVQFrAxC9k57yEq4KR/DY9FdwAvr15Pn7PCCl4Lg0kS6seqdKr1sXtiwfD Vl4alANdb+5ieyIga5gGCzkb/tfvavZldtT3xWDrfwYPKA+HlXOncbssXMuHwBOGeOhx uu6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774360478; x=1774965278; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QRP8waOAFbU/kyinDmGT7grAQld1bjZSxa4dUhXQ9j8=; b=U6RJiDb2m/4M9qDYtbIhjuYU92j58+1PKLeWlLbTjMlwo477fGMfeD28cNYWL9LpHh 0tbaE6X2eBpXKfdq6HAbmRSXdK/SGsOAyRMmKwxiOwvZBkswzDEa45wk8iJpgs3CRG+4 qNjq0+trXKC+Nyx2ZeAqN+y4BFQoyOZp1o6gbgM2tqwK9Mnt7uD20JNKu7NyY0SmPynS KR0hMLlUg4HuC/VMBRYmT4lY0IGPAnpd9vk0hWrODViQHO5miUb8rYUIywfdlP76sn9n 4OufdOCnMVknbvNGhXu2QsX3vfFZQs+sxLUXYFIeizKStQamria6a/GHv/wKOIpOpKt0 UGKw== X-Forwarded-Encrypted: i=1; AJvYcCVS6Qee5Z6s/f6/l+8RH2wJK2iS9tlTXRdRnoe/AQAX4nVQaXE6y/FeuNVcOcgwHXOwkl0CDPP7aSBI//M=@vger.kernel.org X-Gm-Message-State: AOJu0YwhvMEo1uHhm1ajsMxeRTY81WOmookyFzMqzC8C0ciOoW4nRGBE fBQm50QTuJB6Fpb2STftv+36oaiF4QQEHR6NV5JF9XQbf1ed1LZb8eqP X-Gm-Gg: ATEYQzx2cBAD9y0A7exvDwZy0MrQEFFpl42OZh7audIOrdmN+qCjbQg+VbU/y3LhN6e Vj7QqdadiBJui2VFFeMAVYeO4OODilqPKlHp3DybuZO3j7gYj6Y0LMJ2T1w0e85PnWYPAC7AOyS w+Mk9CdOMI+bnQ5V/T8DEj6Rkd5JyS4qahahLiWCYVxbC0hOlQT4CxsHX5SOVLU3+UBmw+5vskq HuI1QqGtUrRasDP0dLiIPbgX8iBp4nX6J9jVf2nr8+ELp6uFh0OaCdji9OqwfDAG3sC6LFSIvZf FXbWrAzGf9KnmPb0NaURPBQcLXzys42kMLXZp0vLP4UrNgvt8FeerHc9wclWDT7AIozGm87E3Mo Tsia9utkvpaSDo3CBjRgRHm7w5AVTLcTIN27UfJumIpLfLt35zW6/bmCrRkNsL3o01HqwEUacaJ yIUaTcJdLW8AYaoNucQFXWiOuR+VPcyCy6E9rkZqUJp2VjcKP3PWdSG7VrKj8MgnZGsvH+ X-Received: by 2002:a05:6512:1092:b0:5a1:1e49:66 with SMTP id 2adb3069b0e04-5a285b4c3b1mr5765705e87.29.1774360478127; Tue, 24 Mar 2026 06:54:38 -0700 (PDT) Received: from [192.168.1.135] (83-233-6-197.cust.bredband2.com. [83.233.6.197]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a285207454sm3162823e87.48.2026.03.24.06.54.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 06:54:36 -0700 (PDT) From: Marcus Folkesson Subject: [PATCH v9 0/5] I2C Mux per channel bus speed Date: Tue, 24 Mar 2026 14:54:14 +0100 Message-Id: <20260324-i2c-mux-v9-0-5292b0608243@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAAAAAAAC/2XQy07DMBAF0F+pvMZoPH6z4j8QCz8mrSXSVAlER VX+HSeCJjTLsXzuXM2NDdQXGtjL4cZ6GstQunMd/NOBpVM4H4mXXGeGgBq8kLxg4u3XlUcAIzN hIJVZ/X3pqSnXJentvc6nMnx2/fcSPIr59TcD8Z4xCg4cXfIqGAFewuuxDeXjOXUtmzNGvDsBs HFYXTTeaaNS9to8OrlxCKuT1XlwIenU1CLy0ak/Z0CgW52qLhMpnwitSbueenW4udGoq2sipth 4b33c7TNbZ1Zn5p6R0FFqsqWdsxuHm322OkpWRxTKChcenVudFGp1bukprHRB5Qb+uWmafgDJR B1cJgIAAA== X-Change-ID: 20250913-i2c-mux-b0063de2ae4d To: Wolfram Sang , Peter Rosin , Michael Hennerich , Bartosz Golaszewski , Andi Shyti , Andy Shevchenko , Bartosz Golaszewski Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Marcus Folkesson , Bartosz Golaszewski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=4744; i=marcus.folkesson@gmail.com; h=from:subject:message-id; bh=mjEq1PLPEBk6WppdYqh8OnJbPCI24wJUo693CNzhVxg=; b=kA0DAAoBiIBOb1ldUjIByyZiAGnCl4ihOVbUM1/DAKdpFQ8kxKpUb1xZtLbfo7fnf7aT5M0Dy IkCMwQAAQoAHRYhBAVRoui2bLVNZMEsZYiATm9ZXVIyBQJpwpeIAAoJEIiATm9ZXVIyj2MP/0hO tjuOdfF26sMuJ2cbc6bBmzIEMSZmxyH5GEfLehZpPRVjH/Sgl4/mDurhso2APzEkySojOB80RHO u7jA3MEBLMtBq9YipSxFaTkaTUFbqQGr4zLWS7ZOxhmOce9QH5qQK7HP8ITp5ywRaG86A7QkUjJ bHIVGs3U/qYm8OlpnBz177dnMTB6BuOfvaFmLfoi/rXwBu0Jitj8vzc88BkGtfU70TIrXHssqDA QzhElYpAExnxxffLYP7d3k14TBh3SUPLLEAp2ltlMidqAs3+MU516VVvvPP0sAVc0iXtn8qgRiA W9weKNO/WDm49aC3Ior8fHTFoEEbYaoWjCCXLy8tyhlJjTDtBJb4QWLPKQ/+jXnSVb7G8+cINPz JTfzvwAk3yq4Hf3EWgMgjs8A85Cfwx5GA3gALok5qvh+7aHxRpEAqHkL48R+rD40/KPlftVo4Cr K3JOwOs1VX86Uxq/zMBtO1wluKIv4y1mJN8+nTDBL/VFRckwy77s+g0VBnHGPasxCEgFYETesCC klXG989ANI5EkE4ZOODdyr/nKLtX8lPmW2dFJMQvBKLFnFltv73BPByA4esSz9ZzC8s/O4Fmmnd ijk8qvKY+6/A/XfZdXTMYlBUVYNkoFBiJoPpdUp4oDu7VRRVhyCXWEcjrAXeZwoeLQfm0do7dBT udbmD X-Developer-Key: i=marcus.folkesson@gmail.com; a=openpgp; fpr=AB91D46C7E0F6E6FB2AB640EC0FE25D598F6C127 This was a RFC on how to implement a feature to have different bus speeds on different channels with an I2C multiplexer/switch. As no major complaints on the design came up during the review, I decided to submit the series without the RFC tag. The benefit with this feature is that you may group devices after the fastest bus speed they can handle. A real-world example is that you could have e.g. a display running @400kHz and a smart battery running @100kHz using the same I2C controller. There are many corner cases where this may cause a problem for some hardware topologies. I've tried to describe those I could think of in the documentation, see Patch #5. E.g. one risk is that if the mux driver does not disconnect channels when Idle, this may cause a higher frequency to "leak" through to devices that are supposed to run at lower bus speed. This is not only a "problem" for changing bus speed but could also be an issue for potential address conflicts. This patchset has been used and tested heavily the last months on a custom board based on a da850 (DaVinci) platform. The implementation is split up into several patches: Patch #1 Introduce a callback for the i2c controller to set bus speed Patch #2 Introduce functionality to adjust bus speed depending on mux channel. Patch #3 Cleanup i2c-davinci driver a bit to prepare it for set_clk_freq Parch #4 Implement set_clk_freq for the i2c-davinci driver Parch #5 Update documentation with this feature Signed-off-by: Marcus Folkesson --- Changes in v9: - Fix stray blank line - Link to v8: https://lore.kernel.org/r/20260314-i2c-mux-v8-0-fb1738a4df0a@gmail.com Changes in v8: - Fix gramatics and change %d to %u were appropriate - Link to v7: https://lore.kernel.org/r/20260223-i2c-mux-v7-0-ec75b214718a@gmail.com Changes in v7: - Remove code for finding first mux-locked ancestor - Introduce a unlocked (i2c_adapter_set_clk_freq) and unlocked (__i2c_adapter_set_clk_freq) variant - Let the locking be handled in __i2c_adapter_set_clk_freq - Use I2C_MAX_STANDARD_MODE_FREQ instead of magic numbers where appropriate - Link to v6: https://lore.kernel.org/r/20260216-i2c-mux-v6-0-9be28ecfd7e3@gmail.com Changes in v6: - Change logic to find which ancestor to lock with I2C_LOCK_ROOT_ADAPTER It now find the first mux-locked ancestor and then lock its parent. - Remove bus_freq_hz in i2c-davinci and only use clock_hz instead - Mention in commit message that clock_hz can be used to store frequency in an uniform way - Swap order for change freq/deselect to keep symmetry - Only allow bus frequency to be lowered in select() This to not allow an intermediate frequency to be set when it is not supposed to - check if(ret) instead of ret(<0) where appropriate - Fix typos in documentation - Change i2c_adapter.clock_hz from int to u32 - Simplify i2c_adapter_set_clk_freq() by removing 'ret' - Link to v5: https://lore.kernel.org/r/20260213-i2c-mux-v5-0-fb2cbf9979b3@gmail.com Changes in v5: - Take the lock of the top-most mutex locked mux to make sure that the root is locked - Link to v4: https://lore.kernel.org/r/20260128-i2c-mux-v4-0-dee49ce276c0@gmail.com Changes in v4: - Rebase on master - Swap order for printing warning about "channel %u is slower than parent on a non parent-locked mux\n" - Fix typo in comment, adaper->adapter - Link to v3: https://lore.kernel.org/r/20251020-i2c-mux-v3-0-908ac5cf9223@gmail.com Changes in v3: - Return -EINVAL if channel is faster than parent (kernel test robot) - Link to v2: https://lore.kernel.org/r/20251002-i2c-mux-v2-0-b698564cd956@gmail.com Changes in v2: - Changed bus_freq field to bus_freq_hz in davinci_i2c_dev (Bartosz Golaszewski) - Removed idle_state from mux core (Peter Rosin) - Link to v1: https://lore.kernel.org/r/20250922-i2c-mux-v1-0-28c94a610930@gmail.com --- Marcus Folkesson (5): i2c: core: add callback to change bus frequency i2c: mux: add support for per channel bus frequency i2c: davinci: calculate bus freq from Hz instead of kHz i2c: davinci: add support for setting bus frequency docs: i2c: i2c-topology: add section about bus speed Documentation/i2c/i2c-topology.rst | 178 +++++++++++++++++++++++++++++++++++++ drivers/i2c/busses/i2c-davinci.c | 43 ++++++--- drivers/i2c/i2c-mux.c | 107 +++++++++++++++++++--- include/linux/i2c.h | 35 ++++++++ 4 files changed, 339 insertions(+), 24 deletions(-) --- base-commit: 1f97d9dcf53649c41c33227b345a36902cbb08ad change-id: 20250913-i2c-mux-b0063de2ae4d Best regards, -- Marcus Folkesson