From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF05E35BDDC for ; Tue, 24 Mar 2026 12:20:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774354805; cv=none; b=bN4uJqXnyF5VOkKdWk9gWwzZkV2+G0XQxl9ESSFA+Wvs1IBhDNV1Xj9vxqFH58PYk2hw+FuUcLg6vk4khLhSEFl1/uctnnN21wLzWiB71nYyh88ZRNtc8oowMlVGuiVcZoTAHJE7YOuNtf6Dz7fkqbj05vJPaqjlJPxURbrjnFw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774354805; c=relaxed/simple; bh=GuqqBIfeWAwrMihNMcO1RBag4cy/713ffU8ACJsVy8E=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=QP1Q/11aiUN6RtCiE5v0b8aWoNUi5f9Le80nLrpMrU+GAh2/LOTbxi6PH9lSawqjdNhl7nl8hQ2pQj/rF3C086DRMqMBLBsXZbiumcYu8YdwpRtn7jDhpLldGmOMp+kQOZZDaLsudAGGIIf9mx8D8+FP6zV8QE3ngetzmm5qpvs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rvsfnG9u; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rvsfnG9u" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4838c15e3cbso43931705e9.3 for ; Tue, 24 Mar 2026 05:20:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774354802; x=1774959602; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GuqqBIfeWAwrMihNMcO1RBag4cy/713ffU8ACJsVy8E=; b=rvsfnG9ut3wLkh5gwA0zQsIVUi8L4jzx/gChLSp5b1lXSwp5e7I68S+DhVv8FnqidU 1TjgBjvu32+BkTL9Je7oEZbYPHlqBMtFdUdD2Gscrn6jFPfZinUlj5VM1H+ax9OMPIH+ BhcPynZFiJIwRph2f+okwfMfNWKOPjv3k1R4klP9F/30sZ7CDrnK/S78pmAXZ6H0fFco c3JfQYgCIMPPE/JRd8OJI1nKZ3ieGtbbp+Fn/GsIlTc2/38+9DO+TnJ27BIUIYzr9fBo vu+r5ZOOCAMFXGVh8dYn2eLaJrznf2ZxaXBYi2OktQiBAIT+2Gvxb8oCTq7C8CWDGtAM jcNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774354802; x=1774959602; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GuqqBIfeWAwrMihNMcO1RBag4cy/713ffU8ACJsVy8E=; b=EmdSYhnW8RkCbmf2xCG85CRIflhCR2HKmbB6ABy7Dqk0+OLPBhmUhJg5eZ5vhT6Haj 5pPTQcgGHRuvvn4rx+aCfwATz9UBfH558rFyVXm+p21zVwSLv0VIp3FWyEA6GnVGBBps 8bnHD0g23Zn2eX43mSGH9m303FzT8O9Oz259U4RAxFqNfZnbK4/DNXgwjJo1wj9zhIis gZf6XLKHy4KvDm9Cwxybb3l0FtMwbj8wUAMhwKHFN22z/ihECMCTXsPWaX2nsvGVeiS9 AFfOts533ZJ/zgIn7FKRQgSoYv3qzgbRtMoE4Ie6GNhg4j4xU0UZMY1bniLaCoalZkDf XdPA== X-Forwarded-Encrypted: i=1; AJvYcCUhmqUk8gPPiGpmPdIJZ6iumgy9KHI+c06CZaeXMRysSlduSsTpL9B92aynDgcc2gX0g4hJ0ZmtL0uOiNE=@vger.kernel.org X-Gm-Message-State: AOJu0YxhS8rlySrRf/PvjvXO6lDfF+OU6u+KT7qBD7ywhkwHfB7kl2KU kxHGh6eOQztiuCDtSM0GVctNCFyCb6j3HllxEC2QgpTnMuRnGB5cBPDK X-Gm-Gg: ATEYQzwdHMjbuZ4iyZXoLeGl4YopoyqxQEPDSdLFTO82s9OZHJKQybRpPiSocz84jkt 4juBUgUds87nzsLt1rmpkjZazlS/53hkQudMS2eevJZAFzetdianQtfamvudCehhjGX06Ku569k SKUzwq1yyWzV7mnaiEVb/U5dKVtqECnUDp5KM7M5K4CbHWxf8u149hfbFrX14BvtvHo7yjSb31K FWQPrMu19+G2r6OKts31ousmVEDpgADiX1RprQze1FJkb6+RzrQxWzORmolHxxHTFeP+TwQTmgm tMGbpjkVtQ/1M/OBZSrbKmaEZHkFhe3MxUAt9k3o55ESIIkmi2pfDnahlDST4sBruLYB9iOHlgq NMIWe5Wpv3V59v/kza0HVHqswoW8Q7r0q/wQDDqU6fTiwWYne9RXyQYxeQ3LjAWiKNNQf66vpRX 8NoWSOIAqj65r2qbVoYzzDA/BsIHbqBglPtlX5zMWE2LtdRKQ4ZFPYjl7mgpZn3Q== X-Received: by 2002:a05:600c:3d97:b0:486:fa35:aef2 with SMTP id 5b1f17b1804b1-486febb5989mr223615895e9.4.1774354801994; Tue, 24 Mar 2026 05:20:01 -0700 (PDT) Received: from localhost.localdomain ([2001:8a0:6c9b:a000:e561:a158:b78:a92e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48710fa0e35sm43400685e9.3.2026.03.24.05.19.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 05:20:00 -0700 (PDT) From: Gabriel Rondon To: Andy Shevchenko Cc: Jonathan Cameron , David Lechner , Nuno Sa , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: adc: ti-ads8688: use read_avail for available attributes Date: Tue, 24 Mar 2026 12:19:57 +0000 Message-Id: <20260324121957.75404-1-grondon@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Tue, 24 Mar 2026 13:42:40 +0200, Andy Shevchenko wrote: > This is fragile code (however it probably won't be exposed IRL) > if ADS8688_REALBITS == 32 this is UB in accordance with C standard. > > Also the trick with -BIT(x) is harder to read than simple GENMASK(). Good point. Will rework the expression in v2. > Do not add trailing comma to a terminator. Will fix. > This is actually slightly different style to what is put in the above. > Ideally should be unified, but probably matter for another change Agreed, will leave for a separate change. > Why is 'i' signed? Will declare as unsigned int in the for loop. > I would leave this on a single line (it's only 81 characters). Will do. Thanks for the review. Gabriel