From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDE3A3537F8 for ; Tue, 24 Mar 2026 20:37:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774384649; cv=none; b=oTKZhJ1HapMpjRX4f6NtUhBfT9NhevW2y79UqNUSjff6HsJsGfa3m9my1ARWMRpz9kgXF4yZiIg7ak7oAaeBywVT1egcf7su7YYRHWmKBrO50EQgRpTgmHAseWr5DYwZfxo9eU4sC+B4fQwJ9SbgmA4u6ey3xE6sXQxcGVO+5ac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774384649; c=relaxed/simple; bh=2fb9QmqUnFFelrj6A30F7vaMKOKb/UcvjcX+rchrfqU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TMktQTyId02ZERIwwj7rmn1ArzWJ/ETbtmWaom7jTd71zdwz8mEP72x1wmoP/GKuJLkuJ8pi4HUrks1+tHLjevresHeoEShQkkY/zOnP/ge0lbHX2z+IBqkOKzKI1bcAKswScd/PT+7v64U5y6jRmKfRy/dnDG6TwnRG6pYUYQQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EeS/98XC; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EeS/98XC" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4836fc075d2so6144605e9.0 for ; Tue, 24 Mar 2026 13:37:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774384646; x=1774989446; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=kl2wSUguQHFJVaa5PJoa/q8MZubAAVwaDsB6skZ4oE4=; b=EeS/98XClSeBauhFPhrpU0JFT1XSiS0rIM8IgdBVMWxWoMHU9BXljdhagy4Pi0Du7A zb4/gKn//2zStgbwXSlNq5LokUpVq10vUD3lJUT9uas2trTFB/Ps+0A8ffnar029BldN 7zAQPJGNUMD0qNqWILX+MDEHIVcS9iXNVuBPYvq5ZnOQ2TdqqnfcfwDqwCLRs2RiFNiA Drf+n5ncyJVlKTvPkF5C0vnw9Nskla51Zkf/8mOubCOkztKfh6MraV8b2dNxM7lZR9N8 ZpRK4G/x4CEPDcIsG/5pQ2sLSXUdf7ac4hcZvTaiZJZCZPQVQaGpZhNRIv5W1u03vyMo btgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774384646; x=1774989446; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kl2wSUguQHFJVaa5PJoa/q8MZubAAVwaDsB6skZ4oE4=; b=OgFQnRvQ+4G5lqtlBJSqoa1QMXRS/sqpWZ2I/YB8Y7V4RhWP4ISveMXvTIDYL8LU+k vbYVd5xWW0Ji2Debxo+5Qu6QusyYpPQDITcvgUmX0LXuOC42YJJ8XHQrUC3FE+62XlyQ 8u4B3XN6jwDxkrwQSfA7+bqFtYSOmsqq8RtbUeQ6oyJGDMmmISU5xHWiAvz7/7opAfu1 4JgPEbgJrx1TggLtv9KUeTIuEsYv8DTfcPewMZsM2cSJaBYJjOfdLB3KP8Yq7N38VXvT 4EpCI/BN+8u17MBkF9bH3Mzj89ZIH9If4Ei1H29k+Zo5jimtGrmUYbLjekppBUi2hrQH zV3w== X-Forwarded-Encrypted: i=1; AJvYcCU/rDHMOfDrMuXyTRXMpTXKdj/h2nKYHWQ81xW71oZ07ffJj7ZtVcckJrqhh5yH+ExjszPaZBwvhsbxBXo=@vger.kernel.org X-Gm-Message-State: AOJu0YzLJHubP1zyo/6WXwMchz5DPiR1p31mLfL6p5/vZbhmiOJCvZp/ PR4gTX8XQHxUU07vGcITseOXW0abtz3gSl74V6BDEKCPevRpjGVzli7b X-Gm-Gg: ATEYQzwHKm6TJrK07OG+Zr7RqmVEoJCjgyOZCDrQEPOpm9kpaJTKeemcIYKPU/xAZeN 4TKzE9QypwQKuay8vZ0Jc+IZB6dPrj6Y0HEkVuHPcCILPYwm7TvC9ZBy0XLZjOqhn2uiXjIxfKi aWfYDBtKNadY7KIybBWNnNc18HQWsUZgeI3RbTO0+rg5H2z+mUFjyg+4aE5716ozNLUKbHypaKk WwXt4R0re1WDTRLCqUCpPXjkAj3sOtADxptBPH+zzlPJWoxCiYWmnnpPbS4MEmj/CqQk671Pf4M bSs1o/8la0OPdocq7Xdl2c3xTiTLwuHiRvcIuf5S9JwQBx5+O6i8/7nJx/juOcNPGKBi6sBD4uW wUqcXDCakrS1kXX6ga84rXXzhxz+nt9ZU87ythHtXhRkApstHg2VJk5K+MqgbVkMeRu5lLt3AA3 /q2F3b7FN4PM3UsA== X-Received: by 2002:a05:600c:4f95:b0:486:fcf9:5ba with SMTP id 5b1f17b1804b1-4871609da81mr9456935e9.7.1774384646022; Tue, 24 Mar 2026 13:37:26 -0700 (PDT) Received: from skbuf ([2a02:2f04:d50a:b400:1955:43a4:bdf:48ef]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48711693a08sm92104015e9.2.2026.03.24.13.37.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 13:37:25 -0700 (PDT) Date: Tue, 24 Mar 2026 22:37:22 +0200 From: Vladimir Oltean To: Maxime Chevallier Cc: Andrew Lunn , Jakub Kicinski , davem@davemloft.net, Eric Dumazet , Paolo Abeni , Simon Horman , Woojung Huh , UNGLinuxDriver@microchip.com, thomas.petazzoni@bootlin.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/2] net: dsa: microchip: Drop unnecessary check in ksz9477 PCS setup Message-ID: <20260324203722.4ahhkivou33kdn6o@skbuf> References: <20260324180826.524327-1-maxime.chevallier@bootlin.com> <20260324180826.524327-2-maxime.chevallier@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260324180826.524327-2-maxime.chevallier@bootlin.com> On Tue, Mar 24, 2026 at 07:08:24PM +0100, Maxime Chevallier wrote: > The ksz_dev_ops .pcs_create() is called under the assumption that the > switch has a PCS port : > > if (ksz_has_sgmii_port(dev) && dev->dev_ops->pcs_create) { > ret = dev->dev_ops->pcs_create(dev); > [...] > } > > The KSZ9477 implementation of .pcs_create() does the same check on > ksz_has_sgmii_port(), and protects the entire function with it. > > Drop it, saving a level of indentation and increasing readability. > > Signed-off-by: Maxime Chevallier > --- Reviewed-by: Vladimir Oltean