From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4F233603D1 for ; Tue, 24 Mar 2026 21:40:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774388443; cv=none; b=IKVYmaA0pK2mwRYIkl+NaKLT+JS1fUSN7uPWKpO+XM2erFY1fuRUS+ugvm/FtmJLv28dV5u+Q7NJ1IDgYB32gGJSU/IwBq90viker2OEKPlB5Bm5uHUm9dViprLHEAoKiakzJN+ylKNA0IehF7kgjfU8oHsRif45jXPmXwZpN3k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774388443; c=relaxed/simple; bh=GzFnRb/5aNO0rFNdzq3eanYc+4uzepiO1YNcdlnwPW8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eOKKbkVYMJXsL3UGJbi4L7CWvGb4sZtFsICCNo58xAgUTYGq5mUQvo0a/Bu36cAPNuilSYvCeQye41S39wgaarhvRNvfzxlvEAyrkcQw1LOxgPCudZQXiai6yGn/1cvRIN9JM6w3AeqageDkvOf+McuVg3Uam+c8QuDCwPM/eOw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iL4rP82k; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gnNoqX/s; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iL4rP82k"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gnNoqX/s" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62OJnk292075441 for ; Tue, 24 Mar 2026 21:40:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=VIBitPKQ5iS p48Wf7+RJ4YDtudeu6rRnT1VURwtasZw=; b=iL4rP82k1o3uqKVd1jzG0fbBm3P XnQKjcCYzOwFANYAZHhF8QJ9+R0/O/kGgCSMNjrti98JITh/2D+KOStCy2s1W+yC 96LjMKuvwq7x8UgRBjldEwwL2jcmJayL6QdqtrzVfz1i4sFL+3FPmQbgWiI6sGsl eREcAOYIc6JerRtZlf3zTK81smQWJpFBQkTv6ULshDnDhqd1T+5NswbIyvO40gBQ 2C/U9mCN9OMS5fm1LFidvoGfmH514W392sJIBhIUrnCYRAU95gOMLBPUcNnrGOg7 yDRZlYhgdaeuHC6wdT/fmLGsOCHqk2pTsCT5kpJQNqKl3ZT+zcqKJewaoeQ== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d41410a3f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 24 Mar 2026 21:40:41 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2b059ab124dso59308255ad.1 for ; Tue, 24 Mar 2026 14:40:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774388441; x=1774993241; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VIBitPKQ5iSp48Wf7+RJ4YDtudeu6rRnT1VURwtasZw=; b=gnNoqX/sEugBdJtxIIQQc0jyp7QGPlhRaaGcphCAP5xuIMX8uFvU4BNNK4zHwGk+gd JKDs1UOKDiw6VfRL1tPLxn91+UHALXtcdQRaiIQmuXkLKHp6SbqWxt3paPz+fcSrC2w4 ZKZ+68fakgVzVQvbW9Npvrmm0HHtL/iWEzx3GmRKMtBSd7q8oQsm3hTUI+59dfOlb2Fq VFCKKRDrkEHSY4QQ2IqmPZNx+7gu031PreG+ruF35fG3Dj9QH+sTNQtXvXflGe+Sd2kS fdN2NjVnkWAIh3noTGvCsopUyHSFdwNQ91l/an30xL3fhL0Ek8bpkVnnHS4awfjXe86m ADYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774388441; x=1774993241; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VIBitPKQ5iSp48Wf7+RJ4YDtudeu6rRnT1VURwtasZw=; b=noAMGILPay40yMEFUskleY28Ri+q08iV42lsfHwBtIjbe9Fng6gBy1LRgBRoIWWLSo bBGyJReeAQVQfZ30bBvI8d6OPljahbF78CVZPJdPW2vzLod1YxQn1Is5Wa4XoXC0dv8U WUkoB3XQVUep5GXAvGRIRACyi7rDMl11YubtPcMtY0IR26gNcWu3htAG3M1zA6EkdGsg xWhX5XT+846sirkhv8+/zsimpZrspqzZvCmVcwnztBl1EPJuvdSxwbN9PYne7h3iCwo6 0x81F/OTOesG7fWmMJJgzHgiPNnPosEghclpJrxWIKuYQMGGuMR3hltR+YFt57WgXSdV oHxQ== X-Forwarded-Encrypted: i=1; AJvYcCWQmYNkcDx2LVRy3rFwZ1D14BbCGpedJY8qO3gurkpVyzuY3c6YZ0GATD0evm9gaW7HUxh+b+i7U5F8vgY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1KosvcgH9NyQvgET1NWRVwQdyAwTfsgRCODTjp72oyW85Kabp VeRyK7F3ANYzfolghxVVOVkR+pviEQUVjZ+tubhuN4RGzJVWtOWKYQwtNysgiZ2vgs5pc/+jOSY JCCaT1f+q8cVFMybR9YgJDuwgB+HNwi0CW/c6kO+eQZ2SZJlRCc2pFQVKwQ3bqWlQJto= X-Gm-Gg: ATEYQzxrGM/UNAXpiVVtwMrQ5ucCeYGhg2cK5SJ/P5UT+Qk2MBOVcOHeCwjjpmVBsi2 rgtucDVckHR57qGVVgYbyC+zOYwuWaJAu3+KFhCoLnbl8HIOEzHSfrfLt9P80v7CcY7oGSxGjn4 nI/mUQg0dUa2Z/nl0c9YGLpo2lQMpOPjQbtqWd5dBQbDQon2laxsFPhl4xJshmaSLWz8EdQTyW5 +eLvMJYZhCrtjH4YxgA/C0fiQKc96MXkv97cvXMJfNRql+xgt3gc8Vat6C/9vaadCw9laGL6BXP ChLWI8Jdu1X7NZyTan0LKhOfeG9EV29M1qWsm01AWOKnxaxBPnKuJTvzlC8170ao601I4VLPKko GjLN4wjBYHJKrVLMAkKRjvAiJeTtNwbJP X-Received: by 2002:a17:903:b88:b0:2aa:d506:d189 with SMTP id d9443c01a7336-2b0b0a8d22amr11738685ad.34.1774388440899; Tue, 24 Mar 2026 14:40:40 -0700 (PDT) X-Received: by 2002:a17:903:b88:b0:2aa:d506:d189 with SMTP id d9443c01a7336-2b0b0a8d22amr11738375ad.34.1774388440320; Tue, 24 Mar 2026 14:40:40 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:4ec8:83f5:8254:6891]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b083529e8asm162554315ad.20.2026.03.24.14.40.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 14:40:39 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 2/2] drm/msm: Fix VM_BIND UNMAP locking Date: Tue, 24 Mar 2026 14:40:32 -0700 Message-ID: <20260324214033.1219113-2-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260324214033.1219113-1-robin.clark@oss.qualcomm.com> References: <20260324214033.1219113-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=fOk0HJae c=1 sm=1 tr=0 ts=69c304d9 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=xqWC_Br6kY4A:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=eWlSUfSnBrBg5eVjM6UA:9 a=ZXulRonScM0A:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-GUID: Rq5t-IFPEAHuSu8QbAYwTZE9GUMUpUXW X-Proofpoint-ORIG-GUID: Rq5t-IFPEAHuSu8QbAYwTZE9GUMUpUXW X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI0MDE2NyBTYWx0ZWRfX6Z7gJwZ5A8Jr DlTyhpnHrtgIxjfFostt3Cn93ysPj5Y6yY7UfDEVs8JE8ZsGHDbPaJ01E61VIOdM0xdr+d4e5aH /eZcIjz0Rfx/iAehK44gjbA8IEt3UoW53aogNZx5n3sOB7eQixePs4i3VZ/NJ3d0tOntpXDBvLY 4TpnZQDRhomUDxtr6W4lVjFYS+DdhTeui9tAUf0PwsWRx9/xoBJBfoBRQiaz59fCWsv5kb3B8ah mrPyDnXYERBpNT0VsI4y9wbsgVr+qRLrll42WErcY2FslwbolJinKe0cZTfX98YqPDVtiz5cjSz wMEbVTL50m/ElBX4lZ+ctXY0Prx+4gWXWgyH75oxu0vaL2oJpbvYSeGDlL6Q83T4iJbnXx2tfVW 0NmuMbrFbrjcTlCKnzy1Oscy1mjSUWcqMljMZGuj646X8Ppf/KBLI76p1exVJE0ViWRaZk5b5v6 fsBz75AG/jv2GMZBv1g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-24_03,2026-03-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 priorityscore=1501 clxscore=1015 adultscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603240167 Wrong argument meant that the objs involved in UNMAP ops were not always getting locked. Since _NO_SHARE objs share a common resv with the VM (which is always locked) this would only show up with non-_NO_SHARE BOs. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem_vma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_gem_vma.c b/drivers/gpu/drm/msm/msm_gem_vma.c index 68a8f8f592fb..40892e206dbd 100644 --- a/drivers/gpu/drm/msm/msm_gem_vma.c +++ b/drivers/gpu/drm/msm/msm_gem_vma.c @@ -1251,7 +1251,7 @@ vm_bind_job_lock_objects(struct msm_vm_bind_job *job, struct drm_exec *exec) case MSM_VM_BIND_OP_UNMAP: ret = drm_gpuvm_sm_unmap_exec_lock(job->vm, exec, op->iova, - op->obj_offset); + op->range); break; case MSM_VM_BIND_OP_MAP: case MSM_VM_BIND_OP_MAP_NULL: { -- 2.53.0