From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 526152D8795 for ; Tue, 24 Mar 2026 22:05:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774389935; cv=none; b=DsTHSkayp1yLBkZiOsPWWZwpSqONQmBkqBoQJ4pm26Rehr40e2uYQn4rAkHO+B3XpL7oHDcAoFrodv5a/hxa2uUoKfWJq2WirPF3CbBn9/xGvM90zp7oHs+wITVYSwD+X244tsD8V7tfEvI2lldamRAR86MGs/zexIq8Y1Vio58= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774389935; c=relaxed/simple; bh=/9fTrHRnTkDBs/OY7n6Su/4q1bIQL3OgpER3yvd+nOU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Q2WHlU6+BP5V8BcMb0zCbFjoyyHB/9MoPjvOC1Gw3bi+pOD92HfxuPofC3t5LpDPC/SrbxssLJhvtt8fIb5bjhMWeExIZiybcNJsHUJIQe1F1+GSYScbSkZ5NFF3VWxVSs9mEcqhCIZapm/nbBABD49hFY2Bt0jvkEOesFNgv8M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BWQZXGVR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DDmoxH3U; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BWQZXGVR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DDmoxH3U" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62OJObOQ1862785 for ; Tue, 24 Mar 2026 22:05:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=hXs1ilEphqy uUJvSiSscnyD6ZgL5ByYr+YWWml4pGG8=; b=BWQZXGVRXF1yKOdkm3mktusTWAJ PKmrGhLoRX++t0nau4hYbyhyD1Cw1ntnl7VXuVqvhkQZLD3f2LRMA4ISFP0CTZUj xQPX1EIsOeu2uY8jUoTdOPrqOg+z0lWy/YtpW59g2Od09oFjADtMN/1MloOo8vK/ UQDaWMw3PueUpAAiayMUfSw8dT1eAdz2JqW/T4+TZtmxAW3SjRMhQcz8i9zlBdO9 cBtSSAZbq5yowX1d8o2dtYT4eKcE7p1BjmKs2Lily/vIJHUa57k3p+V5EDg3mzS+ Q4Sot5oLNTkjZU12M/fVxM04bld8w47vgTQwnoGAY8SL07c33em7nDYu8AQ== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d40rardur-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 24 Mar 2026 22:05:33 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-82c70d1f56eso72462b3a.0 for ; Tue, 24 Mar 2026 15:05:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774389932; x=1774994732; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hXs1ilEphqyuUJvSiSscnyD6ZgL5ByYr+YWWml4pGG8=; b=DDmoxH3UpkLcRMhBTpfiiwYzbSvKvT6PnoIpu7edHp50Bg4NwrD1gE0OkvQT0TDSel 9XzQv6P2942ZkH2ctxcLVi5R5qhev6YYJbbNkEcPtYtkdBZCTYwm6fQYJHJLnLXvuJD8 cjYADw+ZM4y2D0WINfWja0So6K3zHuZMsN+uWOGLyJCLB9CGakXmhQDioyeuX4Gsxi79 TwxqHBo/i8Qv0zqA0fkFV8jpKAI8BL3ryECth9/gu2u9O3y72b/JlPOKbaTpj1jXpqVP beRZY4T4X1KGwfSY+L61ojXMZbtQYrK0gOJUNl0ZgWM5/z1ItKGOP37pwK715WX/6VFn bWHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774389932; x=1774994732; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hXs1ilEphqyuUJvSiSscnyD6ZgL5ByYr+YWWml4pGG8=; b=SWox7nWKGmTSRPg2cRmRh/F5Qq/J09rD33bDCrDAOwxTiMx+7YDegR1g1DV17wJxMX YGBx8KEtJI5JIFiVRNUTr05xctrwkyPG0hJ50rux9n0zIDxbZuJeZpW3mNRFeSVqJasg 0KR7y3OsC6HNsbIzRbXf7ZZzejLSpLzXShXLXVNA83k4DqeYiK45ddnTrd5EjkOUVmOT 4EnpQYiOzcIYZFopaBcJFs8PdTfhUD35cJyUjEz3bUbnPzIS+cGLortqkmfCBgQaeNjs 35oLeuJk3oIvuw7aoEOyMnEanOb9N1oXRcVp/TdZjVUAhkr+0XqjVlnKbV7N5ItuE622 ss0g== X-Forwarded-Encrypted: i=1; AJvYcCWGitTvqFaD2OtFKkriXhVeIJCvK1OfjoHvOa6KkTm/5NT49cuepGwtpaYCxaLe+sB3aDpZpicunxZ6ps0=@vger.kernel.org X-Gm-Message-State: AOJu0Yxa+Yrp9yqOVwkgnfleK6GA/0ZhYlM3QcTH3M3bTcduW29i88+y RFUHr+We+oonzm8yil0V4d06gtEoy6givJMbbanmoiB790lH2rJjHmHDRhCNwlubfr1HbqxXRgZ qKd+KKy16BfN+Y31FiidrpGj9CXrw9FMXzyNjZxZr+LMZL+E36iPBX0iIzEK7lDvPzRk= X-Gm-Gg: ATEYQzwCcIiqBniU1YOxqPtCky4Se3IUu8I4quoEDN/v4Y0jEuNC4Fn87yU7VhTXepY GLw7hLalR8Tdvgw9jz28kcb5sFpGvdAJwWs4wT3A84EsUnxEFlkKETrmJ9QFjVvepE0ov0lKRhv QR5UuHjneU11xCaqYihlAB+Sb9fmAX/7/HSQAPJ73aV06sGs8p5bm26xJF0TfxKLM8W+8V4eanL xU26JRaJc3FKAP1uXNBWNxFrZV+GBtGrzIM/uZV/jciopsAwZMY7lGzz7vB7AivQD1vx8PJDjnF tj+9Wmb9wbVDdyF73yHqxzm1qAy/3dRVTmAKuuge4t3kqNm9w12ZDeG0+JqgvOCibAwsFk7zTmB 94hxufKphWXafdW2RR184u9aNsFhtpTz/ X-Received: by 2002:a05:6a00:f05:b0:82a:6de8:fa4e with SMTP id d2e1a72fcca58-82c6de9f009mr1353428b3a.17.1774389927490; Tue, 24 Mar 2026 15:05:27 -0700 (PDT) X-Received: by 2002:a05:6a00:f05:b0:82a:6de8:fa4e with SMTP id d2e1a72fcca58-82c6de9f009mr1353343b3a.17.1774389926197; Tue, 24 Mar 2026 15:05:26 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:4ec8:83f5:8254:6891]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82b03bbf0c2sm15880581b3a.15.2026.03.24.15.05.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2026 15:05:25 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Rob Clark , Victoria Brekenfeld , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 2/2] drm/msm: Fix VM_BIND UNMAP locking Date: Tue, 24 Mar 2026 15:05:18 -0700 Message-ID: <20260324220519.1221471-2-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260324220519.1221471-1-robin.clark@oss.qualcomm.com> References: <20260324220519.1221471-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=Jvr8bc4C c=1 sm=1 tr=0 ts=69c30aad cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=xqWC_Br6kY4A:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=e5mUnYsNAAAA:8 a=E-CVgwXbAAAA:8 a=EUspDBNiAAAA:8 a=wHnczO1oL0llXtWWSCoA:9 a=IoOABgeZipijB_acs4fv:22 a=Vxmtnl_E_bksehYqCbjh:22 a=7UGCclw-5oBoqXlMmAWZ:22 X-Proofpoint-ORIG-GUID: tQQSNfznNkWegSavbXBK9XPaTFSozcA2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI0MDE3MCBTYWx0ZWRfXx1Buo2dCwjAX U2dApZNvI50WWTy6ne4uLKKiJyEPOZUx8lFJGYGpjmQXrCTHuX8viZS5aytbuabhO5uDWMc2OKp AVII/Dslmlige+iptZYl4SK3Y0o6bNJOsxwmehzZVHq/22FbhsCf0W9rjAjaLeon1J7qNqp12WR Uogvtv1q3WSE4GZgjIqWdTk0CSXZRsV/MKuHY//Vz8FFmbPVdwVyfP+cxxgRQf/4F/k9ZNnXBIL 3/U8C2A+1j0teUZSgRf3xOsxfkeWe1s11+dXUk5xr1UZ1lwekGmbdiYdM7+68WSPcf87scTed/t VScyCG1UBrR46UKvBER6fpHQ/LXtjE0y13eyebSQNqJJrDVhAQVvxDZK4pAUWRAKaw3IwshRDVI +Rsqm80eAf/h1G2A2DAW1Efj3W18ODuHQb6+u8iiFacFXUlsv0NIKu0OJhjkkPObXSCDzUGNZdI +Z9+tIClaD9nYN1K/ug== X-Proofpoint-GUID: tQQSNfznNkWegSavbXBK9XPaTFSozcA2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-24_03,2026-03-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 impostorscore=0 suspectscore=0 phishscore=0 priorityscore=1501 spamscore=0 clxscore=1015 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603240170 Wrong argument meant that the objs involved in UNMAP ops were not always getting locked. Since _NO_SHARE objs share a common resv with the VM (which is always locked) this would only show up with non-_NO_SHARE BOs. Reported-by: Victoria Brekenfeld Fixes: 2e6a8a1fe2b2 ("drm/msm: Add VM_BIND ioctl") Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/94 Signed-off-by: Rob Clark --- v2: Add tags drivers/gpu/drm/msm/msm_gem_vma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_gem_vma.c b/drivers/gpu/drm/msm/msm_gem_vma.c index 43d61e0919bd..953a2403f598 100644 --- a/drivers/gpu/drm/msm/msm_gem_vma.c +++ b/drivers/gpu/drm/msm/msm_gem_vma.c @@ -1251,7 +1251,7 @@ vm_bind_job_lock_objects(struct msm_vm_bind_job *job, struct drm_exec *exec) case MSM_VM_BIND_OP_UNMAP: ret = drm_gpuvm_sm_unmap_exec_lock(job->vm, exec, op->iova, - op->obj_offset); + op->range); break; case MSM_VM_BIND_OP_MAP: case MSM_VM_BIND_OP_MAP_NULL: { -- 2.53.0