mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roman Storozhenko <romeusmeister@gmail.com>
To: "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@kernel.org>,
	 Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	 Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org
Cc: linux-kernel@vger.kernel.org,
	 Roman Storozhenko <romeusmeister@gmail.com>
Subject: [PATCH] x86/msr: Remove misleading "unrecognized" wording in write warning
Date: Wed, 25 Mar 2026 18:48:52 +0100	[thread overview]
Message-ID: <20260325-dev_roman_msr_msg-v1-1-cd51e2579018@gmail.com> (raw)

The term "unrecognized" in the warning message

  "Write to unrecognized MSR..."

  creates the impression that the MSR access is invalid or
  prohibited, which is not necessarily the case.

  Remove this wording to avoid misleading users about the nature
  of the access.

Signed-off-by: Roman Storozhenko <romeusmeister@gmail.com>
---
Additional context:

A utility that uses direct MSR writes triggered this warning during
post-silicon validation. The message was interpreted as evidence of
incorrect or prohibited MSR access due to the use of the term
"unrecognized".

This led to confusion among validation teams, although the MSR accesses
were intentional and valid.

Clarify the message to avoid misleading users in similar scenarios.
---
 arch/x86/kernel/msr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/msr.c b/arch/x86/kernel/msr.c
index 4469c784eaa0..16f6cde7d471 100644
--- a/arch/x86/kernel/msr.c
+++ b/arch/x86/kernel/msr.c
@@ -98,7 +98,7 @@ static int filter_write(u32 reg)
 	if (!__ratelimit(&fw_rs))
 		return 0;
 
-	pr_warn("Write to unrecognized MSR 0x%x by %s (pid: %d), tainting CPU_OUT_OF_SPEC.\n",
+	pr_warn("Write to MSR 0x%x by %s (pid: %d), tainting CPU_OUT_OF_SPEC.\n",
 	        reg, current->comm, current->pid);
 	pr_warn("See https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/about for details.\n");
 

---
base-commit: 85964cdcad0fac9a0eb7b87a0f9d88cc074b854c
change-id: 20260325-dev_roman_msr_msg-fad98620cc22

Best regards,
-- 
Roman Storozhenko <romeusmeister@gmail.com>


             reply	other threads:[~2026-03-25 17:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-25 17:48 Roman Storozhenko [this message]
2026-03-30 14:16 ` Borislav Petkov
2026-04-01 19:18   ` Roman Storozhenko
2026-04-01 19:27     ` Borislav Petkov
2026-04-02 17:37       ` Roman Storozhenko
2026-04-02 18:07         ` Borislav Petkov
2026-04-02 20:49         ` Thomas Gleixner
2026-04-03  7:55           ` Roman Storozhenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260325-dev_roman_msr_msg-v1-1-cd51e2579018@gmail.com \
    --to=romeusmeister@gmail.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome