From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CF9D3EC2F6 for ; Wed, 25 Mar 2026 16:05:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774454705; cv=none; b=oUqjGFUVQIHSS4HPFf+l4QPySlkjRANqUJS2zV5xAi6PoGcStuu/w/n4mRk0aoaB7WhU7ZX5xlpzHFa6vJW0b7alYsTl7SFtVBETisdztNkSjjsQmiAbNdexU8F0RGGQwsgM0PSaeIKq+tyla4PfLu+uhBHHur2cDGfufpBpiEg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774454705; c=relaxed/simple; bh=xKyHHnfE0tC2xIkdwZIbRnzLQ1O2tfuWrdj8iWb9SOE=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=Q/w43FSjW53qWOYyAqZrPtNxad/TW9LtoHmik7W+rOAMHyRHyH9egIpTrJV03/7KXveSw4gwGDO9wpc79WNnwKOhnh1szJb3iff209jIU5QORZ1pZvg2a+nNjTyYzv9VAG3zuQwRAd4bLKV1FVkOl5tY00UikGGe/WNokbVwp9g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=VwHysNZh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="VwHysNZh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 896EEC2BCB0; Wed, 25 Mar 2026 16:05:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1774454705; bh=xKyHHnfE0tC2xIkdwZIbRnzLQ1O2tfuWrdj8iWb9SOE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VwHysNZhgi4E6w6jEX7YF05sr1annXgdYSmz9kXWfHqL6HeTMDki+JsI/P7mweVcs ragu+sWHVwyMqTTWm6cDSA0+yPF1AYbbxfM2oLWJX3YhuUxYFITtKfX0OM1xZxrZq3 glh1gvES5VvQVbbXOuOPVkKbKne887yBhlI2BUnk= Date: Wed, 25 Mar 2026 09:05:03 -0700 From: Andrew Morton To: "Lorenzo Stoakes (Oracle)" Cc: Nico Pache , linux-kernel@vger.kernel.org, linux-mm@kvack.org, aarcange@redhat.com, anshuman.khandual@arm.com, apopple@nvidia.com, baohua@kernel.org, baolin.wang@linux.alibaba.com, byungchul@sk.com, catalin.marinas@arm.com, cl@gentwo.org, corbet@lwn.net, dave.hansen@linux.intel.com, david@kernel.org, dev.jain@arm.com, gourry@gourry.net, hannes@cmpxchg.org, hughd@google.com, jackmanb@google.com, jack@suse.cz, jannh@google.com, jglisse@google.com, joshua.hahnjy@gmail.com, kas@kernel.org, lance.yang@linux.dev, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, mathieu.desnoyers@efficios.com, matthew.brost@intel.com, mhiramat@kernel.org, mhocko@suse.com, peterx@redhat.com, pfalcato@suse.de, rakie.kim@sk.com, raquini@redhat.com, rdunlap@infradead.org, richard.weiyang@gmail.com, rientjes@google.com, rostedt@goodmis.org, rppt@kernel.org, ryan.roberts@arm.com, shivankg@amd.com, sunnanyong@huawei.com, surenb@google.com, thomas.hellstrom@linux.intel.com, tiwai@suse.de, usamaarif642@gmail.com, vbabka@suse.cz, vishal.moola@gmail.com, wangkefeng.wang@huawei.com, will@kernel.org, willy@infradead.org, yang@os.amperecomputing.com, ying.huang@linux.alibaba.com, ziy@nvidia.com, zokeefe@google.com Subject: Re: [PATCH mm-unstable v4 2/5] mm: introduce is_pmd_order helper Message-Id: <20260325090503.50739871bd95a3e700e45a39@linux-foundation.org> In-Reply-To: <74104214-5759-451d-9279-37498918ec3e@lucifer.local> References: <20260325114022.444081-1-npache@redhat.com> <20260325114022.444081-3-npache@redhat.com> <20260325074516.46bfcf772d5eb4482d7df36d@linux-foundation.org> <74104214-5759-451d-9279-37498918ec3e@lucifer.local> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 25 Mar 2026 14:49:30 +0000 "Lorenzo Stoakes (Oracle)" wrote: > On Wed, Mar 25, 2026 at 07:45:16AM -0700, Andrew Morton wrote: > > On Wed, 25 Mar 2026 12:11:43 +0000 "Lorenzo Stoakes (Oracle)" wrote: > > > > > On Wed, Mar 25, 2026 at 05:40:19AM -0600, Nico Pache wrote: > > > > In order to add mTHP support to khugepaged, we will often be checking if a > > > > given order is (or is not) a PMD order. Some places in the kernel already > > > > use this check, so lets create a simple helper function to keep the code > > > > clean and readable. > > > > > > > > Acked-by: David Hildenbrand (Arm) > > > > Reviewed-by: Baolin Wang > > > > Reviewed-by: Dev Jain > > > > Reviewed-by: Wei Yang > > > > Reviewed-by: Lance Yang > > > > Reviewed-by: Barry Song > > > > Reviewed-by: Zi Yan > > > > Reviewed-by: Pedro Falcato > > > > Reviewed-by: Lorenzo Stoakes > > > > Suggested-by: Lorenzo Stoakes > > > > > > Nit, but could we please update both to: > > > > > > Lorenzo Stoakes (Oracle) > > > > hp2:/usr/src/25> grep lorenzo.stoakes@oracle.com patches/*.patch|wc -l > > 105 > > > > Please lmk if you'd prefer that I go through these and update the email > > address. > > That'd be useful thanks. > > It's not a huge big deal, but trying to gently nudge the transition forwards a > bit... Done.