From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5673A337BA4 for ; Wed, 25 Mar 2026 23:31:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774481499; cv=none; b=fRh25Chfh9pntAP40LUq5WDkrbl3uDMnezlIql8yXMG2dkWA8h6Yv1mkqVPdwdF3IUdFMTScwddLWX5p0dcBY/TGVmZX5e6LiC4k7x4Pav7G0zho2bZUEGFchRWA5KYgUNE9+cdb9AzLHCf1obyDvMceEyY4oXsMKKxzePyObZc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774481499; c=relaxed/simple; bh=tg7/zj6th0pK8WmaY0pg8M5IjVgzMhsvEF/GykZ16xU=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=T8beGAifya3cIYICV0oLP4P0uQCOP40WnIPlkwh9AkmLW5Az146p9gavUUzIfKQ4vUzVLI8SJi7nhvnD42CrhkOdAidEzSRaVKV8r9IO/w7O54EZJkey9V+5iNlBP8aUjWq1PsWHsvdjnVR3E131226v4mMxDDHqB4kqCUNp/KM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=cHXeMQGc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="cHXeMQGc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85786C4CEF7; Wed, 25 Mar 2026 23:31:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1774481498; bh=tg7/zj6th0pK8WmaY0pg8M5IjVgzMhsvEF/GykZ16xU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cHXeMQGcjKuUsWs3Nr2RtwyKJxzsELh7JSi7T+V8gGhAYWVRIArUJi0UK3hD7jkxT PiiWmB+TCgJj2teSSYgyuBJQmvEMV2kWSqG/T0/uIZbGvuxsxpU50sOYGhbd/7Bz2k /BjiB5apGuukMkzmvAqYNjJ1lqdgvSllDD+r+D9w= Date: Wed, 25 Mar 2026 16:31:38 -0700 From: Andrew Morton To: Yury Norov Cc: Thomas Gleixner , "Peter Zijlstra (Intel)" , Mathieu Desnoyers , Alice Ryhl , Viktor Malik , Randy Dunlap , David Laight , linux-kernel@vger.kernel.org, "Christophe Leroy (CS GROUP)" , Yury Norov Subject: Re: [PATCH 0/2] uaccess: unify inline vs outline copy_{from,to}_user() selection Message-Id: <20260325163138.d3e2c41dd3ed8a96c4801507@linux-foundation.org> In-Reply-To: <20260325163313.749336-1-ynorov@nvidia.com> References: <20260325163313.749336-1-ynorov@nvidia.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 25 Mar 2026 12:33:10 -0400 Yury Norov wrote: > Christophe has pointed in [1] that one my patch incorrectly defines > rust_helper__copy_to_user() wrapper based on INLINE_COPY_FROM_USER. > > Having separate controls for 'from' and 'to' versions is pretty useless, > and has proven to be error prone. So, instead of fixing the rust portion, > simply switch the kernel to a single knob. > > [1] https://lore.kernel.org/all/746c9c50-20c4-4dc9-a539-bf1310ff9414@kernel.org/ Some changelog whining: As this series is aimed at mainline inclusion, I don't see much value in changelogging which refers to previous development versions of the patchset. That's useful material to include below the ^---$ separator, but it isn't of interest to our target audience: people who are reading this patchset three years hence. So can we please have a clean description of what this patchset does and why it does it? Also, [1/2] says Fixes: 1f9a8286bc0c ("uaccess: always export _copy_[from|to]_user with CONFIG_RUST") but I'm not actually seeing a description of what was wrong with 1f9a8286bc0c. Can we please have a description of the motivation in here somewhere?