From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 745CC1F0E34
	for <linux-kernel@vger.kernel.org>; Thu, 26 Mar 2026 03:50:59 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1774497060; cv=none; b=ZKVG3ZXAIbMeoYONo9oFiriT1RM2Dr/CYsF7Fo+bXi+9nCMwEuaPH/a6GAjdaXZfgypO5z4bbttG3BHQSbYBpDG5j8w1gnsgWJIqI/zArufkzgqCnpcFXTa2kADVn7BG+RdGIiEkPK5Y5yEP5Udco5Dy2LeiIYhGLFlETd+aSXI=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1774497060; c=relaxed/simple;
	bh=VcJmc6dBBrl7uzhA9BeC6IHMyW6+I+16gr7VoOHmImQ=;
	h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References:
	 Mime-Version:Content-Type; b=GhXx8oj2NpZGaY72FAwNAdhLvRCZmTrrm8aCobkqnh7yGwzAXSnsUxyRh/KcOgi702jGdETvp81NG72bpoTspVhVa04A+777hZcD6iCozkEgKC53P8b6aZg+6TSGvQ/k7R/4OkUN0HnxdbiMTQPpoLcvHdYFhMXchVImFuDBmR8=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=Ic3doNY0; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="Ic3doNY0"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id ABB3FC19424;
	Thu, 26 Mar 2026 03:50:59 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org;
	s=korg; t=1774497059;
	bh=VcJmc6dBBrl7uzhA9BeC6IHMyW6+I+16gr7VoOHmImQ=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=Ic3doNY0tBoB/PIrqS5O2V1R3GziEK9gRK6QPawy1ugEpHPmFJCsD7z9DxeapUXAP
	 8zcs/i+WD/zQQ31ipYX5wfoH3l545Uwam9aNsgqGemUQhtFMdumDeF81lJ1sUd2aKK
	 8QRTca/npQ+YhX9ea+wB6qLW3GV0/dInfnAmrXks=
Date: Wed, 25 Mar 2026 20:50:59 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Leo Timmins <leotimmins1974@gmail.com>
Cc: Pasha Tatashin <pasha.tatashin@soleen.com>, Mike Rapoport
 <rppt@kernel.org>, Pratyush Yadav <pratyush@kernel.org>,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] liveupdate: propagate file deserialization
 failures
Message-Id: <20260325205059.62072d848043542f922aa564@linux-foundation.org>
In-Reply-To: <20260325044608.8407-2-leotimmins1974@gmail.com>
References: <20260325044608.8407-1-leotimmins1974@gmail.com>
	<20260325044608.8407-2-leotimmins1974@gmail.com>
X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu)
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 25 Mar 2026 12:46:07 +0800 Leo Timmins <leotimmins1974@gmail.com> wrote:

> luo_session_deserialize() ignored the return value from
> luo_file_deserialize(). As a result, a session could be left partially
> restored even though the /dev/liveupdate open path treats deserialization
> failures as fatal.
> 
> Propagate the error so a failed file deserialization aborts session
> deserialization instead of silently continuing.
> 
> Fixes: 16cec0d26521 ("liveupdate: luo_session: add ioctls for file preservation")

Present in 6.19.  Is this serious enough for a -stable backport?

Leo, I'll add this to mm.git's mm-hotfixes branch because "fix". 
Please do send along a v2 which addresses Pasha's comments.