From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 390F5311942 for ; Thu, 26 Mar 2026 08:16:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774512999; cv=none; b=KeJABMvKPLkGf+41qN69MQSqlNpjGIJq6bYPsn7peOF03drUWSXgMCuVK5qQn7r1pK1WasVdTV9t77QwX3zua+Pae4lkb9NM/NlBmung16S8p7QvxovKYbI1WIMXnbkCwo1SW1wyUT4oEDCtkpfEycg5br6bqOuW1k/AOjvQgUQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774512999; c=relaxed/simple; bh=3O5qDrcM9E2HCWCJh7fs30ts4Wm6JW1vROqC5tPBSjg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nxOihgmJIteYCHnEUJuaNKGNxdTwhJ+4J4MouZtgrvizMOQ2k6zh4uvf02TxMpdJhejFqY8WG78MLmbJP2lS22oKCTB3Drxj5OTz86REb/4VO881fGnzlYmaAQl75epOi/1rhov/i3SIsKV2DWK15PrYqd1jme7PKoX9whF01cE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YE5nC2Bz; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YE5nC2Bz" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-48557c8ad47so5084665e9.0 for ; Thu, 26 Mar 2026 01:16:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774512997; x=1775117797; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=toCvMQKoaOmXn8yp4qHoKgNI8N1PvbaxGtL98+Y+9Go=; b=YE5nC2Bz949a88nxWFixnS5822LhrwdBiG41DlCptqc242foyorHze0iLDk6VDKaeY 0eH1eSKDuLbsJXH9ojosrOKgkLpF/m6M4RYtnBzvlvoB973T5P0N4avaNLib72+Hd/Gn Y1Ft/GoNej9ZTjhAuvANH1TeipkBfPepnc5tzQ5mrdd2hsY1HhlBdGMoQkjzAyER8r+C Sjel7Q1MxxwAKSFc8ySL8f+NwVHfJt+dVvmUb38/SVRKVLUZZUBaYT4+Yt5id7iiK8VG O3g+dKGzTP+l4WW3mtUFC+q9+jEv8UtWUO4ynFQ5gZqvpZMOAtq1jq5nQM63DtyZWada 7W8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774512997; x=1775117797; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=toCvMQKoaOmXn8yp4qHoKgNI8N1PvbaxGtL98+Y+9Go=; b=gD+1GCMq/9dbxoTuXH9U96zPzWPQ/nxG7hWKE2sW7ufD4QRUzyiaVG11yGy1Y2BF8P Cc8pnrpN0T8kPCM6dFJBbO2R2x9sRwERrAgBbbe7tJt5d/ho6+wrAsb+a9KyiEfPhOOX NL6mDPoNCr9TY4gG78yVWvhduSuj8SqymufX/cVuxt1O81rq8c91XCsuzLbH4grMD6pM qQiZlr+1spfPT/trP44kR3tqObfOvgpwXzBo5zbBNKGbY942t98FixxjhnJ84kqw6QPz oppA5Iu3tqZAdISbKhrNN8q5UDA1BivXopZ3HUOEFMn7mFLFe4AsksIWbUOyiip9+dCz jP1g== X-Forwarded-Encrypted: i=1; AJvYcCVavFbfs3KW9WC6McUA3oV2aCAjyGI0EWGvK3D9V5EeYXMb+Rs4V4PzqxiHHjzXBiwEEu7wIhzCjhyRxxk=@vger.kernel.org X-Gm-Message-State: AOJu0Ywn1g/kYZvC18D3uB/ROeFgCWMQg9GANZl6ctbRCUAVIQaBmsn+ liu+moHG/1bmqZP5BfEpHCqswDzFrcpZD8SliI2YHmf8vvvIuic0Hx7vwkv+3dzP X-Gm-Gg: ATEYQzxnl7Nnfp8p19M0A7Ubfebtxh/K05h4y3DFWCRfDmdjc2EiV3oFdkR8GmlK6Jx pqpSKCbH5X62jRLHdZDa6q4q0peX5l8m61kswhzIouPYUd//Fc3Fi3AiX0ASGS9PtJ1J68tDzvf 7mj/RShrTxuJGSWLyejNZuTnKHNN+WLuQJAhR5pEZbrNdicvGdUhVByOYScHLI2ZlJgguNZ/2El RrjM0FkUH/5H6SoohKRCuonDJ5ZlcgGiosdoEeKgFI8DAl64IvJjo7trlGh2mWooJU7/F6Ap2ao LMTlaU4pNCRflBViRJDp1iU2eUhBrXYB/0J8+WCz1Io3+X1ZOgi+it8JUT1ui42VDeIXVVnnqyu HDUHt+6gedn0tUCbExLFAxF8yohV2YMaJC7vvGcneH7h/0fZhOrwfVqD8HsLv0oOFeJ3uhBr/SB fXs6wcKqhaZ4TGqi4j27ydZsXOuenyFbm+yA== X-Received: by 2002:a05:600c:45d4:b0:487:1114:d42f with SMTP id 5b1f17b1804b1-48715fd4aa6mr90496705e9.1.1774512996325; Thu, 26 Mar 2026 01:16:36 -0700 (PDT) Received: from potato ([31.176.167.148]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48722c6b495sm32886045e9.2.2026.03.26.01.16.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 01:16:35 -0700 (PDT) From: Omer El Idrissi To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Omer El Idrissi , Omer El Idrissi Subject: [PATCH v3 0/4] clean up error handling Date: Thu, 26 Mar 2026 09:16:22 +0100 Message-ID: <20260326081627.5841-1-omer.e.idrissi@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260324220453.47406-1-omer.e.idrissi@gmail.com> References: <20260324220453.47406-1-omer.e.idrissi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series lets sdio_init() propagate standard kernel error codes instead of returning _SUCCESS/_FAIL. There are two callers for this function. rtw_resume_process_normal() already returns negative values but the caller doesn't check for errors so changing this doesn't affect anything. sdio_dvobj_init() returns NULL on error so leave that as-is. Signed-off-by: Omer El Idrissi --- v3: - Add one commit that lets sdio_dvobj_init() use more readable error handling - Add v3 and v2 tags v2: - Add one commit that lets rtw_resume_process_normal cleanly check errors and return errno instead of using vendor-defined slop v1: - Use direct returns in sdio_dvobj_init() - Cleanup return in sdio_init() Omer El Idrissi (4): staging: rtl8723bs: use direct returns in sdio_dvobj_init() staging: rtl8723bs: cleanup return in sdio_init() staging: rtl8723bs: clean up callees for sdio_init function staging: rtl8723bs: Choose slightly more readable error check drivers/staging/rtl8723bs/os_dep/os_intfs.c | 8 +++---- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 25 ++++++++------------ 2 files changed, 14 insertions(+), 19 deletions(-) -- 2.51.0