From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55C141D45E8 for ; Thu, 26 Mar 2026 09:05:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774515919; cv=none; b=dv1Bllrnb2MzYUfSWvlhIY96apzBM43jIAwde4zFigidT+GQ9kyv4JtQao9NlrcMMd2XJXHhHLSEQR8N1+hTTjZgHGcfv/6iV7LuLhxdMfz0mavcogfpeTWwwqpiK+RLlhi9Uxh8UUXGvOqybhTuboALamaNkTFFFXMTQKjE7yE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774515919; c=relaxed/simple; bh=T4s5H8sEgyY4S7mB/3lfzx1EnybYJttot45IV1QRblY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YSUnK47rpGDIT3S8NkPtMlD8Ko0JbbdswZuwtrnXwtRWhw/6qtE7FEB29fOUpafE8wApOn0XX5p8ah6U4zCUNImGkrjn4BfvGwxrkO+LOYbNJjfiAjp9xtfGiXhwrQct9flHt8Amx4Sjw11miw8zNoEBeplxurJN/qTsQDRDhso= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=2hjkeSr6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="2hjkeSr6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2734C116C6; Thu, 26 Mar 2026 09:05:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1774515919; bh=T4s5H8sEgyY4S7mB/3lfzx1EnybYJttot45IV1QRblY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2hjkeSr6vIhpCZmMT0FVCyTLLDuRSBHaDhVMbcS+ApGvT1eBrJHcQz7Ddzyf8rCce yof/dLMAXYNPSD0rjwM4YUBfeJbtCU+2ikmwZOHn4kte5SW5Vaxhr8fPv5n6Q2MEEA QszaeWCILoTgRZ+g3kOXPQhlqTqq2J5VvZEoJEOs= Date: Thu, 26 Mar 2026 10:04:55 +0100 From: Greg Kroah-Hartman To: Haoyu Lu Cc: Michael Hennerich , Arnd Bergmann , linux-kernel@vger.kernel.org Subject: Re: [PATCH] misc: ad525x_dpot: fix macro parentheses and permissions Message-ID: <2026032613-chlorine-pauper-4759@gregkh> References: <20260326085514.14505-1-hechushiguitu666@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260326085514.14505-1-hechushiguitu666@gmail.com> On Thu, Mar 26, 2026 at 04:55:10PM +0800, Haoyu Lu wrote: > From: "haoyu.lu" > > Fix checkpatch.pl warnings: > - Macros with complex values should be enclosed in parentheses > - Symbolic permissions 'S_IWUSR | S_IRUGO' are not preferred > > Signed-off-by: haoyu.lu Please do not do checkpatch cleanups in other areas of the kernel when you do not have the experience of doing them first in drivers/staging/ as due to a number of problems in this patch, it obviously can not be applied :( thanks, greg k-h