From: Andrew Morton <akpm@linux-foundation.org>
To: "Christian A. Ehrhardt" <lk@c--e.de>
Cc: David Howells <dhowells@redhat.com>,
linux-kernel@vger.kernel.org, Kees Cook <kees@kernel.org>,
Petr Mladek <pmladek@suse.com>, David Gow <davidgow@google.com>
Subject: Re: [PATCH v3 0/5] Fix bugs in extract_iter_to_sg()
Date: Thu, 26 Mar 2026 15:39:49 -0700 [thread overview]
Message-ID: <20260326153949.ecbd4ba14255c301a8096b3f@linux-foundation.org> (raw)
In-Reply-To: <20260326214905.818170-1-lk@c--e.de>
On Thu, 26 Mar 2026 22:49:00 +0100 "Christian A. Ehrhardt" <lk@c--e.de> wrote:
> Fix bugs in the kvec and user variants of extract_iter_to_sg.
> This series is growing due to useful remarks made by sashiko.dev.
>
> The main bugs are:
> - The length for an sglist entry when extracting from
> a kvec can exceed the number of bytes in the page. This
> is obviously not intended.
> - When extracting a user buffer the sglist is temporarily
> used as a scratch buffer for extracted page pointers.
> If the sglist already contains some elements this scratch
> buffer could overlap with existing entries in the sglist.
>
> The series adds test cases to the kunit_iov_iter test that
> demonstrate all of these bugs. Additionally, there is a
> memory leak fix for the test itself.
>
> The bugs were orignally introduced into kernel v6.3 where the
> function lived in fs/netfs/iterator.c. It was later moved
> to lib/scatterlist.c in v6.5. Thus the actual fix is only
> marked for backports to v6.5+.
Great. I'll add this to mm.git's mm-unstable branch, targetting an
upstream merge into 7.1-rc1.
As far as I understand, this means that the cc:stable patches will be
presented to the -stable maintainers some time after that upstreaming.
I don't believe that more urgency is needed.
DavidH, please review the sg changes?
DavidG, please check the kunit changes?
Thanks all.
prev parent reply other threads:[~2026-03-26 22:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 21:49 Christian A. Ehrhardt
2026-03-26 21:49 ` [PATCH v3 1/5] lib/scatterlist: Fix length calculations in extract_kvec_to_sg Christian A. Ehrhardt
2026-03-26 21:49 ` [PATCH v3 2/5] lib/scatterlist: Fix temp buffer in extract_user_to_sg() Christian A. Ehrhardt
2026-03-26 21:49 ` [PATCH v3 3/5] lib: kunit_iov_iter: Fix memory leaks Christian A. Ehrhardt
2026-03-26 21:49 ` [PATCH v3 4/5] lib: kunit_iov_iter: Improve error detection Christian A. Ehrhardt
2026-03-26 21:49 ` [PATCH v3 5/5] lib: kunit_iov_iter: Add tests for extract_iter_to_sg Christian A. Ehrhardt
2026-04-21 5:45 ` David Gow
2026-04-21 6:30 ` Christian A. Ehrhardt
2026-04-21 6:49 ` David Gow
2026-03-26 22:39 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260326153949.ecbd4ba14255c301a8096b3f@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=davidgow@google.com \
--cc=dhowells@redhat.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lk@c--e.de \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®