mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: aravindanilraj0702@gmail.com
To: gregkh@linuxfoundation.org, arnd@arndb.de
Cc: linux-kernel@vger.kernel.org,
	Aravind Anilraj <aravindanilraj0702@gmail.com>
Subject: [PATCH] misc: altera-stapl: Replace sprintf with hex_asc_lo for hex conversion
Date: Thu, 26 Mar 2026 13:32:57 -0400	[thread overview]
Message-ID: <20260326173257.25375-1-aravindanilraj0702@gmail.com> (raw)

From: Aravind Anilraj <aravindanilraj0702@gmail.com>

Replace sprintf() calls used to format single hex digits with direct
assignment using hex_asc_lo().This avoids unnecessary overhead
from using sprintf for single character output.

No functional changes.

Signed-off-by: Aravind Anilraj <aravindanilraj0702@gmail.com>
---
 drivers/misc/altera-stapl/altera.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/misc/altera-stapl/altera.c b/drivers/misc/altera-stapl/altera.c
index 4fa6c90624e5..4352bfb80043 100644
--- a/drivers/misc/altera-stapl/altera.c
+++ b/drivers/misc/altera-stapl/altera.c
@@ -8,7 +8,7 @@
  * Copyright (C) 2010,2011 NetUP Inc.
  * Copyright (C) 2010,2011 Igor M. Liplianin <liplianin@netup.ru>
  */
-
+#include <linux/hex.h>
 #include <linux/unaligned.h>
 #include <linux/ctype.h>
 #include <linux/string.h>
@@ -167,13 +167,13 @@ static void altera_export_bool_array(char *key, u8 *data, s32 count)
 				if (data[i >> 3] & (1 << (i & 7)))
 					value |= (1 << (i & 3));
 				if ((i & 3) == 3) {
-					sprintf(&string[j], "%1x", value);
+					string[j] = hex_asc_lo(value);
 					value = 0;
 					--j;
 				}
 			}
 			if ((k & 3) > 0)
-				sprintf(&string[j], "%1x", value);
+				string[j] = hex_asc_lo(value);
 
 			dprintk("%s\n", string);
 		}
@@ -188,13 +188,13 @@ static void altera_export_bool_array(char *key, u8 *data, s32 count)
 			if (data[i >> 3] & (1 << (i & 7)))
 				value |= (1 << (i & 3));
 			if ((i & 3) == 3) {
-				sprintf(&string[j], "%1x", value);
+				string[j] = hex_asc_lo(value);
 				value = 0;
 				--j;
 			}
 		}
 		if ((i & 3) > 0)
-			sprintf(&string[j], "%1x", value);
+			string[j] = hex_asc_lo(value);
 
 		dprintk("Export: key = \"%s\", %d bits, value = HEX %s\n",
 			key, count, string);
-- 
2.47.3


             reply	other threads:[~2026-03-26 17:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-26 17:32 aravindanilraj0702 [this message]
2026-04-02 14:23 ` Greg KH
2026-04-02 15:42   ` Aravind

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260326173257.25375-1-aravindanilraj0702@gmail.com \
    --to=aravindanilraj0702@gmail.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®