From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 265B93314BF for ; Fri, 27 Mar 2026 02:23:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774578233; cv=none; b=VuwSr+B7uS8X0fSPcWwoPuQ7FL/LnQeSNoO6C0HwndmhKEUCQTJUFWEgay0k4CMDaCxkPkITfsUl1Rk6rvxg58Z+lmqQEXT8MFMmDJdGEni22Yo7rUd0h2gARXF5eVleW8ZSi+YjUWoFHovtegxjZktvZfUjJWDKPPahGRrKHPE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774578233; c=relaxed/simple; bh=Kmj5bybZqcuY1bMfQ2d7AFuAZFz/iSD+579cXDOYoMs=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=Klh+K+G2jIPbbHobTpIu7XVdBJKqfENZDF55tLvCutBHpGsanQ7/hoBc+D/jSjG4E4fUe2bQalM8UQ/iM3zVXY55jfRCUKyckJQehpJc7MSP0zjLl6PGXpO+M9ViqwPB4MekazATdlr+7CeAnjrq3vEbOD3PE85tomvoktIdXxU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=mOzcA68l; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="mOzcA68l" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 604D0C116C6; Fri, 27 Mar 2026 02:23:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1774578232; bh=Kmj5bybZqcuY1bMfQ2d7AFuAZFz/iSD+579cXDOYoMs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mOzcA68llz2krPlRZUaF7lAOqkKen7l6iVH5GEzfvQYYFX9JD9Tpzf6mE/RkY7Zgw SocGwv5ATc39Ww0O/so9+wDa3dODLQOXJT3aHMlG/OhpKvITY1Vl6L/jXIg3kKtphR 3qJWg9Zf+npVUmXirsebhenlSZrQObkhsqgc4epg= Date: Thu, 26 Mar 2026 19:23:51 -0700 From: Andrew Morton To: "Kanchana P. Sridhar" Cc: hannes@cmpxchg.org, yosry@kernel.org, nphamcs@gmail.com, chengming.zhou@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, herbert@gondor.apana.org.au, senozhatsky@chromium.org Subject: Re: [PATCH v2 2/2] mm: zswap: Tie per-CPU acomp_ctx lifetime to the pool. Message-Id: <20260326192351.7fc8c27d87c60ab5f7de5395@linux-foundation.org> In-Reply-To: <20260317014802.27591-3-kanchanapsridhar2026@gmail.com> References: <20260317014802.27591-1-kanchanapsridhar2026@gmail.com> <20260317014802.27591-3-kanchanapsridhar2026@gmail.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 16 Mar 2026 18:48:02 -0700 "Kanchana P. Sridhar" wrote: > Currently, per-CPU acomp_ctx are allocated on pool creation and/or CPU > hotplug, and destroyed on pool destruction or CPU hotunplug. This > complicates the lifetime management to save memory while a CPU is > offlined, which is not very common. > > Simplify lifetime management by allocating per-CPU acomp_ctx once on > pool creation (or CPU hotplug for CPUs onlined later), and keeping them > allocated until the pool is destroyed. > > ... > This is a tricky-looking patch and I haven't yet recorded any reviews, so could someone please dig in? Sashiko wasn't apply to apply this patch for either the v1 or v2 series, so no help there. Thanks.