From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6215C1A08AF for ; Fri, 27 Mar 2026 03:13:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774581231; cv=none; b=gqUU/ZnFG6bCjpl85AUEYOQvQlePNCy+/55ql7/veIHLs0ETqfRa5z1ys3c/AD3FrkvWeEwz2RqhfBAIUJA9wZLIz47DoIULV5Mow0BbHXoJFuN4IcuZahBn26wOgO6UK3JnNaxqb5f0XlnBzvPzw6HN8Ui10L3bSzLkXrfoRyo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774581231; c=relaxed/simple; bh=/nbxgnztPKPE/Y/AAz6k5DR9LwMDKIKYxOf7gLsZnmM=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=gLAVPaYaZOygUQRmuDWwHCMJVNtidhtW2segnLt2Q4i8nlGtGL1WFMyKx/5ake+jyFGLDj4+tqGr9QppkoaYXb0yhewNQ2Uluk2xOGPNbalEiQ0vojawEEVh8lsc4ly6k1A4D1BNe8aq/epM7sTFzvK7C2TSpuMxuWs0vPxY2Fg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=hve84N/X; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="hve84N/X" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4B09C116C6; Fri, 27 Mar 2026 03:13:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1774581230; bh=/nbxgnztPKPE/Y/AAz6k5DR9LwMDKIKYxOf7gLsZnmM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hve84N/XvEGzKL7J7swNcjpi8EC4JPnVRpzI5XIFmdJ0LXiUZT7tfsR97V1HYVXZl Z8pV+ytUh+9GbWpENY9HxbE/0KxCYlCBqIgSd+h6FILFn9UE4fiaHV3Gaq9aRG3L4D JBb6HtrUBpkJcJXYH4j1ebNZgBdKoBH81ERSWKSE= Date: Thu, 26 Mar 2026 20:13:49 -0700 From: Andrew Morton To: Qi Zheng Cc: "Lorenzo Stoakes (Oracle)" , hannes@cmpxchg.org, hughd@google.com, mhocko@suse.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, david@kernel.org, ziy@nvidia.com, harry.yoo@oracle.com, yosry.ahmed@linux.dev, imran.f.khan@oracle.com, kamalesh.babulal@oracle.com, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, chenridong@huaweicloud.com, mkoutny@suse.com, hamzamahfooz@linux.microsoft.com, apais@linux.microsoft.com, lance.yang@linux.dev, bhe@redhat.com, usamaarif642@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Harry Yoo (Oracle)" , Qi Zheng Subject: Re: [PATCH v2 4/4] mm: memcontrol: fix unexpected massive positive number in memcg_state_val_in_pages() Message-Id: <20260326201349.f63af08fb120b2ecb1623211@linux-foundation.org> In-Reply-To: <0cf08b3f-6fed-41c4-8728-c925e8a55f29@linux.dev> References: <54c2b09c-84f8-4118-96a6-acc13ca2f245@lucifer.local> <9ee51ac2-c87c-44f6-b983-44ac9007cb35@lucifer.local> <20260326170622.8fa7ca34d1425c241525bd41@linux-foundation.org> <0cf08b3f-6fed-41c4-8728-c925e8a55f29@linux.dev> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 27 Mar 2026 10:42:52 +0800 Qi Zheng wrote: > > a) Redo this "fix unexpected ..." series on top of "Eliminate ..." > > and tolerate the bisection hole (easiest). > > From my personal perspective, I prefer this approach. The issues fixed > by this patchset aren't too critical; it's just that the counter might > overflow (and only with CONFIG_MEMCG_V1). If it can be included in > v7.1-rcX along with "Eliminate ...", I think it's acceptable. Cool, thanks. I've dropped "fix unexpected type conversions and potential overflows v2" from mm.git to give you a clean mm-unstable to work against. I expect to be pushing this a couple of hours from now.