From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Rosen Penev <rosenp@gmail.com>
Cc: linux-kernel@vger.kernel.org, Kees Cook <kees@kernel.org>,
Thorsten Scherer <t.scherer@eckelmann.de>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
"open list:KERNEL HARDENING not covered by other
areas:Keyword:b__counted_by_le|_be?b"
<linux-hardening@vger.kernel.org>
Subject: Re: [PATCH] siox: use kzalloc_flex
Date: Fri, 27 Mar 2026 07:49:42 +0100 [thread overview]
Message-ID: <20260327-cunning-eccentric-ant-d791c8-mkl@pengutronix.de> (raw)
In-Reply-To: <CAKxU2N_0EJfv4EHyLbBJsn27Hui9U3SvaZ_bnbcnmAx8=mZAvw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 787 bytes --]
On 26.03.2026 12:17:34, Rosen Penev wrote:
> > NACK - What's you motivation to do this?
> > The "size" extra space is not used for master->buf, but for
> > dev->driver_data. master->buf is allocated in siox_device_add().
> I assume this means a new struct member should be added and
^^^^^^
> kzalloc_flex modified to work on that.
I suggest you look at the code, try to understand what it currently
does, then re-think what your proposed changed do, what problem your
changes fix.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2026-03-27 6:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 4:47 Rosen Penev
2026-03-26 8:22 ` Marc Kleine-Budde
2026-03-26 19:17 ` Rosen Penev
2026-03-27 6:49 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260327-cunning-eccentric-ant-d791c8-mkl@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=gustavoars@kernel.org \
--cc=kees@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rosenp@gmail.com \
--cc=t.scherer@eckelmann.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®