From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C55832B99E for ; Fri, 27 Mar 2026 15:17:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774624640; cv=none; b=tqkiH8M/Vt/lgB099U6hOszsJx/30gvbYSoeeTPc1AIHuMl1J2KqfRRLYT5kTXEsDTSPNXh/Ff5mvxUdKqtVE6gF1RAdKudoZts7wr4X+NjAqryzb7D1l3J8VJwHVMNBZ+07OEjeBbdeu+HEmrNuSl7acbfg9A1lJm/hvc5Ugko= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774624640; c=relaxed/simple; bh=xXXg9z+7vBebqYCq6rGc4J0cBtxwbKXJmRRqamjI7U0=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=CJhdQXuvGlrMI2No7d1nR1i5cyLxKq/t/sEeLSBdbjrNgUJlzffxdRUw//sSTIEFOoaNWSpfBSuy9PU7Yae2Apljan+LkTFqqonkPJeoR1suCjoeIEt7/M2LYBgNWt629UNBpiftzAXrM1ubh1G25/Dab571cK91lYu8ZNAypfU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=FECUp4gU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="FECUp4gU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E8A6C19423; Fri, 27 Mar 2026 15:17:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1774624639; bh=xXXg9z+7vBebqYCq6rGc4J0cBtxwbKXJmRRqamjI7U0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FECUp4gU6wgALHsM0dOxcdpLNpBOlZA3Lczy+83slQYY6fYA/6uvBOL+ACKwakyY+ OM7ThO97G2zhnJvjFaBy+d2Rf5wajJg0GRyCBNchaFJbnoXaFKucTqNyN2zDCQHvFR W/SmOBSxmjRrK1Uhem8xikac8L5yqNFFQQpdwEBg= Date: Fri, 27 Mar 2026 08:17:19 -0700 From: Andrew Morton To: Takaya Saeki Cc: Inseob Kim , linux-kernel@vger.kernel.org, changbin.du@gmail.com, jbaron@akamai.com, joe@perches.com, Josh Law Subject: Re: [PATCH v2] lib: parser: Fix match_wildcard to correctly handle trailing stars Message-Id: <20260327081719.3185b24c9467ddbb0ed9397f@linux-foundation.org> In-Reply-To: References: <20260326020630.4139520-1-inseob@google.com> <20260325192534.151e86e439e7e4080a630d4c@linux-foundation.org> <20260325214512.98de0f2fb847d56de9282b23@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 27 Mar 2026 19:11:21 +0900 Takaya Saeki wrote: > > Sorry for the confusion; let me correct myself. It's not that wildcard > > is preferable to glob, but genfs_seclabel_wildcard is already merged > > and in use so moving from wildcard to glob would introduce breaking > > changes. Let me invite Takaya who possibly has more rationale for the > > wildcard. > > Yes, there wasn't strong motivation to avoid glob; wildcards were sufficient, > so we just didn't consider adopting glob. > Since glob is a superset of wildcards and doesn't treat slashes as > special characters, > it would certainly be more convenient to use. We might want to improve SELinux > later including the network interface matching, which also uses > wildcard matching. OK, thanks. It isn't a big deal at all - I'm just wondering if we have an opportunity to remove some code by migrating all wildcard users over to glob.