From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91BE7344D91 for ; Fri, 27 Mar 2026 19:53:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774641196; cv=none; b=hG5sJL8r2kHw7xBiKsh2dIayNdr/NcwZXiw5G0cuRlblr7WCrAARmR820LLbZ6M+dqjy7cabzNTVDQNjrr3tLpaJLptiAHCCGvhsMavkAWAfBiwyoZtv+0IoW3kRtFT7YXgjcWZOACTsUh4C6DERVmOzbJVFirk1oX6e2mnzzZE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774641196; c=relaxed/simple; bh=DaA5q0E50fq7kc6gfssqfiv3pDfgvxYxqzPlV4F7Lsc=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=GDc/UpRw8AZReVACba5fjaR9sQMxRAWylsr3DaSUEsi28hXGB6j5t1DD1eF9u3/qPCWlZXNDuROwZqdVEZosP8tRXURyyUIE+JXiOweREAjtFbSKHM9GLE+31OS4p9nxk7F0woAUxcK4T09KPGWdORNacORqSK7Buc2dK24dYVg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=mR+0byTc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="mR+0byTc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59DBBC19423; Fri, 27 Mar 2026 19:53:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1774641195; bh=DaA5q0E50fq7kc6gfssqfiv3pDfgvxYxqzPlV4F7Lsc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mR+0byTclEiVX4ZIljfdL00vQe3lzA0cDfVRNASRJr6hGimvfLM2XiyJl1dFWPcgK JuswK16t/bNraw7XTAJDE8AkJ7gVgUNFoczqfNhMvAWSOJqqcLu0Cplw/PN6Kkuig5 zVNBm8snOX8e4uPS/sHoJ8tfTYnHSkSD3PqkFe70= Date: Fri, 27 Mar 2026 12:53:14 -0700 From: Andrew Morton To: Suren Baghdasaryan Cc: "Lorenzo Stoakes (Oracle)" , hannes@cmpxchg.org, david@kernel.org, mhocko@kernel.org, zhengqi.arch@bytedance.com, yuzhao@google.com, shakeel.butt@linux.dev, willy@infradead.org, Liam.Howlett@oracle.com, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] mm/vmscan: prevent MGLRU reclaim from pinning address space Message-Id: <20260327125314.98f1087225ee48d4feb97345@linux-foundation.org> In-Reply-To: References: <20260322070843.941997-1-surenb@google.com> <0f599835-9b99-4457-9ba7-a3eaeb0768d1@lucifer.local> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 27 Mar 2026 08:20:06 -0700 Suren Baghdasaryan wrote: > > Given you have cleared up my concerns, this LGTM, so: > > > > Reviewed-by: Lorenzo Stoakes (Oracle) > > Hi Andrew, > Any concerns about this patch or do you want someone maintaining MGLRU > to Ack it before pulling into your tree? That would of course be welcome. But Suren+Lorenzo is more than enough for me. > The change is quite simple and I explain in my reply why it's safe, > Sashiko seems to like it and I extensively tested it on Android. > Please let me know if anything else is needed. I think that if the fix is valuable enough for Android to backport then we at least should have the Fixes: there to help others who are using MGLRU on older kernels. (We don't have an "Improves:"!) And if it's a really big improvement then we could even pretend it's a bugfix and sneak it into -stable ;) But the changelog doesn't say much at all about how this change affects users. Just "delays". So can you please expand on this (numbers are always nice) and I can paste that into the changelog. Thanks.