From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32D5D38B128 for ; Fri, 27 Mar 2026 20:11:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774642282; cv=none; b=Kqrx1NEi6XZIJ8N6bEMtuoEgDHtXxQ5OMUGncu3fbZXaBRAUfRk9sKlNIvtmqzf9TX0bh58t47QPl6l1H4bqoLd9jZoehhEPHNzNeIwvVPKubmDEhOaSStlxFXgKSvX+glKRx1/ZlXj9x2QFFBcUshRveupfwie1TBpOj97o9GY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774642282; c=relaxed/simple; bh=iGx4rhYd3WWPfBU6xjCFHmzcIe3LMIV0C3cCEAqcfYU=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=ACGPiT93AiyZmdWHZHmDF5gsUHhTTbKxLJY2A+RaSbDEtq6UcofpoAuBiV7RC1IWMLhCV4WOBwiRJI5Ad1zv+BoZOCLPc9aXbS3FoKGZuytwjAHNS4zZiuMCLJ+aFs5+vLN4O0pp+L0myXw+081hwdpkIyS5Z6BvqPCCSMbfwWA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=GspqzoKu; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="GspqzoKu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76909C2BC86; Fri, 27 Mar 2026 20:11:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1774642281; bh=iGx4rhYd3WWPfBU6xjCFHmzcIe3LMIV0C3cCEAqcfYU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GspqzoKucGuEQUYDqA6ZJlUQr5mJXQNpLdCykmAI7hWXnw+B+zbr4sAW/Srdg8+Up 2yetTm2BGgdJAjRMYBB7WlMsfpCBOhiW1glF4LhRSR7Mel4O/7+xoFtYpO2CLtc93B TTUCzMH2DDg/2etYoker17UXZ9QADibor1Za+4SU= Date: Fri, 27 Mar 2026 13:11:20 -0700 From: Andrew Morton To: Dmitry Ilvokhin Cc: Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, Steven Rostedt Subject: Re: [PATCH v2 0/8] mm: use spinlock guards for zone lock Message-Id: <20260327131120.591770a2aa63abbaa7bbeadc@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 27 Mar 2026 16:14:40 +0000 Dmitry Ilvokhin wrote: > This series uses spinlock guard for zone lock across several mm > functions to replace explicit lock/unlock patterns with automatic > scope-based cleanup. > > This simplifies the control flow by removing 'flags' variables, goto > labels, and redundant unlock calls. > > Patches are ordered by decreasing value. The first six patches simplify > the control flow by removing gotos, multiple unlock paths, or 'ret' > variables. The last two are simpler lock/unlock pair conversions that > only remove 'flags' and can be dropped if considered unnecessary churn. Thanks, you've been busy. I'm not wanting to move new, non-fix, non-speedup things into mm.git until after -rc1 so there's your target. But now is a good time to be sending out material for people to look at. Let's not have a gigantic flood of new stuff the day after -rc1! I think progress here is totally dependent on whether those who regularly work on this code want guard() in there. A preference/familiarity/style choice, mainly. At present the adoption of guard() in mm/*.c is very small.