From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1439829A2 for ; Sat, 28 Mar 2026 00:45:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774658752; cv=none; b=DjA3e5sSZs6cGnwCfSHV+UhlNioFlZ5BLOI3c5szQGGagtzdrpGAmeVGSIKmIL0a0MgvRmxvfBT1/y/FAn7aZTEoou1DRQjijkzdWGFNQfhaBsjtC6vmRLMwYKU2pe6U5xMWFe6LXRlYYBdIMIzqXy367CTjc1uNBew8/259FtQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774658752; c=relaxed/simple; bh=oF0seNSMgo6BaY+CXLKYzs5DY1v+srM6BqIoL2yYnhw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=t8n0INkd1ZGk+/ceSaQnwwtGRNvp9UVlxkLj/Q8LT2ut22/n0W8F8cGOgFNDMA4BpIixen2Up7ifxUtuf4RuO0u8082/v1FcFmetoaWZEM5riJzxvlhsHCa4Gh33eb/IHkzDEkFDg8/QImt4SHBaeAe7Hn9cpR7FjVSqx8jax1E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=EeyFl4rE; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="EeyFl4rE" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-c7358a7a8d1so1875472a12.3 for ; Fri, 27 Mar 2026 17:45:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1774658750; x=1775263550; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=OUfAUhOe+fz1n7pxKjOUsQHT/O9aZ9wFUk8VQLCphA0=; b=EeyFl4rEWBU8oxoZUDEgtZ78AQRCN/icLxRwkWabNMEj/XYgn38ZL++EDT7Q3IJ7UW 1emv8QuU3GpXj32Tdca9BuN5ysrW+Gk75PBt/T5f8xxFoBGSAl/Dpkmdh7NhVLNSiznn 00VU8AXK5cEGnQ/avPt+OBLk82GL1tMyg5mp5yt2wrltXmwGxXV3PS2U9JOIQiZ/LNEE fj5pcAdd7wzf+YjY/KDc+J2FGeXAQSNexR60L/v2vT1fIdCxlTVIE+H6ap4I3fJm6J4T ljzueq1PXnjzzuXAQUF3cMJGZ+W4MtDYAiyBio2oq+kp+Q5gIoVtMguJC9e6Ujwi25lU W6OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774658750; x=1775263550; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OUfAUhOe+fz1n7pxKjOUsQHT/O9aZ9wFUk8VQLCphA0=; b=mRx1CUsZ0gS77CQ36DnCH3e9dNPBgK3QkRYJUhr8BCA16S1VDDXKW/I/RuiU/4K/0d ZP1NGPB0qGnbhtxUY4loOjZxLxVHEJ05ChT9kxTyAVVW0SEVuZc5QIj1f98m/gvYqSoA CZq2FcdHKWZByhRCroyoXpXY2S02+sN9Fa7fucpG+0e+thBm4qj7FSki7f9Vvy5Zvneo 8kpKZTDIwL6we9QDlRqXsaQrI67FKGKIxSP51jO/OM69ZcP4YypY0WKEiOm4u6Az2wQP uwkZKrTxvdQVHkhB5xEj9zj72eK1ztB+5DuTDPzCht24+agMBoGz9XSVaNVTb+gATeFi xfZw== X-Forwarded-Encrypted: i=1; AJvYcCX2fG/tbt5xevo2zxQybU1y1ytP4/AjWKUrJGqzAFaj/z1Y7tYp8Ac7fU1A8NurDWnKv5UWPuGWFTmrfvU=@vger.kernel.org X-Gm-Message-State: AOJu0YxRDaALrFVQ6jIOfbSoq4YPTEAOIAZ3eAwrhMVLU+UBlwh11eb+ 5ip23qyih/W0TCcaZt6Hcqe3ymwaEnftD9hY0kAHVtR3snwqlWVB0XTAj3iPXwxWXms= X-Gm-Gg: ATEYQzzcQPINd9/nDTgF/Ttu/xnFPjvCIJvlfnyN4aoR56nKyibaJnETFN2v528FRc+ 1O3Mfpich/PkkqJvrjyORjfuJVlcdgr72scH356uW/k3gIyQvuKJdyu46dRZSMEE6H693OTAOi4 rDqs5U8y5euocI094hIBOyigcct86hdwv1vrHVCDCTjJJtqOCJ5cysDizEeU3AS/G7J8Dt0JgCX tPyor+Qw13waOv7vQ8yjizzDEOw/TDw30t4MtAF6ZnlAlzkZleKIpQHgOHVVOiBstYHaMxjXqnC 8UWJn5XiArxjW0sQo39yybzAQCq2YEr9h6pmAxdLVFgJsN7UcS7b04Iq3SJGVTU/JYJX0lsfBfM OmnAdWIJ3T+3o4a0VxeYAN/CZQngHQTz3A/8Vt88nXxOGloRoCfMnqeq6LexRMk1MqWukNArjIj RS7NttwYg= X-Received: by 2002:a17:903:22ca:b0:2ae:8077:b1c7 with SMTP id d9443c01a7336-2b0cdcd5911mr50850695ad.37.1774658750100; Fri, 27 Mar 2026 17:45:50 -0700 (PDT) Received: from ceto ([2601:640:8202:6fb0::9c63]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-2b242683064sm5342705ad.33.2026.03.27.17.45.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 17:45:49 -0700 (PDT) From: Mohamed Khalfella To: Justin Tee , Naresh Gottumukkala , Paul Ely , Chaitanya Kulkarni , Jens Axboe , Keith Busch , Sagi Grimberg , James Smart , Hannes Reinecke Cc: Aaron Dailey , Randy Jennings , Dhaval Giani , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Mohamed Khalfella Subject: [PATCH v4 00/15] TP8028 Rapid Path Failure Recovery Date: Fri, 27 Mar 2026 17:43:31 -0700 Message-ID: <20260328004518.1729186-1-mkhalfella@purestorage.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patchset adds support for TP8028 Rapid Path Failure Recovery for both nvme target and initiator. Rapid Path Failure Recovery brings Cross-Controller Reset (CCR) functionality to nvme. This allows nvme host to send an nvme command to a source nvme controller to reset the impacted nvme controller, provided that both source and impacted controllers are in the same nvme subsystem. The main use of CCR is when one path to the nvme subsystem fails. Inflight IOs on impacted nvme controller need to be terminated first before they can be retried on another path. Otherwise data corruption may happen. CCR provides a quick way to terminate these IOs on the unreachable nvme controller allowing recovery to move quickly avoiding unnecessary delays. In case of CCR is not possible, inflight requests are held for duration defined by TP4129 KATO Corrections and Clarifications before they are allowed to be retried. On the target side: * New struct members have been added to support CCR. struct nvme_id_ctrl has been updated with CIU (Controller Instance Uniquifier), CIRN (Controller Instance Random Number), and CQT (Command Quiesce Time). The combination of CIU, CNTLID, and CIRN is used to identify impacted controller in CCR command. * CCR nvme command implemented on the target causes impacted controller to fail and drop connections to host. * CCR logpage contains the status of pending CCR requests. An entry is added to the logpage after CCR request is validated. Completed CCR requests are removed from the logpage when controller becomes ready or when requested in get logpage command. * An AEN is sent when CCR completes to let the host know that it is safe to retry inflight requests. On the host side: * CIU, CIRN, and CQT have been added to struct nvme_ctrl. CIU and CIRN have been added to sysfs to make the values visible to the user. CIU and CIRN can be used to construct and manually send admin-passthru CCR commands. * New controller states FENCING and FENCED have been added to make sure that inflight request do not get canceled if they timeout during fencing process. FENCED exists so that controller state machine does not have a transition from FENCING to RESETTING. Instead FENCING -> FENCED -> RESETTING. This prevents a controller being fenced from getting reset. Only after fencing finishes the impacted controller is reset. * Controller recovery in nvme_fence_ctrl() is invoked when LIVE controller hits an error or when a request times out. CCR is attempted first to reset impacted controller. If it fails then inflight requests are held until it is safe to retry them. * Updated nvme fabric transports nvme-tcp, nvme-rdma, and nvme-fc to use CCR recovery. Ideally all inflight requests should be held during controller recovery and only retried after recovery is done. However, there are known situations where that is not the case in this implementation. These gaps will be addressed in future patches: * Manual controller reset from sysfs will result in controller going to RESETTING state and all inflight requests to be canceled immediately and may be retried on another path. * Manual controller delete from sysfs will also result in all inflight requests to be canceled immediately and may be retried on another path. * In nvme-fc, nvme controller will be deleted if remote port disappears with no timeout specified. This results in immediate cancellation of requests that may be retried on another path. * In nvme-rdma if HCA is removed all nvme controllers will be deleted. This results in canceling inflight IOs and may be they will be retried on another path. Changes from v3: - nvmet: Implement CCR nvme command - Fixed a bug in the order of members of struct nvme_cross_ctrl_reset_cmd - Use kmalloc_obj() instead of kmalloc() - nvme: Implement cross-controller reset recovery - Now CQT has been removed updated nvme_fence_ctrl() to return success or failure instead of remaining time. - Updated nvme_issue_wait_ccr() to respect deadline set in nvme_fence_ctrl(). - nvme-tcp: Use CCR to recover controller that hits an error - nvme-rdma: Use CCR to recover controller that hits an error - Updated log nvme_fence_ctrl() return value - nvme-fc: Refactor IO error recovery - Updated the commit message - Updated nvme_fc_start_ioerr_recovery() to handle CONNECTING case first. - nvme-fc: Use CCR to recover controller that hits an error - Updated log nvme_fence_ctrl() return value - nvmet: Add support for CQT to nvme target - nvme: Add support for CQT to nvme host - nvme: Update CCR completion wait timeout to consider CQT - nvme-tcp: Extend FENCING state per TP4129 on CCR failure - nvme-rdma: Extend FENCING state per TP4129 on CCR failure - nvme-fc: Extend FENCING state per TP4129 on CCR failure - Dropped CQT patches v3: https://lore.kernel.org/all/20260214042753.4073668-1-mkhalfella@purestorage.com/ *** BLURB HERE *** Mohamed Khalfella (15): nvmet: Rapid Path Failure Recovery set controller identify fields nvmet/debugfs: Export controller CIU and CIRN via debugfs nvmet: Implement CCR nvme command nvmet: Implement CCR logpage nvmet: Send an AEN on CCR completion nvme: Rapid Path Failure Recovery read controller identify fields nvme: Introduce FENCING and FENCED controller states nvme: Implement cross-controller reset recovery nvme: Implement cross-controller reset completion nvme-tcp: Use CCR to recover controller that hits an error nvme-rdma: Use CCR to recover controller that hits an error nvme-fc: Refactor IO error recovery nvme-fc: Use CCR to recover controller that hits an error nvme-fc: Hold inflight requests while in FENCING state nvme-fc: Do not cancel requests in io taget before it is initialized drivers/nvme/host/constants.c | 1 + drivers/nvme/host/core.c | 225 +++++++++++++++++++++++++++++++- drivers/nvme/host/fc.c | 215 +++++++++++++++++++++--------- drivers/nvme/host/nvme.h | 24 ++++ drivers/nvme/host/rdma.c | 30 ++++- drivers/nvme/host/sysfs.c | 25 ++++ drivers/nvme/host/tcp.c | 30 ++++- drivers/nvme/target/admin-cmd.c | 123 +++++++++++++++++ drivers/nvme/target/core.c | 110 +++++++++++++++- drivers/nvme/target/debugfs.c | 21 +++ drivers/nvme/target/nvmet.h | 18 ++- include/linux/nvme.h | 65 ++++++++- 12 files changed, 812 insertions(+), 75 deletions(-) base-commit: dd09eb443372f9390d36051d86ebe06e9919aeec -- 2.52.0