From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80B6A31355C for ; Sat, 28 Mar 2026 05:26:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774675589; cv=none; b=rNoe8pM+Gk6o1kNkuUOBwwhbHGh1aRXzyTDfVjI8e7c2QBhFrE6GvQFadVbklYyAG061M+hsf7pHyhHyLiaXGuqESh81owoOcaAGnr7PjbIGTkHV80GSyimlqGUmjLA5dIhECbUGdp8MwXlqRR0z1yjEMbTEgi4hdhlMNJtwZCc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774675589; c=relaxed/simple; bh=OaTNHK421v9P5ArUO5x9BFubrdvQgCKsOKXrdPxtfME=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=IpqWpP0bCJa83QIFbwOp9K/m/VGMaXX3I13nc9Crs67KZpWgOCKAiinEflBtB2uNTZ+7wdqJZHBf3Jdau+uGtR8gkN+1Gf2yGYUwB7+1JGLFHBa1YiGmxo4CiXjXQMoI+HZ621fnuRG4z7pepb2a/oGA/hx1pFPfkH0knYeay0w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZKyukBcE; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZKyukBcE" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-82a07738118so1677815b3a.0 for ; Fri, 27 Mar 2026 22:26:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774675588; x=1775280388; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=VFFoh3CyOeLt0Uxg0Nq/w5Z8lWNqgZKYp7YIVeIzttw=; b=ZKyukBcE+XisWTklYJ7XjQl1MRWDGAKY0xmwyS38KCO2U1AFU9XjEXHz+Syr2gkw3D nj8QVzJfFAtHivWGmC+WM+UXImkVAdqKFIeS/0RMtAEwTUMkgBJvXgRrJT8RW94UFvw+ Sf/eiDHxa/AzsSG3Emo9IqGBjgXGvsoShMXEEcF6bSIyK5g4Vdr2Uy2fw6M1kgqWc7f2 ydx41eLmHLqm104bYQmTUrdFbeY3sGIKjK2vHYFpSVYf4DAZFGOa8ELz8ix2XbZbwQJP c3STiGSPZe0kzK5B9cUbA8293gnZ0MfQceq9RAQoKnze0nEGZBDGD5GL5DnP+851+wBX bAog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774675588; x=1775280388; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VFFoh3CyOeLt0Uxg0Nq/w5Z8lWNqgZKYp7YIVeIzttw=; b=I1RzKHqwHSq7jXKpnJuXe9nZNe8n3n9efxb/LA3VLw00bGdBQgvtghzarL4v79VymZ f3EdZEMTffJiwzqRSqvdIyuDEmJgt0vjh7gpFttcB8yRD9ZpeB8+joKC85RwKBgLdZJL BYQNSUJsJN15lQcqG5AFBOu/goUMdxMhr4sFqvolrdK1DCsdm99m0KGqNb8db22etyK1 Quq88g3xL2OmqRz3q8QSTIPYDdTZ0DXOFZTtEYboxXBLBFoc5g6jd4g3Jxkwqn/goRX3 L5tUk68NtXnlfevfI5L4Ewt3+QP5B73yMcPV9OmPvpOMvkU+0wCx5QBJiH3A3NKgNkP7 Pnwg== X-Forwarded-Encrypted: i=1; AJvYcCWZdf8fqAH1lAdFrOJQxqMEXBr3d7rIx0GWXuHJWUp/8scK9nxdpLKS+lSHy3XHOaORkDvrYUkY+UIK1N4=@vger.kernel.org X-Gm-Message-State: AOJu0Yxs3eAI96TYO6hKC8npt0+VcgzDCddbIg9ZDsfvdUgJ2hvm4MW1 7idYA9PhLyRkVWLtrclRLjc0woS4dMN6gn76H8sBihvhMI1lF5Sw6mLb X-Gm-Gg: ATEYQzxzLjqDtMsjXqQpBXgYORJSV+ZGZpE6tFpdJnh8l4N2l2S6U/XFG6HLIgQLn9z RfnCIQouwZ1KbcQH+7VoETOAI7nUwlla6VESBeqlL+6Gi2Xf8Xp+Ej0wYjTIxPfecBAzeDL7H5+ jiETwVNZXGrLEBSfhOeKGMGqVNv+Te76itKz6+syKjzmFYJXS84k/UbgdJKReL21Mt9Eh5bMC5t L/YDHRPAZEwTQfatiZFwunx0CvyDbMwdebq0tP/v334AWv0+jiLzHpJcb1EP5i3YTuMx9jEBuDR c4u40vs15TLFL5KU6sQ5XAJuBp9Qu117jX41pyynRRltBD+Wx7FFPXhoDBBkt+WTZFmE+j2oxpL UUwHuPZH7ZHbazagv8/8a7Iq5ZZw365Pw1v1mOwaiBnxVF5u9ybxugYf/UwlxCjUum64NsKpPqh F7FKyzEY7xMB4Lqa2FwaqMpPXCmjPLLgTA1SU5ZOeaVqWbbGHI X-Received: by 2002:a05:6a00:1a91:b0:82a:6852:559e with SMTP id d2e1a72fcca58-82c95e5ab8cmr5003664b3a.12.1774675587591; Fri, 27 Mar 2026 22:26:27 -0700 (PDT) Received: from debian.killsync.com ([152.58.216.159]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca86307a5sm923739b3a.60.2026.03.27.22.26.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 22:26:27 -0700 (PDT) From: aravindanilraj0702@gmail.com To: broonie@kernel.org, linux-sound@vger.kernel.org Cc: cezary.rojewski@intel.com, liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.dev, perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH v4 0/4] ASoC: Intel: Fix MCLK leaks in Date: Sat, 28 Mar 2026 01:25:51 -0400 Message-ID: <20260328052556.434191-1-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Aravind Anilraj In three Intel ASoC board drivers, the EVENT_ON path in platform_clock_control() enables MCLK via clk_prepare_enable() but fails to call clk_disable_unprepare() on subsequent error paths, leaking the clock reference. v4: Split dev_err formatting fix into a separate patch 4 as suggested by Mark Brown. Add return code to the error message for better diagnostics. v3: Restored missing clk_disable_unprepare() guard in patch 2 that was accidently dropped during v2 rebase. v2: Guard clk_disable_unprepare() with SND_SOC_DAPM_EVENT_ON() to avoid calling it in the EVENT_OFF error path where MCLK was never enabled. Fix this across all three affected drivers. Aravind Anilraj (4): ASoC: Intel: bytcr_rt5640: Fix MCLK leak on platform_clock_control error ASoC: Intel: bytcr_rt5651: Fix MCLK leak on platform_clock_control error ASoC: Intel: cht_bsw_rt5672: Fix MCLK leak in platform_clock_control ASoC: Intel: boards: Log error code in MCLK configuration failure sound/soc/intel/boards/bytcr_rt5640.c | 4 +++- sound/soc/intel/boards/bytcr_rt5651.c | 4 +++- sound/soc/intel/boards/cht_bsw_rt5672.c | 4 +++- 3 files changed, 9 insertions(+), 3 deletions(-) -- 2.47.3