From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD9EA347FDE for ; Sat, 28 Mar 2026 15:23:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774711385; cv=none; b=kIc8vuSCniF+BOybLfbeYU0RD6FuDOWVos/FvO1WliusnmJNGfen0BZN6kNUPvb+VvZvwH2FviJbuT+I+35jzPbEgOFEC/nTjPXxtRoZ0R03x87GPwjbqI3qvpGS1zATVGlInYdwohVAXdZPOLQA0FrOxl59WzCRIqAphbYHUdU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774711385; c=relaxed/simple; bh=QT1ktfNmN1UcDS1rLtjBYoZjSUgMc025Oyaz/fGFc7o=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=IO2lMI+0lWvbtk+qxKHi/mw805zFbH7wqKFt8vZBOx5hVT1+KhdijXz0dtoB7ED5H0FPTgC+f1cC8RNS6siiki4QdEsMFk6flst8hUIbnfb93Fz/Alt0msIZTrGjQoerl/cADe9r+yjkYrMulozKAGQO40aF3CNQtIhRteLaQQM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sZVIAaoI; arc=none smtp.client-ip=209.85.208.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sZVIAaoI" Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-38a723b2b29so26417731fa.2 for ; Sat, 28 Mar 2026 08:23:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774711382; x=1775316182; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=nd5Xli4czy19zxhELaWrbYsp5OrzbC0MTbSXRE2sw1A=; b=sZVIAaoI1FA3npnZqtjw2enceEAbFeCkLO/g+dIKTPuKpN3dhp1Fcm3LUinhFuCs54 27DcYwPns/JL9Otv3RR9CXq29mHT0hVz2ZbNE0JtYz5djtH8d7iauZmJHXItQV//dRBw 6A+S/0Gs52FYTiklgYFr02vcgYYSmcceokF29C5Sr3wq1KI/gF8ok1yO6kNyVyHmSitO ge9/rzy/19xRc3fH1gtrcw6p6wmIAC49SEPyOqdgWpVWnmJ740tLRawdlqB6a8B8U3Uh wZhOPN3HMjyzreRYLPGRx+7PJeX/O8mRUXao2tN+P6wkz1XEW+aLsf8dd05j064qBIGi 25Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774711382; x=1775316182; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nd5Xli4czy19zxhELaWrbYsp5OrzbC0MTbSXRE2sw1A=; b=Rtu0dezo/BN0slxxfFKROwDhLK/S6icmesSdhqFbAYyZz/J10Bf+8RgGsZnHAQ2nKV aCwhBqwRzqF20uJFf4LqjMrJeIAtOZ9EW7hmQMMqdtCCk0h5aAERWcgvYSsK++LYDclh XaOSlk+FSrLmZZpkYw7z19BYmeGUtfrIGzJzCtXyYqYzO9Rj5/akymMPyd1K9BOYCxF0 uO8FfOxoz5zvnnVfDoTw9EoSWfpJFPXTC22vMLWzW74g/NXaIoomO3iwE+GZ9jxbuKcZ ExcO4wnO9BoxaknA0Ykh/nzj0MyTdQEQelpwtpQMvsl8ENn7jW1qFcoGO+Q9IkfAtUXk mTWw== X-Forwarded-Encrypted: i=1; AJvYcCVYfp+DCl1z4sm0MC8d/6zQy7L9U06R6vJu72GdEdklsl68aRfSYJgvO5/dhU5kW0hhMCjTfdJ0mihj6dI=@vger.kernel.org X-Gm-Message-State: AOJu0YwaGagzTrr7uddB17lW0d4KSWRMVM41TLLBtCHmqjzRIXce9Z45 oJMai3nHxb5hEN+cl+jRUnqzycdaEEgh92yAhXtiEm2INeS1NUtaDAWIwyvsjAgNx2k= X-Gm-Gg: ATEYQzz+9VPz8kzJMS/a4aYqEp1yKV2ATageSs7NIxDhbCHTjwClEFVO78CvQ+pcgPj XS7xY8j5mdOBGveXlbUDScD3kFCYBl4oN5jZ/rouLWLk1onpdVcTAru3DEeMCCPmfH/VAXf638A 7toYaR4PfeXb5jWZ1eagXOn6+0WDBnHOtfdAFO64s0SMOoMVuOy02ufH5fMkzRyW5Fj4ubnFt5I /9T5npveb4XGliCDeMNpfIXlb1boaweiTJyaJzy907EzEs5Pf0GTSno2bADK3PawvYA0OpA0myH yKToeR9mu9FF/P+3gyHofBJVDCGYQoB2mlkx4WUKvpc3nXxf1SZZOu8FjHn0g0ehU/Ah53ccOug F0PULnlRZjdouEgMHFzAq78E6EVl1ZZqmq3XOOqBh0KIRofCYdLCXhdSuI7Sh0SFCC8b3aL2Mc5 qLRT5HITNMaSJhG8gViWji23ywdR2wWjvzyXrTdLrCWuENcyp4GQYww0mYiAug+SbK3eouJqVs0 zOT4KgPr38dw/lwI7kri/U= X-Received: by 2002:a05:600c:6094:b0:486:fd71:e609 with SMTP id 5b1f17b1804b1-48727f1fc05mr100679925e9.25.1774710897912; Sat, 28 Mar 2026 08:14:57 -0700 (PDT) Received: from dohko.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4873069961esm51573795e9.12.2026.03.28.08.14.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Mar 2026 08:14:57 -0700 (PDT) From: David Carlier To: dan.scally@ideasonboard.com, jacopo.mondi@ideasonboard.com, mchehab@kernel.org Cc: nayden.kanchev@arm.com, hverkuil+cisco@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, David Carlier Subject: [PATCH v4 1/3] media: mali-c55: add missing of_reserved_mem_device_release() Date: Sat, 28 Mar 2026 15:14:50 +0000 Message-ID: <20260328151452.148901-1-devnexen@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit mali_c55_probe() calls of_reserved_mem_device_init() to associate reserved memory regions with the device. This function allocates a struct rmem_assigned_device and adds it to a global linked list, which must be explicitly released via of_reserved_mem_device_release() — there is no devm variant of this API. However, neither the probe error paths nor mali_c55_remove() called of_reserved_mem_device_release(). Any probe failure after the of_reserved_mem_device_init() call, as well as every normal device removal, leaked the reserved memory association on the global list. Fix this by adding an err_release_mem label at the end of the probe error chain and calling of_reserved_mem_device_release() in mali_c55_remove(). The remove teardown order is also corrected to call mali_c55_media_frameworks_deinit() before kfree(), mirroring the probe init order in reverse. Fixes: d5f281f3dd29 ("media: mali-c55: Add Mali-C55 ISP driver") Signed-off-by: David Carlier --- drivers/media/platform/arm/mali-c55/mali-c55-core.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/arm/mali-c55/mali-c55-core.c b/drivers/media/platform/arm/mali-c55/mali-c55-core.c index c1a562cd214e..5cb59c70ffc9 100644 --- a/drivers/media/platform/arm/mali-c55/mali-c55-core.c +++ b/drivers/media/platform/arm/mali-c55/mali-c55-core.c @@ -806,8 +806,10 @@ static int mali_c55_probe(struct platform_device *pdev) vb2_dma_contig_set_max_seg_size(dev, UINT_MAX); ret = __mali_c55_power_on(mali_c55); - if (ret) - return dev_err_probe(dev, ret, "failed to power on\n"); + if (ret) { + dev_err_probe(dev, ret, "failed to power on\n"); + goto err_release_mem; + } ret = mali_c55_check_hwcfg(mali_c55); if (ret) @@ -846,6 +848,8 @@ static int mali_c55_probe(struct platform_device *pdev) kfree(mali_c55->context.registers); err_power_off: __mali_c55_power_off(mali_c55); +err_release_mem: + of_reserved_mem_device_release(dev); return ret; } @@ -854,8 +858,9 @@ static void mali_c55_remove(struct platform_device *pdev) { struct mali_c55 *mali_c55 = platform_get_drvdata(pdev); - kfree(mali_c55->context.registers); mali_c55_media_frameworks_deinit(mali_c55); + kfree(mali_c55->context.registers); + of_reserved_mem_device_release(&pdev->dev); } static const struct of_device_id mali_c55_of_match[] = { -- 2.53.0