From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83E8432FA10 for ; Sat, 28 Mar 2026 15:15:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774710901; cv=none; b=m13k0c26DzBFz1z6lw6W0r7H8zwyItwRDSeymC20+jqpyokD8et5SLJUcsgiIvhffj817kpAUlawlVDMo0qwMKBo7b6g717JzjTMFjMD7BnikMWijomvKw6R1LzAoe4YHMAuyvbQm6XlzTlAsRXFxv53qIaP/BOuwEFAhWPeuW4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774710901; c=relaxed/simple; bh=8a0gNtVykYgDR6+waIRbze9QAug3gZauHStbzAuJIfc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=C8AfeiCdnu5HGZqUAhUzJP+L8amg0tS099vGHPTWgLIX1z19MEq+x2+JsxfOh73r3IbvR3IzPcsT224FsOof9sU9SnIpWc+nRcv4m5a0hFClesnNNcGvzB9gaL9l25uXz+Nw4Adys+zChe646u4+4uGrVy5xhXNNjvTw+LJN3Uc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dXxr1Uyw; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dXxr1Uyw" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-439b9cf8cb5so2994472f8f.0 for ; Sat, 28 Mar 2026 08:15:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774710899; x=1775315699; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+X7JPJETnQPZSwpvLQ+Nx6DR2XzD/HlDNrW9w9MHCFs=; b=dXxr1UywTQjOAqDqXmpmPHeXGU2zPS6D6q7j/IyK+qke+RVyJrNi6qJX8PoNlYC3l2 kLWTTjcLWK2DScxTyjUZt1O78wpGO3daKJFbyRBQIyEbDRXWWaHM/uA2WP9SHMVKpW0N zMNVlFnzg8QpUtcZ1y1hICxWk8PDGndgn52St6iul05j3cGbQWvVaE320r7GM8qT9FEo yIqWCDKqhXhL9ozWTmgPuwX5L3rqhZaGiKaP6TguHlMNk57NWRjxQdbiXkIcyqOlDNV8 F+dmmYOyVECDzrbPBzbJ/hK7iV85YqIjfzA95cKO3rrhfPY13+YG5q0DCnYIadtqwoEi 9Fsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774710899; x=1775315699; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+X7JPJETnQPZSwpvLQ+Nx6DR2XzD/HlDNrW9w9MHCFs=; b=gc63tjS3ec57N58iOmr3SngHbt5gwHZzgSbEARURwkSWsvchb+cVLisFgeVHnZMxVh sPrF1s6dLRdHNR4+keZsCEoYBSfRqHegfRbW7Xh4+4tU8YSaRAsjLIp4KD99JT/64v47 /4bSoXv4p0sBme9FflksOeheNmQZp5aOvVyZY52xYVTnJ1h1L6D0n7Vujoosz6kK1JB6 vOJT5I4MnTkO6EDA30sfzexYHpNK30meoD4AEKpZRPFo34WNQ7/Cxn9WtRwhrtmGXzTs oHqMmdC44/VFcrOA75jLCUz/kikcAd2LQoRC+1sSzjvCVhGmp/kMvz/Kpy5OMX18k67a X4dA== X-Forwarded-Encrypted: i=1; AJvYcCWAD3I+jQeuU90EdgBs3xLxMVN6Kx5fTc7vgt5ppJ1jYHr/M41GSwYA70gx9zExzfDTTNPItk620hMZHQQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1BrVh/UKbOSpzHeFv/Ihda3CFN++l6MCHgUHYZjueybBsE7lc Fut8lkzhBIeVrlK9vlYx3qACYaB8cQJ92/hx6VxX8h0cLMdz5Zl8c4vO X-Gm-Gg: ATEYQzwvNJXWWG9VJ3EKjPC/RZxv8v2ivjx0lmKhNtFTfiiWKSpg4KtAviJRUZ/tkW4 fGdRA/fkFqApQM/pBWfmfcDSLzgr/WsWhFOKNEwSMtfdXX59xgm9pLXAzXnQiQHwd8nIbXZDM5g UNhIE8z+L/nlA/mbXWyTzvqAa3iEAU7qG5oLrAz0HRjDx0mHtlcPQ8D+hpTXHAGO2xof0FCaVmK 9XLZqwyk/neRchoc/w1lklL1qfBn0X7fPg9fIax2551dB1afnYWZVhKjHgPJZODLcki2fpAvG0K aAKCyJOjFJvppr/VBmkBnBBM1eHyYzg5khE1Chfg61phfOPgoU9ZcSXMt3Dg7z18uysIFPsMUU4 7AET8vy+j2i/bpdQRznf2ygWt1ckWIUbdsII5zxDL/8+Z9N5K5wE9MVLnG4HjFE+eXFRZoml/Bz 2pLDoRLz37Gc0ey1/Dp+STdQ+bxXOgOZkY2Gr3AkyfIXoyv2//SJEp0WEXx/xRbYRAtx24GYiPH 8ZIbXmTdGRl X-Received: by 2002:a05:600c:c8f:b0:485:5ba3:37d8 with SMTP id 5b1f17b1804b1-48727d59cf4mr108094595e9.5.1774710898710; Sat, 28 Mar 2026 08:14:58 -0700 (PDT) Received: from dohko.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4873069961esm51573795e9.12.2026.03.28.08.14.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Mar 2026 08:14:58 -0700 (PDT) From: David Carlier To: dan.scally@ideasonboard.com, jacopo.mondi@ideasonboard.com, mchehab@kernel.org Cc: nayden.kanchev@arm.com, hverkuil+cisco@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, David Carlier Subject: [PATCH v4 2/3] media: mali-c55: Power-off the peripheral in remove() Date: Sat, 28 Mar 2026 15:14:51 +0000 Message-ID: <20260328151452.148901-2-devnexen@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260328151452.148901-1-devnexen@gmail.com> References: <20260328151452.148901-1-devnexen@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The Mali C55 driver doesn't depend on PM. For this reason, if pm_runtime is not compiled in it is required to manually power-off the peripheral during the driver's remove() handler. Also pm_runtime_enable() is called during probe but mali_c55_remove() never calls pm_runtime_disable(), leaving the device's runtime PM state enabled after the driver is unbound. Manually power-off the peripheral in remove() if the peripheral has not been suspended using runtime_pm and disable runtime pm. Fixes: d5f281f3dd29 ("media: mali-c55: Add Mali-C55 ISP driver") Signed-off-by: David Carlier Reviewed-by: Jacopo Mondi --- drivers/media/platform/arm/mali-c55/mali-c55-core.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/media/platform/arm/mali-c55/mali-c55-core.c b/drivers/media/platform/arm/mali-c55/mali-c55-core.c index 5cb59c70ffc9..cf238bdf65c8 100644 --- a/drivers/media/platform/arm/mali-c55/mali-c55-core.c +++ b/drivers/media/platform/arm/mali-c55/mali-c55-core.c @@ -859,6 +859,11 @@ static void mali_c55_remove(struct platform_device *pdev) struct mali_c55 *mali_c55 = platform_get_drvdata(pdev); mali_c55_media_frameworks_deinit(mali_c55); + if (!pm_runtime_suspended(&pdev->dev)) { + __mali_c55_power_off(mali_c55); + pm_runtime_set_suspended(&pdev->dev); + } + pm_runtime_disable(&pdev->dev); kfree(mali_c55->context.registers); of_reserved_mem_device_release(&pdev->dev); } -- 2.53.0