From: Mateusz Guzik <mjguzik@gmail.com>
To: brauner@kernel.org
Cc: viro@zeniv.linux.org.uk, jack@suse.cz,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Mateusz Guzik <mjguzik@gmail.com>
Subject: [PATCH v2 0/5] assorted ->i_count-related changes
Date: Sat, 28 Mar 2026 16:38:02 +0100 [thread overview]
Message-ID: <20260328153807.3368975-1-mjguzik@gmail.com> (raw)
The icount_read_once() stuff lines up with inode_state_read_once().
The prefix is different but I opted to not change it due to igrab(),
ihold() et al.
There is a future-proofing change in iput_final(). I am not going to
strongly insist on it, but at the very least the problem needs to be
noted in a comment.
Finally, igrab() gets lockless treatment. I verified btrfs likes to call
into it in writeback code with the count > 1, same with procfs during
process reaping. Grep shows nfs also calls there, but I have not checked
how often that happens. This is a minor single-threaded speed up at
least as a lock trip is avoided in the common case.
[this is v1 except without the unrelated patch]
Mateusz Guzik (5):
fs: add icount_read_once()
Use icount_read() and icount_read_once() as appropriate.
fs: enforce locking in icount_read(), add some commentary
fs: handle hypothetical filesystems hich use I_DONTCACHE and drop the
lock in ->drop_inode
fs: locklessly bump refs in igrab as long as it does not transition
0->1
arch/powerpc/platforms/cell/spufs/file.c | 2 +-
fs/btrfs/inode.c | 2 +-
fs/ceph/mds_client.c | 2 +-
fs/ext4/ialloc.c | 4 +--
fs/hpfs/inode.c | 2 +-
fs/inode.c | 42 ++++++++++++++++--------
fs/nfs/inode.c | 4 +--
fs/smb/client/inode.c | 2 +-
fs/ubifs/super.c | 2 +-
fs/xfs/xfs_inode.c | 2 +-
fs/xfs/xfs_trace.h | 2 +-
include/linux/fs.h | 13 ++++++++
include/trace/events/filelock.h | 2 +-
security/landlock/fs.c | 2 +-
14 files changed, 55 insertions(+), 28 deletions(-)
--
2.48.1
next reply other threads:[~2026-03-28 15:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-28 15:38 Mateusz Guzik [this message]
2026-03-28 15:38 ` [PATCH v2 1/5] fs: add icount_read_once() Mateusz Guzik
2026-03-28 15:38 ` [PATCH v2 2/5] Use icount_read() and icount_read_once() as appropriate Mateusz Guzik
2026-03-28 15:38 ` [PATCH v2 3/5] fs: enforce locking in icount_read(), add some commentary Mateusz Guzik
2026-03-28 15:38 ` [PATCH v2 4/5] fs: handle hypothetical filesystems hich use I_DONTCACHE and drop the lock in ->drop_inode Mateusz Guzik
2026-03-28 15:38 ` [PATCH v2 5/5] fs: locklessly bump refs in igrab as long as it does not transition 0->1 Mateusz Guzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260328153807.3368975-1-mjguzik@gmail.com \
--to=mjguzik@gmail.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®