From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f43.google.com (mail-dl1-f43.google.com [74.125.82.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 862133A63F1 for ; Sat, 28 Mar 2026 18:27:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774722432; cv=none; b=KePnJn6loznWyiykgWccLisHNUIWuRBx5NpHVCEDr2D8JVjeQm7Y7EKcgu+bDH0PuJs/Czb7OO1+5K4m8V93saodoy8iTzlBi+CahvRROcDjrAH1tSC1O9JjMg2Hy3ykDZ6EvdxkVDWzqDz4wRGmyjj5Aq3rC6jDLqJ/yUpkBhI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774722432; c=relaxed/simple; bh=IMlgHod5XNtzqRgvamgEbgBmHZXu09+o3dzVC2caZS8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=q2sSx6yJZ2Np26s5R2rO4+Z2Y4EuGwSXr20axX9JapTsnEb9D/hZQDEM+E/25YfODqyfmHUT1QVmbkB9tATjoWrKAl5kZrcsdLXjymohvII8WlS7t3lNQ8MQveG323R4AejnIul7GdLyDrGjxjxEseqFvbI+pB/3EG64EcchDuk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org; spf=pass smtp.mailfrom=networkplumber.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20230601.gappssmtp.com header.i=@networkplumber-org.20230601.gappssmtp.com header.b=hxueME8h; arc=none smtp.client-ip=74.125.82.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20230601.gappssmtp.com header.i=@networkplumber-org.20230601.gappssmtp.com header.b="hxueME8h" Received: by mail-dl1-f43.google.com with SMTP id a92af1059eb24-126ea4b77adso4474523c88.1 for ; Sat, 28 Mar 2026 11:27:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1774722430; x=1775327230; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VW5wDrj91rUi5skYQJuZdC2c3AtpzF2Z2lldlpB4yjY=; b=hxueME8hlwan9x59H/a4uhfg+Kv9nLFmvmeDVSqCW7DKJQ8e25uOQQPCU/Qb1t1f4P 6im8sPsQQ0LXNeOKhJlwEFMUhEMKToipOyh3JTXmEWbG+hMLByij85WMjgRhySGrThJn wGj3/0cnyVKe8M5crgNTK8U1NxjDHozKkYgVKibrjNY2/F7E2laa2TbF28YdZH/1zerc FUOhET1XUVq4praauxvRvuTGZeSmY8ycz8wuSyhOlbCdrfZ7ORuLToIuSoA98W0FdKYu eL4mwkkdYI/lQt+FrGLaUU8x217vQJTXWD66PZHjhu+fx1SyeHysvpy0SJBfXdJvJ4or gLsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774722430; x=1775327230; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VW5wDrj91rUi5skYQJuZdC2c3AtpzF2Z2lldlpB4yjY=; b=fI7DaqvBYFmAfnWh9M4Ps3AdBwq8dY8ty96Y49nyhqw+/Wz78x4lhahjLDztLHEmw7 mXqvgD/UGhKT2P6ChBVpvndh+nQWkIDVzrFUgXXRwOHr30STi5azVpzgogYj2fJZVpoY I/QfCyJ8lO/gC3uF+96pbsHH4aFH1RpvyCDvLwReV2gGba75Ped+G7ks/YvBL39reII2 kr1WZt1z4xpMKVO46+pIBKC6cJPnpWfKrVkxId5f0tuivZCDDUB0KarnP87+2yjkDSJa DBNBdqd4nwTay+5GvXDSWnkX5Jlt9aUeDfjlJrONW9JT1E+qGVfYSrJfeDdKOVATHr5z sZLA== X-Forwarded-Encrypted: i=1; AJvYcCWcZ0fM6S/fcmR7Jysgahv63MgxV5kVIKQwBxZjShD6QRmWCXt0XH/gS90PfDScnATU4X+GDf8tH1OVO2I=@vger.kernel.org X-Gm-Message-State: AOJu0Ywd4M3hcUPOfofYVrQvU2VPvq9d6cmhQg32NTJlenMwOmAuGVhU xGFb9ixfggjU3raHfaoAsiOC8LoMBS+JQxINTNMz+JlaffTxhuXnCxI4TCOeK7+1umw= X-Gm-Gg: ATEYQzxFXL5Z9gjh8s8Pwavr57HM4lJY/WyWINoI/SDvVmomTwSXAdyi1iMdhMl2zFX QsB+DWz7j6T0nM47kir2itvb79IyCfVIye9TEcLCaBEs9+oGTIzGRe+0ND7F0ntYK5Oiwo+MCR9 Q4OdiC9yd7vQX+AgS1qHvAURL7Vx9+QIpxmk+6twRo3aiuYCBEIq6vQt7Rf/aOY+RYUhW1EH6Uk WVnS9ttfkU6Qn32dwCYxgZ8i8WelJUdEqNHKjRm/b3L/jb+RCcA16KRqiPSV/3r4A5edTHpR5zi CfTduPHT8d21rb1D1E3tMnuw32nL46taQhjc88Kf6D2Cw54t/bT5ud9/HlvmO5P93ES1gJodi9Z vsGdTYjmq4nAhvCUmIX167DQlfQAmrjsKzweD82n9zOYE744nWbDDypWzp1VHgB6ypmrMarR2+p sJRiyVji/Muhf/YIBEL3Nh3r41szM1QupaiYdXS70S89I= X-Received: by 2002:a05:7022:4393:b0:128:d396:f2e2 with SMTP id a92af1059eb24-12ab2857b2emr3346045c88.8.1774722429611; Sat, 28 Mar 2026 11:27:09 -0700 (PDT) Received: from phoenix.lan ([104.202.29.139]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12ab97cb08csm3909263c88.3.2026.03.28.11.27.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Mar 2026 11:27:09 -0700 (PDT) From: Stephen Hemminger To: netdev@vger.kernel.org Cc: Stephen Hemminger , Jamal Hadi Salim , Jiri Pirko , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Neal Cardwell , Yousuk Seung , linux-kernel@vger.kernel.org (open list) Subject: [PATCH net-next 2/6] net/sched: netem: check for invalid slot range Date: Sat, 28 Mar 2026 11:26:03 -0700 Message-ID: <20260328182704.456993-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260328182704.456993-1-stephen@networkplumber.org> References: <20260328182704.456993-1-stephen@networkplumber.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Reject slot configuration where min_delay exceeds max_delay. The delay range computation in get_slot_next() underflows in this case, producing bogus results. Fixes: 0a9fe5c375b5 ("netem: slotting with non-uniform distribution") Signed-off-by: Stephen Hemminger --- net/sched/sch_netem.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c index 73d0e85eeadc..de22d754cb79 100644 --- a/net/sched/sch_netem.c +++ b/net/sched/sch_netem.c @@ -831,6 +831,17 @@ static int get_dist_table(struct disttable **tbl, const struct nlattr *attr, return 0; } +static int validate_slot(const struct nlattr *attr, struct netlink_ext_ack *extack) +{ + const struct tc_netem_slot *c = nla_data(attr); + + if (c->min_delay > c->max_delay) { + NL_SET_ERR_MSG(extack, "slot min delay greater than max delay"); + return -EINVAL; + } + return 0; +} + static void get_slot(struct netem_sched_data *q, const struct nlattr *attr) { const struct tc_netem_slot *c = nla_data(attr); @@ -1045,6 +1056,12 @@ static int netem_change(struct Qdisc *sch, struct nlattr *opt, struct netlink_ex goto table_free; } + if (tb[TCA_NETEM_SLOT]) { + ret = validate_slot(tb[TCA_NETEM_SLOT], extack); + if (ret) + goto table_free; + } + sch_tree_lock(sch); /* backup q->clg and q->loss_model */ old_clg = q->clg; -- 2.53.0