From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f52.google.com (mail-dl1-f52.google.com [74.125.82.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 637AC3A8725 for ; Sat, 28 Mar 2026 18:27:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774722439; cv=none; b=q1tSfealvHZfgjPMRSPRJAW6tIXRgyuXSwj7LBGqO33SVzDHrSo+N9VuAFhT0WGCunG+jW4NInrup4ZnzAEXjGTMPnRBcAJS+cIheWufFUgmO3v2OhJ+niFK5Cis84iZMf5ZGxS7I4atjSQUonEgI1fBD++66JBoxp2ltXNeyWo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774722439; c=relaxed/simple; bh=4E8Rh3OuNCsSvMlcjVPrrdMmqddynYyC/PcqgR+IY1k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jT+W7+155UlFUy69xyLjGKO7ryHRbP4D+aRz/iij86bLgrRsWeLbcF/wUkcJcVZG3S3GEWbC2vI7QdaEVbjoTbu5PSjQyfblmMZ7AdB2CKG13rlEYP2J3brQbsYSHoDRfQkIVjE/DXQXbqATj2rcMbIWguE22mk3Ljc7+A9p3F4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org; spf=pass smtp.mailfrom=networkplumber.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20230601.gappssmtp.com header.i=@networkplumber-org.20230601.gappssmtp.com header.b=o+3qh9Qv; arc=none smtp.client-ip=74.125.82.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20230601.gappssmtp.com header.i=@networkplumber-org.20230601.gappssmtp.com header.b="o+3qh9Qv" Received: by mail-dl1-f52.google.com with SMTP id a92af1059eb24-1279eced0b9so4605881c88.0 for ; Sat, 28 Mar 2026 11:27:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1774722435; x=1775327235; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cYPRUSIe18E54vjKGuGhcRXs1lIGpEBWxAwIKYxRS+4=; b=o+3qh9QvCKRKJ/VXXu1omUCNrPlB193CSfrHg6BnR7ItoFo7ehh6T7NeWOd0eEechz 9NmJahHstPqi/So4VA/t2JI2FCkvuTuWHqCUqEbeGp3Jp/Vnz4SiWTwFS+uOAIXg+Nhc mUyRAlD1msO5rheMAcKy8xQvg3zW/7okduF8PwMXAHZOX0iH2VYVMIsF0xHFHHMd3iT9 ORymrxm2V4QxacAitdvooPsN2H/9FySHhLz5vhShdQWdYzRO5zgQK45CdD61zxl7kqbr CZr9d4kccOuDrCrqEqjMwUuxJuJ4njn0p+x8IhBQyD9bzFWxfZQt04699jR/zMlatLf3 KFRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774722435; x=1775327235; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cYPRUSIe18E54vjKGuGhcRXs1lIGpEBWxAwIKYxRS+4=; b=JBkESXCumRJPl1C2eOHYnhdzOwiFuw1OQVAWYwWo14xF83jThBdOARL3xlYOxQ61PS l7zdpt1TttDvVVUfRfvbWvP5cer9KilgTuaqDL2MqGuYr7h9LxtigitBGT8IgA8eq6wf FVmb+nB96coR+OCR2BM5OkylLENuYeq0/xKfbsuGnM4ptrpPN8JY7QinuoefK+iBR9QU m36lDTzj2JaVHqofSs05wveboo5J15OPGaZ2lIL/HnuqOdf5+0BWk7PMZg9rXM9OJhpx lhJ9UBPZK2hUqtlpuXnmFN29ipAT6KSvE+oIHQR5IqxwB9WVuSdjjlovMLsgzJYnGjeM PRIQ== X-Forwarded-Encrypted: i=1; AJvYcCUFeWwnX58pR2cRMuWyKZDRSFElros2r+KSsT8ndeULIBBjN2G8GT3z+1xIdbk06v5Won1OropxTSR78h8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw0CkNZb+LTc2Po3gh1aW4Qdcd7xehBxg9xMJEHopyHug8U7bmA Ee2fFuxQwaodwQHnlyySaiQDPbbh3JoiA3Alby2YwhOkoNE6VbAKcOByArBpZe8YW8k= X-Gm-Gg: ATEYQzxGTLbqbhiv+sTGgWb8ed6NRbqrTQ0GcAW9b4ngcj6u21eTuAvxJq93oj1A9Ek 506pP4Gw3Lnd9eS012m9yZVishiBowvWqHUPEZIqPEAuT0PAvtFGvEv3Ie3TqxRUpWYC1wr3vqi GyiePqeso20VQ+Qm6lrFwrfl4En7cckrqOGIHIVn/m00wz8kNhi0mY8apDXRqjlVyDFoHvM8Pm0 9gpHecjp6OzVsKt/SA7VcyBUheYze0QRfqBaqnVQiAIpyEN0dEfKZ93tkEZeWnCWNjFfshluzDR BqWxH0IrInI0rbkmSWalkH7qVY0skXHq61ZjKsxEcn/a/2hi5gE8G1f/wz1miAr1Of2i/ZZT910 C2jDGWGoh/lzYmUUDhybjJqDZF4IWD1rRoTJXysqJ/SvCaPlrqDT9tIK4Gm+ETWlrmytJGYgBD+ 3IT1NrfT/evuUda0JlsvtexgxJTsvJCfeK X-Received: by 2002:a05:701a:c950:b0:12a:6a64:81f1 with SMTP id a92af1059eb24-12ab28389cemr3279086c88.5.1774722435485; Sat, 28 Mar 2026 11:27:15 -0700 (PDT) Received: from phoenix.lan ([104.202.29.139]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12ab97cb08csm3909263c88.3.2026.03.28.11.27.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Mar 2026 11:27:15 -0700 (PDT) From: Stephen Hemminger To: netdev@vger.kernel.org Cc: Stephen Hemminger , Jamal Hadi Salim , Jiri Pirko , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , linux-kernel@vger.kernel.org (open list) Subject: [PATCH net-next 6/6] net/sched: netem: add per-impairment extended statistics Date: Sat, 28 Mar 2026 11:26:07 -0700 Message-ID: <20260328182704.456993-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260328182704.456993-1-stephen@networkplumber.org> References: <20260328182704.456993-1-stephen@networkplumber.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit netem applies several impairments (delay, loss, corruption, duplication, reordering) but exposes no counters distinguishing which impairment affected a given packet. Add a struct tc_netem_xstats reported via TCA_STATS_APP so that userspace (tc -s qdisc show) can display per-impairment counters. Signed-off-by: Stephen Hemminger --- include/uapi/linux/pkt_sched.h | 9 +++++++++ net/sched/sch_netem.c | 27 ++++++++++++++++++++++++--- 2 files changed, 33 insertions(+), 3 deletions(-) diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/linux/pkt_sched.h index 66e8072f44df..fada10cb9b7b 100644 --- a/include/uapi/linux/pkt_sched.h +++ b/include/uapi/linux/pkt_sched.h @@ -569,6 +569,15 @@ struct tc_netem_gemodel { #define NETEM_DIST_SCALE 8192 #define NETEM_DIST_MAX 16384 +struct tc_netem_xstats { + __u32 delayed; /* packets delayed */ + __u32 dropped; /* packets dropped by loss model */ + __u32 corrupted; /* packets with bit errors injected */ + __u32 duplicated; /* duplicate packets generated */ + __u32 reordered; /* packets sent out of order */ + __u32 ecn_marked; /* packets ECN CE-marked (not dropped)*/ +}; + /* DRR */ enum { diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c index 26fc68e34b91..755e8d009f85 100644 --- a/net/sched/sch_netem.c +++ b/net/sched/sch_netem.c @@ -152,6 +152,9 @@ struct netem_sched_data { } slot; struct disttable *slot_dist; + + /* Per-impairment counters */ + struct tc_netem_xstats xstats; }; /* Time stamp put into socket buffer control block @@ -459,17 +462,22 @@ static int netem_enqueue(struct sk_buff *skb, struct Qdisc *sch, skb->prev = NULL; /* Random duplication */ - if (q->duplicate && q->duplicate >= get_crandom(&q->dup_cor, &q->prng)) + if (q->duplicate && q->duplicate >= get_crandom(&q->dup_cor, &q->prng)) { ++count; + q->xstats.duplicated++; + } /* Drop packet? */ if (loss_event(q)) { - if (q->ecn && INET_ECN_set_ce(skb)) + if (q->ecn && INET_ECN_set_ce(skb)) { qdisc_qstats_drop(sch); /* mark packet */ - else + q->xstats.ecn_marked++; + } else { --count; + } } if (count == 0) { + q->xstats.dropped++; qdisc_qstats_drop(sch); __qdisc_drop(skb, to_free); return NET_XMIT_SUCCESS | __NET_XMIT_BYPASS; @@ -495,6 +503,7 @@ static int netem_enqueue(struct sk_buff *skb, struct Qdisc *sch, * do it now in software before we mangle it. */ if (q->corrupt && q->corrupt >= get_crandom(&q->corrupt_cor, &q->prng)) { + q->xstats.corrupted++; if (skb_is_gso(skb)) { skb = netem_segment(skb, sch, to_free); if (!skb) @@ -597,6 +606,9 @@ static int netem_enqueue(struct sk_buff *skb, struct Qdisc *sch, delay += packet_time_ns(qdisc_pkt_len(skb), q); } + if (delay > 0) + q->xstats.delayed++; + cb->time_to_send = now + delay; ++q->counter; tfifo_enqueue(skb, sch); @@ -605,6 +617,7 @@ static int netem_enqueue(struct sk_buff *skb, struct Qdisc *sch, * Do re-ordering by putting one out of N packets at the front * of the queue. */ + q->xstats.reordered++; cb->time_to_send = ktime_get_ns(); q->counter = 0; @@ -1311,6 +1324,13 @@ static int netem_dump(struct Qdisc *sch, struct sk_buff *skb) return -1; } +static int netem_dump_stats(struct Qdisc *sch, struct gnet_dump *d) +{ + struct netem_sched_data *q = qdisc_priv(sch); + + return gnet_stats_copy_app(d, &q->xstats, sizeof(q->xstats)); +} + static int netem_dump_class(struct Qdisc *sch, unsigned long cl, struct sk_buff *skb, struct tcmsg *tcm) { @@ -1373,6 +1393,7 @@ static struct Qdisc_ops netem_qdisc_ops __read_mostly = { .destroy = netem_destroy, .change = netem_change, .dump = netem_dump, + .dump_stats = netem_dump_stats, .owner = THIS_MODULE, }; MODULE_ALIAS_NET_SCH("netem"); -- 2.53.0