From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f180.google.com (mail-dy1-f180.google.com [74.125.82.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A246130F92D for ; Sun, 29 Mar 2026 22:47:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774824434; cv=none; b=LRTEhq6n9fZLsI40Vano3vZVa/aiKVOqeNTWtcPyaMxK1dTF8tNU7UTMRHfwvSeSzB8ncIqyYFGAN15PoG33vyDxM9Bli7Dfg+Gac4hqA0SM5HoYLCDw3jlko6bC650E6A5Pmo+kmVyS8kbFFXrLN2Sl6DqbUttYK+RzHCP3leY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774824434; c=relaxed/simple; bh=zq6gDkkgz0EgiEfb/l1u6tCsi5Cu5yaY3sZxVmtTF4w=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=VP7/RI7pZLlTA+RtvKj0L+UE3n6Z02kHWlnHjMNEu4eS7WYsudj8IAVOWfe02ZezroIdZ56QiD4tTduCoAteGCesCefnKx6M+ENVGserIwkVo4tzQxEwiNwltI2Iy0gVasOKN+mMRZF4zMkT+z0w//LEhjBFl/iygP5vn/cV5wA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AE+WXEZC; arc=none smtp.client-ip=74.125.82.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AE+WXEZC" Received: by mail-dy1-f180.google.com with SMTP id 5a478bee46e88-2c54c68db4dso1391203eec.0 for ; Sun, 29 Mar 2026 15:47:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774824432; x=1775429232; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=ApS/GEmTLQev4aIUqsAr4eNKyPgGdrlmvrkZf5VLHGY=; b=AE+WXEZCBEzTTwAv1tNdXveSUCCiNmIJBuYJiSBEKSfmWtq34Ncix7QQw+9WI4FH+S rlJgvXaZEc0NmiPRN1+4OAvh+aDWt81Ht8HQrGQPjSMaEulstGilJGqyJOdFlZvlw+ja zhtlFFeDZkcTH0mHsffUBHPPHEQvc0eElji+12Ayo3bApRMvHeagWVlQ2cuGAxMk38Fi OpSLTCrjqsNlzHp5K9hpinNa5x2mC002O2TcTioijI1XLGAqmNyGv+V2044FuC5XJNIP ZdUgt1BPKglqWG7q73gnkJuWWiwsa5qDdUDv3c7iGfSQ95G/dYMuLfE3cH2lHEcrBglg Gbqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774824432; x=1775429232; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ApS/GEmTLQev4aIUqsAr4eNKyPgGdrlmvrkZf5VLHGY=; b=riB9q5OKAq5fGO2tFF7i5w8eV2J0NHIUbEqIyMByPlv8WRXbAMt9dKfCktEyWHc2bg QauKDnu3+D5JBYwB/SQWVsri39Rbs0hlaq/0584KP1u1z06+g1qokjtiCIwEaOELQShk PdMYJng3l51rqf1GwjjKhBgRRgcuutggsmqxJOOaJypw1+A6Gp7BYeBNh4nku0SPUnST QWgwyGfz3M2FFgN0/FxluKDYbMzZ8W5cxTuNBeEbZuvAtW1+azB6YNRLbxabmh/Q5nEU iRzbsYewMUIkX1pLaZ7P1PRcXJo6FOIgx2nQhrI1QAMQbUJhlyf1VID3Iwsz+JA7d6cW meyQ== X-Forwarded-Encrypted: i=1; AJvYcCUvt7h/unjyb0Z8nYe+kg69iXvOVp6AqU05Gr2GdLbKd/rj3KdQ2KeNJ8QWGgburmPnfXNumk/x8FxlA34=@vger.kernel.org X-Gm-Message-State: AOJu0YwC2S0tmEdt6PfcQqpsOIKvSO5Jhld9xCbfu5eN9MGd+C52VvOs tFdNK1opVoFMVYabL+e/2k7PGlFXUrZZhZVaWxIsbgrQkT0W5zucAhCz X-Gm-Gg: ATEYQzxnBFqQRIMLQOm2XVYiSO5gqXUe4aN2hG9zkBvDidlI4j0VSiJZoX+78oR+1iI XzN6GCje1xdoQbRG6sTQz4zbBz8vQfKOvWSdTQciCj/J6809hhYQzpztLA9CKGRJsTsvflZeFZd bhKiGb897z4Eka2/UsU07S6A/E9Im5p8hf+0hBIXtaHJ6RYAFxdt75m/FAEASgNX7V6SjKrgwOu gFAHAy/cGc1JK+vkJ9N7PQehV55QGUcLjp2DNqney4GTRnU+eWCD/aUGaQMux5ONLjqUp1ILfHv AXPNn4y2l/uRhmRKazfxzjZ7gSeKVygCDUy7d3fBilNJgqLrECDi7B7dAuA/53hbQzzBym6vWlO H2n8F8DGAZDU7RwaFowZIZkCMt1Uy3dhwMnv2lMEkdcpRebgvfbprhWC6P0zgMsml5os+Xleaze p4xYWv9eGib1BIX5TTTarZbMnJpWfSBis/hyvynvUCmjks1C+9sxy3aahqYBAPmGf+ZGN7RmTUJ LeIcnYRR4elJvo= X-Received: by 2002:a05:7300:6d22:b0:2b7:32a6:82d1 with SMTP id 5a478bee46e88-2c185df79edmr5833234eec.13.1774824431654; Sun, 29 Mar 2026 15:47:11 -0700 (PDT) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:7265:773a:8e51:c62f]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c3c7971d97sm5840295eec.30.2026.03.29.15.47.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Mar 2026 15:47:11 -0700 (PDT) From: Dmitry Torokhov Subject: [PATCH v4 0/4] ti-ads7950: fix gpio handling and facelift Date: Sun, 29 Mar 2026 15:47:05 -0700 Message-Id: <20260329-ti-ads7950-facelift-v4-0-c568c508c49a@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAOmryWkC/23OQQ6CMBAF0KuYrh0ytFSoK+9hXFTaykSwpm2Ih HB3C25YuPwz+S9/ZtEGspGdDzMLdqRI/pVDdTywttOvhwUyOTOO/IScIyQCbWKtJILTre3JpXx o7lIo1CdZsdx8B+vos6nXW84u+AFSF6zeWaXKnuKqEFI22JRQghkohalIPvhn58fLY9DUF60fV rSjmB/TtnQUK/2DBMq/o0YBCJoLZ0ypsVZ2x92WZfkC2NJDtPsAAAA= X-Change-ID: 20260220-ti-ads7950-facelift-ad8b5390a654 To: Jonathan Cameron , David Lechner Cc: =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Linus Walleij , Bartosz Golaszewski , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Jonathan Cameron X-Mailer: b4 0.15-dev-a6826 The original reason for this series is to make sure ti_ads7950_get() returns result in range [0, 1] or a negative error code to comply with gpiolib requirement. During review David noticed the fact that the function also clobbers gpio state. Fixing that lead to adding cleanups using guard() and devm. --- Changes in v4: - rebased on top of latest next - dropped the 2 already applied patches - restored inadvertently removed mutex_init() (Andy) - stopped calling devm_regulator_get_enable_read_voltage() on ACPI systems as it is guaranteed to fail (David, Jonathan) - removed call to spi_set_drvdata() since it is not needed anymore (David) - Link to v3: https://patch.msgid.link/20260305-ti-ads7950-facelift-v3-0-a23fdd1a079e@gmail.com Changes in v3: - Added "Fixes" tags - Picked up reviewed-by tags for #1 and #2 - Dropped the conversion to "error" variables - Avoid using scoped_guard (per David) - directly return results of function calls at the end of function (David) - Split spi_sync() error handling into a new patxch (Andy) - Switch to using devm_regulator_get_enable_read_voltage() (David) Changes in v2: - style fixes in #1 (per David) - fix to not clobber state (#2, new) - #3 and #4 (new) --- Dmitry Torokhov (4): iio: adc: ti-ads7950: switch to using guard() notation iio: adc: ti-ads7950: simplify check for spi_setup() failures iio: adc: ti-ads7950: switch to using devm_regulator_get_enable_read_voltage() iio: adc: ti-ads7950: complete conversion to using managed resources drivers/iio/adc/ti-ads7950.c | 195 ++++++++++++++----------------------------- 1 file changed, 62 insertions(+), 133 deletions(-) --- base-commit: 3b058d1aeeeff27a7289529c4944291613b364e9 change-id: 20260220-ti-ads7950-facelift-ad8b5390a654 Thanks. -- Dmitry