From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F00323958D for ; Sun, 29 Mar 2026 06:43:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.67 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774766632; cv=none; b=iJlhlyVotVPB3d+lNWS8rtXBiR87XfUDNYiKSHqWZ0Kj2rRAZEVhgh5BrAZV6VgvMV4BTlz1m01xMutxafwDod+Zn56/WDzEgqvr6/Hq/bocINM4NtTCcM+oS6NOUO9/hEEUgbeCYKdt2IwV9AnIF48buOIgjJaetGjveAbHwOQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774766632; c=relaxed/simple; bh=YI7zBwABcyr6p7wx0NC7aVRMBoJG+jtEk4RwQYsug9c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JT6F5Ve8iLfekHKByxoE/ROD+AeBdN21tSHEXlKMKlcyHdwF6cILBI2nUU8Gzt48AYAIsU5hudIZJKXKvHiphB8w3D+O3rvEcPII2Q87fIYV0uKIZfDE7LQNSfHho4HF/hUxj84dtsqEhVdy3isgz1OxssMYM6xLFNUpODhHQBo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P8d7XFKI; arc=none smtp.client-ip=209.85.221.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P8d7XFKI" Received: by mail-wr1-f67.google.com with SMTP id ffacd0b85a97d-439d8dc4ae4so3381484f8f.2 for ; Sat, 28 Mar 2026 23:43:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774766628; x=1775371428; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gimlAGZky6Wgy52EhlGdMoyap1XIsWTkf1RMAPCDnG0=; b=P8d7XFKI98jUCuGcGn86s1Tppwzh42NKKdd2y3sNHUS+EmeZngGLYm+unTmjS9vfkj SERi9Ee1+zPzVBW4USeD2KqnL/HgA/LR7DpZzYmpVIaUn5HxYFtUYiFh50CCr1+hU3US f6G74UNjVtuM1pOId9n38SbeWXqnSyQEMXINzZbEetCt+Q3AKzlIWArdheyGGPyBTGeF DzaRWsi4B3LeS9PwCFCUHmxUn7x5PYvavcmK326cbFX2yIxkgvmC7GYPY0uWaYyzKe4q 1O8mW4his22lrSnVB9HH7cpWsuJc81nW/b8KXGV30hEBSwxQk7hjDbnKWLc6crO1IzoO Z8NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774766628; x=1775371428; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gimlAGZky6Wgy52EhlGdMoyap1XIsWTkf1RMAPCDnG0=; b=Asx5ffHl5tJsvv3ZoOA1pL5cTsBWu5h2NUm9LPWA3AwBATqMN88G30UQkZjq7/HyHy m3OMoLc8aWpxbIAg4860uOYiM3xQVqopG09D43+rm/F/m63wQ7BoVfIQylTSm4YQg0qf l6EXg4+4KpyFKXQbzY1mV+ZcmnLGlCEu9t93qqp3kSHCT0MLbEenqQIheJbXyVh5aYVL 3Acfs6QwOwS/fheslQW8mgSIR+16jiJro8NIPZT5CxmrAqsA4dFnXaNj95Ao0CElT9AK HUtl6XFV3te548IbjUC0lJv0tdl+65a7UdJUTVTUdu4gE8SgVygWxFe16Wop4lffkjYH CHfg== X-Forwarded-Encrypted: i=1; AJvYcCWdGne5xy1v+jjP+XYYJu0vGLVzrAtQv5p90ZggPhITSSreXnRgnE3N4lxlcnQ7KINGNgX3OlTltnUdR+U=@vger.kernel.org X-Gm-Message-State: AOJu0YwNfkXYJW7cgnww5gF0B+ACPmNWQ4Z7w7I/UMcMZAjyH1HMkbaY vJR7ujblQm57OD9glc7FvcEya93aTRY5wphp8iCvw2S6bYmTMi/j0Day X-Gm-Gg: ATEYQzxtOYCHzM6lIqCvxqI08J7t3mZn4O9DVINt0BetMkih7NbQywp8MdSMczFiT5f sb58lkfLnUrJencMkP63LPeORCeUSmXL555OofFpMJo2nJKW6KxK0jvz4hg4uBCGYNoBSSGQ7QU mptuMpWMgQR5XGNNIW5J61QdbMTZMvzoEOR35ZT1vw6pR8Mh6DfpzPlnSQnr1MA7yjZR/LKtyYv sUtU7Zp775u8IjsQa2moYPXVkp+fVrKrg5QpXzH94ldcFF8cN8PmYTGvvjWX5SdwP19PxT0OgOH W+3wUng4hruuE2F5SPAabmRFAxps3qXTkMtAkDKxbDALJOex1t7ZAsT5rC68+SHb00oyvKPDvv9 epgPsmeuVSRgng90+oW34juAHsTv9bZuOlFXY2vZ31VSDG9ea3+FCvb+ihrxMHnV/yfwLHZl0AI MxvbwESDxkqRmtosqUW0YidU9xJy7+cNk= X-Received: by 2002:a05:6000:1ac8:b0:439:d755:a895 with SMTP id ffacd0b85a97d-43b9ea085c5mr12969253f8f.42.1774766627633; Sat, 28 Mar 2026 23:43:47 -0700 (PDT) Received: from bera-arch ([2a02:ff0:c13:2eeb:2e7c:3a4f:2bc2:f78a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43cf24739easm9959636f8f.30.2026.03.28.23.43.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Mar 2026 23:43:47 -0700 (PDT) From: =?UTF-8?q?Bera=20Y=C3=BCzl=C3=BC?= To: david@cardinalsystem.net Cc: andriy.shevchenko@linux.intel.com, dan.carpenter@linaro.org, ethantidmore06@gmail.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, straube.linux@gmail.com Subject: Re: [PATCH] staging: rtl8723bs: rename variables to snake_case Date: Sun, 29 Mar 2026 09:43:34 +0300 Message-ID: <20260329064334.13617-1-b9788213@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260327203636.24891-1-david@cardinalsystem.net> References: <20260327203636.24891-1-david@cardinalsystem.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit on Fri, 27 Mar 2026 16:36:36 -0400, David Holland wrote: > From: David Holland You don't need that. > The Linux kernel coding style guidelines prohibit the use of CamelCase > variable names. All variables should be snakecase. > > Rename the 'ChipVersion' parameter to 'chip_version' and the > 'AutoLoadFail' parameter to 'auto_load_fail' in hal_com.c to adhere to > the standard snakecase naming convention. > > Signed-off-by: David Holland > --- > > Hey everyone, > > This is my first attempt at submitting a patch into the Linux kernel. I always wanted to try to get my own patch submitted into the kernel so I was scrolling through the codebase and found some incorrect naming styles. I corrected the variables name that were using camelCase to use the traditional snakecase. > > Thanks for reviewing, > David Wrap your lines, please. Thanks, Bera