From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93C0430C354 for ; Sun, 29 Mar 2026 11:44:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774784666; cv=none; b=NmOEIkrilpN6BhiiQPOEGQSV/15nI37YBIx/MCLekEHLfazdjEM0obUJM7e0s1UhPLc3HH4yHIUUdJ32wRwwmOB9Di3TDO7ZpDYKDjDRDfsgqA+itzYe2lvlMzoFh4srCNAnBYKxLjvEE/jTMqmNKcyphf4ETKIscQDD5ZCW5qY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774784666; c=relaxed/simple; bh=lkgcc4CtMjk1bN0zjQdR/f0eplRuaa0CikSDA4RfA5I=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=RX3XGzRON0YE7Ap+0ON9YqeMJqOymctXkzfBYYuJibaICilSoBJDJiLOQEwVyNiUsd6qxfv7XG0hoEel1u5xsmYJFvky6j/j+DDzc/f5Poka/VQN/3lxO9e9NCaeDNOX+k42B5nG4ruUpFtfQXFEW6cK17bacr2P1Llj0ZXEn88= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CQsnvooy; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CQsnvooy" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-35da1af3e10so377577a91.3 for ; Sun, 29 Mar 2026 04:44:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774784665; x=1775389465; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1Csdueb260dLL4KAw0AfvdDf024yqqfeIAyjh7nn3RU=; b=CQsnvooyVvdj1lBdLYf1RpdQPoEDFnaMmYDJwJyeeg1KqjRiX/BH5SAw8429LCwAZ/ Si4UZkNacNLnbONHZ9sBRDXW/w9oFOWo2W0oiUqwCNjdG5z2vKqnnCVPhHFPDCgfztrK N3wGXPVelRai4YV8RZczfTe+o6wwyFJQffGNXN0wmRtXXVzZVmEey7RNLXt85l/fghlK iaQbN9n7E3fZjndGun7AyvOJNEi9E5AOrsnWylPkzsprnnTumvACX6jj+qYzx5YqzEjH sA9jwwGTWB2XaMDQ3oPTqXpvo+PPam0PRv+O/MuEjCUyuPzZCRx2X97I/rYDTkffxwWd Mltg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774784665; x=1775389465; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1Csdueb260dLL4KAw0AfvdDf024yqqfeIAyjh7nn3RU=; b=rRTUEBtIo/LXiDef6dckJCny04p4UUD48Ugvc6/mBHWn6HpfQW7wMaSsvdRr7zMNW1 O9lQVF/fxDuFjNOAavUsA2BEfVN8z4GZQlqbOjf4njonwgarpDhjjEA3dsFHB996ahzV y6CmzvH/jk+aJ/L3INRjLj/i8fp6Le723T+R1SWIw+q6HGOT1ZFEfZzPiQOAcJ7Uyuch SNS/HiBM3fWaNjbW8068o2rSYq9qMN5w/Dhg+c22cbqkckepoXVZLDHufxuYIC5GzKRC bs1ilbonrdK/zE1lXih82TTcVekNJqfQOKib+DqK1Yqpt7JSmfnWYm2FS8muYaTAFwJV BNVg== X-Forwarded-Encrypted: i=1; AJvYcCV/htSOL0i0SpMCnWrOWRlizOUu+EKS2Av/twWqp6VyycM0ZxvGCvWCY8yGzFSJ1RU/e58p5DfY1o/8rTU=@vger.kernel.org X-Gm-Message-State: AOJu0YxSy7eGhCJB6J8mVxq462/PWXvJL+9tHg8/LeBLBxoZLA596hUd RbOMWaDicZtObOdx4OsKxqTkiafHq9a+Hokbf8Doen9DLdArcLG1cJVK X-Gm-Gg: ATEYQzxOdJ10z0W9HiLfQJiZ32X7vlONKlRr4UpP5Ovwgiq2ltES04b44nspBVJ8/3m r4RRtZS75TjMRATmqfVcJHWpURhTQfAndfEZVRrwqtjmkdmxvm8mfiW0fgUNcnbYDQHdr38del8 Pg+Gk8xbRKonHZvTMJ3f3NUy0zxFOMgWJixXmNRaWEZV/TMnTGGS8GLdk2bAleMRDgL5aYTFk20 kMZjddd+hx9GciaJICfkJaxU4G1YY0f7XZBMvBWtz+ZJUzGmv38kL39cDbEM38FN3q4T3omVrJ7 gLyOxfX9W7mdCIcow01f1HtthYqeXnkY/41nig+208OV9pKrcFFNS7GyZOXvHc6bFMLK7mOMTf3 vkazNQMo/IjJ2XJtqlTal6lSqKBqi8nVvTlXAueHyhMKwiIIrZSGNpZGS2C75iFfeQ4roE/5AqN FXMUGS8yVAx9tHqU73gw/0MQhSiuBI+T/OOOO1bmGxNV/9ZX/TNbcWSEwXNHCprVwDOvYEoMFGs 1Hz0Q== X-Received: by 2002:a17:90b:1e51:b0:35b:e4f8:7b3c with SMTP id 98e67ed59e1d1-35c2fffe870mr8867503a91.11.1774784664489; Sun, 29 Mar 2026 04:44:24 -0700 (PDT) Received: from localhost.localdomain ([188.253.126.221]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c2d7df071sm3174591a91.0.2026.03.29.04.44.20 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 29 Mar 2026 04:44:23 -0700 (PDT) From: Barry Song <21cnbao@gmail.com> To: lkp@intel.com Cc: 21cnbao@gmail.com, akpm@linux-foundation.org, baohua@kernel.org, bhe@redhat.com, chrisl@kernel.org, kasong@tencent.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, llvm@lists.linux.dev, nphamcs@gmail.com, oe-kbuild-all@lists.linux.dev, shikemeng@huaweicloud.com, youngjun.park@lge.com Subject: Re: [PATCH v2 2/3] mm/swap: use swap_ops to register swap device's methods Date: Sun, 29 Mar 2026 19:44:18 +0800 Message-Id: <20260329114418.39732-1-21cnbao@gmail.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) In-Reply-To: <202603291844.TWh2Ellp-lkp@intel.com> References: <202603291844.TWh2Ellp-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On Sun, Mar 29, 2026 at 6:49 PM kernel test robot wrote: > > Hi Barry, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on akpm-mm/mm-everything] > > url: https://github.com/intel-lab-lkp/linux/commits/Barry-Song/mm-swap-rename-mm-page_io-c-to-mm-swap_io-c/20260328-170852 > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > patch link: https://lore.kernel.org/r/20260328075812.11060-3-21cnbao%40gmail.com > patch subject: [PATCH v2 2/3] mm/swap: use swap_ops to register swap device's methods > config: arm-randconfig-001-20260329 (https://download.01.org/0day-ci/archive/20260329/202603291844.TWh2Ellp-lkp@intel.com/config) > compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project 054e11d1a17e5ba88bb1a8ef32fad3346e80b186) > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260329/202603291844.TWh2Ellp-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202603291844.TWh2Ellp-lkp@intel.com/ > > All errors (new ones prefixed by >>): > > >> mm/zswap.c:1057:19: error: use of undeclared identifier 'sis'; did you mean 'si'? > 1057 | VM_WARN_ON_ONCE(!sis->ops || !sis->ops->write_folio); > | ^~~ > | si > include/linux/mmdebug.h:133:52: note: expanded from macro 'VM_WARN_ON_ONCE' > 133 | #define VM_WARN_ON_ONCE(cond) BUILD_BUG_ON_INVALID(cond) > | ^~~~ > include/linux/build_bug.h:30:63: note: expanded from macro 'BUILD_BUG_ON_INVALID' > 30 | #define BUILD_BUG_ON_INVALID(e) ((void)(sizeof((__force long)(e)))) > | ^ > mm/zswap.c:995:27: note: 'si' declared here > 995 | struct swap_info_struct *si; > | ^ > mm/zswap.c:1057:32: error: use of undeclared identifier 'sis'; did you mean 'si'? > 1057 | VM_WARN_ON_ONCE(!sis->ops || !sis->ops->write_folio); > | ^~~ > | si Deeply sorry for the last-minute edit—I fat-fingered it. It should be si, not sis. My sincere apologies. diff --git a/mm/zswap.c b/mm/zswap.c index 9bacb1733e1c..b60821758169 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -1054,7 +1054,7 @@ static int zswap_writeback_entry(struct zswap_entry *entry, folio_set_reclaim(folio); /* start writeback */ - VM_WARN_ON_ONCE(!sis->ops || !sis->ops->write_folio); + VM_WARN_ON_ONCE(!si->ops || !si->ops->write_folio); si->ops->write_folio(si, folio, NULL); out: -- Best Regards Barry