From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4919828DC4 for ; Mon, 30 Mar 2026 04:30:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774845039; cv=none; b=tTGpVN+g0lrWA1QH2+j4xGXxw9QpXNJ9nM3vNxcZfJ406GeiASBC00KndSZjGT+9HjblbtaqHmojitLAh/HJEtCmaBwl7ty5qhzoKW3YoZCgjPChFxF1zi0+GJJc5VxWXlK9pdJukkswBfOwRzg5Oi1Azlpwl1APd+8eu7cpUzk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774845039; c=relaxed/simple; bh=NaFJBlUCWU73wJliXZXVkq5akWfV7+VV4lYKTHL4590=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=GhauKZKSSQIhNcq6l94XBaOVhw+UvkVhqkQzGQrmYNxaT9LJIgCFrVXBZH/2hyLNdc1zFkCb5hKOP0/LDWlyVj7bH5zh8nHQednKZMFSkvoOOhZSm/k4HGbs4ICPNkN2JAMnwR9RXb+wtqoeNPzgO2EnOck8I/amuDEt2JqNILw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZZ4L/m46; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZvPebFlk; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZZ4L/m46"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZvPebFlk" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774845037; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BFa0uOm6NkLHVmG4oyhTKy9ydelbQancYIK5yzqzRE0=; b=ZZ4L/m46FaWtnPt9y6I70XZq62LjD4xGAJuXxUH9w4gavCuZy3ShtjpRNq9LH7WgHfuFvg 6kRFj7rEuYB2dnW94LoDdu98sANpb+BfwI5LK2hGPOWIeSOrEnGMwGZcbPMbfcxrWNPjyS lngyMgvi6RMlneC0MS9nFikmk3fhXwQ= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-683-K19tzLJDMTSwQyVmXsfrJQ-1; Mon, 30 Mar 2026 00:30:35 -0400 X-MC-Unique: K19tzLJDMTSwQyVmXsfrJQ-1 X-Mimecast-MFC-AGG-ID: K19tzLJDMTSwQyVmXsfrJQ_1774845034 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-38a7fe9b5deso22094991fa.0 for ; Sun, 29 Mar 2026 21:30:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1774845034; x=1775449834; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=BFa0uOm6NkLHVmG4oyhTKy9ydelbQancYIK5yzqzRE0=; b=ZvPebFlk23BXixNE6eqe1F2RiQ5XxwU9nUvrPRD8vdvUqoOhXsTzOWkXR1W8BB1c6i nQuQfQKH3lymtwDwo2jsbx1gH9KiXuG4X8rRv206Q0jdWi/MDESn/850jW5phrNq3Plh P2dV+eZm2DSkSMM/VO6ChX5lbCbQ0uM7kkd9+SwDXo/eww8yHLB8uReR+7m3EyUPK8iZ 29uWKnezYHQriEohIqFMgX7RNhEn4+rXsFvQuIdKOGovF4oUZADvGV3NTsAlEsQEuOHe +CWWCXjutErcFvOO0e2uNsrYRMxWJRjW5zjpv5xU27dcBIvTBHnCR29SWXL37V1wSmQZ XrwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774845034; x=1775449834; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BFa0uOm6NkLHVmG4oyhTKy9ydelbQancYIK5yzqzRE0=; b=tF1zh7j7s19hCg/1jskJmoXr5IcJI+9d2wQStQ3f+V8+HoupcmAm3uxqjNCHuEdWTN fDyHegb9eCLXOl6bL2Jjq7wMaFbezbi+PWqJh8jlgLTIklfgMcCbJFZ8zMs77VapdLlf LdlRBbfpGgQoJ3wIyHS3cu9q7Z+lqByUQQTolY2EjIiyVy9X3Fu5KUoOLxUP1U8OCPE8 WE82vRij5yM0ftI11gJJmrh2oy4vWfqjmq9WRkr7V/ddx7+XUPFupM8QYwGMjasOWwFl whWa1RvOrptP1gue/33wGwKvH4sa4Dhgg7BXhiv9qDSxAZFRTHky6iuUB54V6PmbrYPx qeQw== X-Gm-Message-State: AOJu0YzWNIe9rzUvHlpk5HEHz1paGOX4zeaFaVMI7fXJNafDa25jTdUr 9ZIONABRQYvhGWoDGW1o4O3oDMHRAROZbk0Fj1N34GfMOBG5CHSCVlONDYsF2BDpTS1skdAofZD ZVAg1tklwzjaL2qEwKiII0kROJ0tvNbCKsPb0+FkrjM4hk6ABGD1WXHTPVWB3Db65 X-Gm-Gg: ATEYQzxhj/DyCO4tf/VedlRelPv/Mj+7g4+4JJrkL9eNtR+4XKYe54uMlXqz/ISu4cz c+7Qjsp8Iupybf/gMjs8IhQ5rdzwstK/wu2l9URx3w+f8qsu6NkXNfKirF/vQ0Df07XKpJpCMFD WQo7v1p+yGX59f0ofe76Q7D6Lzwd8KFt9xgp1rZL0F0JR1lxosHxHJ8IOs0sthsA+IppMU7Xb3v wtvD1UJBSVwowd8wVXZ1C62+PVzXbQuf6z56xUGhSnKrYfu2SFwVuNqyalGYUt37jHdg+Z74VB5 wzPvFzr5Dnp6T8rXg4l7Qh7bZ3sdePGgCbbxHXrBvcNKu3p3FjNv7kN60TeZa0jVVwzWSGiN2xR HApBZVEWZ8aHOjASpi7zdkaA566MOU7s1cmwq X-Received: by 2002:a05:651c:20cc:10b0:387:e49:cd1d with SMTP id 38308e7fff4ca-38c73248256mr23885981fa.15.1774845033787; Sun, 29 Mar 2026 21:30:33 -0700 (PDT) X-Received: by 2002:a05:651c:20cc:10b0:387:e49:cd1d with SMTP id 38308e7fff4ca-38c73248256mr23885891fa.15.1774845033211; Sun, 29 Mar 2026 21:30:33 -0700 (PDT) Received: from fedora (85-23-51-1.bb.dnainternet.fi. [85.23.51.1]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38c83729522sm12470671fa.14.2026.03.29.21.30.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Mar 2026 21:30:32 -0700 (PDT) From: mpenttil@redhat.com To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, =?UTF-8?q?Mika=20Penttil=C3=A4?= Subject: [PATCH v7 0/6] Migrate on fault for device pages Date: Mon, 30 Mar 2026 07:30:11 +0300 Message-ID: <20260330043017.251808-1-mpenttil@redhat.com> X-Mailer: git-send-email 2.50.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Mika Penttilä Currently, the way device page faulting and migration works is not optimal, if you want to do both fault handling and migration at once. Being able to migrate not present pages (or pages mapped with incorrect permissions, eg. COW) to the GPU requires doing either of the following sequences: 1. hmm_range_fault() - fault in non-present pages with correct permissions, etc. 2. migrate_vma_*() - migrate the pages Or: 1. migrate_vma_*() - migrate present pages 2. If non-present pages detected by migrate_vma_*(): a) call hmm_range_fault() to fault pages in b) call migrate_vma_*() again to migrate now present pages The problem with the first sequence is that you always have to do two page walks even when most of the time the pages are present or zero page mappings so the common case takes a performance hit. The second sequence is better for the common case, but far worse if pages aren't present because now you have to walk the page tables three times (once to find the page is not present, once so hmm_range_fault() can find a non-present page to fault in and once again to setup the migration). It is also tricky to code correctly. One page table walk could costs over 1000 cpu cycles on X86-64, which is a significant hit. We should be able to walk the page table once, faulting pages in as required and replacing them with migration entries if requested. Add a new flag to HMM APIs, HMM_PFN_REQ_MIGRATE, which tells to prepare for migration also during fault handling. Also, for the migrate_vma_setup() call paths, a flag, MIGRATE_VMA_FAULT, is added to tell to add fault handling to migrate. One extra benefit of migrating with hmm_range_fault() path is the migrate_vma.vma gets populated, so no need to retrieve that separataly. Tested in X86-64 VM with HMM test device, passing the selftests. For performance, the migrate throughput tests from the selftests show similar numbers (within error margin) as unmodified kernel. Tested also rebased on the "Remove device private pages from physical address space" series: https://lore.kernel.org/linux-mm/20260130111050.53670-1-jniethe@nvidia.com/ plus a small patch to adjust with no problems. Changes v6-v7 - rebase on 7.0.0-rc6 - added documentation and comments - denote to be migrated zero page as HMM_PFN_MIGRATE alone - got rid of HMM_PFN_INOUT_FLAGS movement in patch 2 - picked up Acked-By from David for patch 1 Changes v5-v6 - rebase on 7.0.0-rc4 - use range based TLB flushing while unmapping ptes - gate migration behind HMM_PFN_REQ_MIGRATE for fault and migrate paths - always infer migration flags from migrate->flags only Changes v4-v5 - rebase on 6.19 - fixed David's email address - fixed link issue without CONFIG_TRANSPARENT_HUGEPAGE - refactored into smaller commits - added more comments to code Changes v3-v4: - rebase on 6.19-rc8 - fixed issues found by kernel test robot with random configs - fixed typos Changes v2-v3: - rebase on 6.19-rc7 - fixed issues found by kernel test robot - fixed smatch issues reported by Dan Carpenter - fixes to lock handling (pmd/pte) on errors - added assertions for pmd/pte lock states - other issues discovered by Matthew, thanks! Changes v1-v2: - rebase on 6.19-rc6 - fixed issues found by kernel test robot - fixed locking (pmd/ptl) to cover handle_ and prepare_ regions parts if migrating - other issues discovered by Matthew, thanks! Changes RFC-v1: - rebase on 6.19-rc5 - adjust for the device THP - changes from feedback Revisions: - RFC https://lore.kernel.org/linux-mm/20250814072045.3637192-1-mpenttil@redhat.com/ - v1: https://lore.kernel.org/all/20260114091923.3950465-1-mpenttil@redhat.com/ - v2: https://lore.kernel.org/all/20260119112502.645059-1-mpenttil@redhat.com/ - v3: https://lore.kernel.org/all/20260126111939.1332983-2-mpenttil@redhat.com/ - v4: https://lore.kernel.org/all/20260202112622.2104213-1-mpenttil@redhat.com/ - v5: https://lore.kernel.org/linux-mm/20260211081301.2940672-1-mpenttil@redhat.com/ - v6: https://lore.kernel.org/linux-mm/20260316062407.3354636-1-mpenttil@redhat.com/ Mika Penttilä (6): mm:/Kconfig changes for migrate on fault for device pages mm: Add helper to convert HMM pfn to migrate pfn mm/hmm: do the plumbing for HMM to participate in migration mm: setup device page migration in HMM pagewalk mm: add new testcase for the migrate on fault case mm:/migrate_device.c: remove migrate_vma_collect_*() include/linux/hmm.h | 18 +- include/linux/migrate.h | 25 +- lib/test_hmm.c | 101 ++- lib/test_hmm_uapi.h | 19 +- mm/Kconfig | 2 + mm/hmm.c | 821 +++++++++++++++++++++++-- mm/migrate_device.c | 591 +++--------------- tools/testing/selftests/mm/hmm-tests.c | 54 ++ 8 files changed, 1053 insertions(+), 578 deletions(-) base-commit: 7aaa8047eafd0bd628065b15757d9b48c5f9c07d -- 2.50.0