From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F0E83B3C0E for ; Mon, 30 Mar 2026 08:59:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774861193; cv=none; b=cPq+YYI5jmOabZsADz5rk0z8toOp5uehO0Z55FQ//TgUqO5VR4YbbOEhglm62tCnfwHvMNrlpesR2xusVo3HmLnnyY8Gg7jgjZTubLr2H/wvNSeyQlXLSmZIvZ/rMHYdsrEagqF9GUKjf1Dz6NFyWzQSnxLydKb5drYdzdzBNcE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774861193; c=relaxed/simple; bh=FM7y6MpbxkJugLSfhUCY4SdyN6qyygWwOkCwV+H2kLY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lSMMNngiuSkGVCNhOfVAiwhETNp1JD7MYRqgZt3ST4YM3dN7UVWpAMkezP+g6fGZdss6ASF75xMUOD11QMZ7Y1y+JLMCZRXKDW6cxCiEWv6FjTZtT2obGlTDSAErspRUGrm4xWQ7pQ3zLpIxCp+PNCOtnnsGO5WLRwL2KuD22XM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BvF2yDrC; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BvF2yDrC" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4852a9c6309so35029825e9.0 for ; Mon, 30 Mar 2026 01:59:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774861191; x=1775465991; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FlpLwYuuFaP3k6wTifairgnddIhlqLprIXV2dOf14X4=; b=BvF2yDrCHBH8fT0QUdkzIZLUEwg0S9n40jeVEA8jKmJqefbz8I/TjD3UVApm61t2sb pjo75b4kptTHxK53UEopsU2OGQDsdjAPFpRgYBS42eqzlcGB6HFfLZZWGACstCFj4XQA huvXa9Tpfj9Vr2P/qLKsjNdLbEDXADMMZ8HnCM4net3jAPj0Vi6yUfbww+R2CcHQYWS9 YboA3341fpkSa5No5e7nHILL3RXhMYnvAE/AuR/Pj2VdVzyIeKnjr0hNZsOCmJFec/TS 3DM6Rme7JHE8Dy/YK5cpkiHYoWvyafQtYCdFnyE0S/Lax6546IvHD6dvE36jPWvOyEuB RjuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774861191; x=1775465991; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FlpLwYuuFaP3k6wTifairgnddIhlqLprIXV2dOf14X4=; b=s/c8O7gzaTLgchAvyyWHpna+3Cvz+Sig4XWWDPKO4QYVMplnArNxajXhjNP+Si1mH4 rfLFsjKSl8WjYEQysFFGPxYDx1C5EgUEhIfRg0FLLfISpDfrZL+Zf81znJegj24qFCGG jsc0apbpyS92JxmZjUIBDvHNpIoKnGZvZ0aRIdJGWXWAIa4XT0H1X0dhRoQrbySJL301 4U7jyDDkHDXkCC0gWoyqMWAKrpEU/kn6Z7/WY+kgQw+bS5NZIh6fUsXBPMBvN3bydOCU SrT595FDUBA2WZKxJ1S6UAletp8HoLei6C3afP6TU00fkqQ7BDcr5ymhGJA4gm6uuK/j oKgQ== X-Forwarded-Encrypted: i=1; AJvYcCVr5Dk5QHJSaCAmrVGO1oLgII8CuXP1QUR9xmkDWofdBAsxeRB1nFm6MqkgJq7duJcCFdCvxu5SZfmRH3k=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/j9/xSw4yU1eF3ebn/O625I21oy3E1lqnLZ8aMG5wVWLtuHFF Z4moodFu+/ytoTAtyicRAAY3WYHs1HjRmeqo7xlit6+CzCzuRz4MlXkl X-Gm-Gg: ATEYQzxTelXNbOZC5rRhFQXbsZ9yfe9DBQbHZ4ft4otN/RQo9foQkZPOry/CZ5hn9Er TEp7fj6VUGCj1vIiVskotPkr90ncBP4PVcB3RpCA8Hx1wPyCIQimxt5leDLeLITtilJMNEX7MFl nHwEGgWe01rAPnqgszsix2xPfCgcZpq/j4whAoFEyKL3Z0Gzfh3oGe9BIy3hWMhg4nSgG6qpg/n uSy8684Q1HJ5XOr9qd/ClKsvIqbnVaAtGtbowxz3T4WJexSNKT/2F+xWvOLYkBq2OIAFbhmYnyo /F05SzVrFxtVLBr4vU/weN2rZZvsraFD+I7ndcFwZ69jE1tiznvrF1pGYjyKV1BgVrEBUNjYKr+ RAQzdY5KCQyDcX+vpWBh+GZrF9zsSov0jpoFx3DcjJ2ASJIPXoe5YeAlU8MGI7ukEad6jLa/Cxf OGAl0Eqs+gY3BMYR5MU5p7FYMNZsXv4JrCoTP7nc+pXZFCzt2MKt8Mn0TvuNBKsBQxyAQ7aQtj2 /A2tp/NnXCNP3VN3TWJOT4BqxHR2QtBbSXNb1KHGZ1v X-Received: by 2002:a05:600c:8b55:b0:487:20ee:bef6 with SMTP id 5b1f17b1804b1-48727efc266mr231391145e9.11.1774861190606; Mon, 30 Mar 2026 01:59:50 -0700 (PDT) Received: from fedora ([193.77.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4873881c195sm44111025e9.9.2026.03.30.01.59.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 01:59:50 -0700 (PDT) From: Uros Bizjak To: x86@kernel.org, linux-kernel@vger.kernel.org Cc: Uros Bizjak , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Subject: [PATCH -tip 4/4] x86/tls: Clean up 'sel' variable usage in do_set_thread_area Date: Mon, 30 Mar 2026 10:59:23 +0200 Message-ID: <20260330085938.67985-4-ubizjak@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260330085938.67985-1-ubizjak@gmail.com> References: <20260330085938.67985-1-ubizjak@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The top-level 'sel' variable in do_set_thread_area() was previously marked __maybe_unused, but it is now only needed locally when updating the current task. Remove the unused top-level declaration and introduce a local 'sel' variable where it is actually used No functional change intended. Signed-off-by: Uros Bizjak Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Dave Hansen Cc: "H. Peter Anvin" --- arch/x86/kernel/tls.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/tls.c b/arch/x86/kernel/tls.c index 3ffbab0081f4..86b4186a0d4f 100644 --- a/arch/x86/kernel/tls.c +++ b/arch/x86/kernel/tls.c @@ -117,7 +117,7 @@ int do_set_thread_area(struct task_struct *p, int idx, int can_allocate) { struct user_desc info; - unsigned short __maybe_unused sel, modified_sel; + unsigned short modified_sel; if (copy_from_user(&info, u_info, sizeof(info))) return -EFAULT; @@ -153,6 +153,8 @@ int do_set_thread_area(struct task_struct *p, int idx, modified_sel = (idx << 3) | 3; if (p == current) { + unsigned short sel; + #ifdef CONFIG_X86_64 savesegment(ds, sel); if (sel == modified_sel) -- 2.53.0