From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60CE23A4F5D for ; Mon, 30 Mar 2026 14:17:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=65.109.113.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774880223; cv=none; b=AtfrVP5CKFgdKbGrp8fXUyVThUBPhfhEJm3YLjum5bCKzhPxBst27S87kvbbHqVv+MWwxsGmH5IjTuNI62bhOYEQpxND0V9clDwlBeLhegJr5JYI5MSes87OoHOvlhpt9nf9FZf1vhZQMzppvy/OCn/E4RQTyYV0Q8whwoVp7wA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774880223; c=relaxed/simple; bh=8KYf05MQAtw90maXEEeaa7uf3RstkpEy6T/a8Mib2uE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Igs1rRr8kqZIv6uomip6YlAt9bWp7+kViLnofQPDotdFP77AY7Dm2z+6kjKjU4KdaZhHCYQl1lhu3NF45BWKz0sZTUkUnMRqLV1Vd+88vIMegQbKbqRSzXzb5G9uMXHKdX0OgFGNHJ7ZJ1GmL5Gd1LaqdqAxu6L/hUdAYVo+/lg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=alien8.de; spf=pass smtp.mailfrom=alien8.de; dkim=pass (4096-bit key) header.d=alien8.de header.i=@alien8.de header.b=EHgx83of; arc=none smtp.client-ip=65.109.113.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=alien8.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alien8.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=alien8.de header.i=@alien8.de header.b="EHgx83of" Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id CE9BD40E029A; Mon, 30 Mar 2026 14:16:58 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Authentication-Results: mail.alien8.de (amavisd-new); dkim=pass (4096-bit key) header.d=alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id qWQh4W-YxlX7; Mon, 30 Mar 2026 14:16:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1774880215; bh=4clyQRFveLkxr1kyuzOI8gzMfyKmeVLzZerRw/xkrh8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EHgx83ofwRYP1rMTCPYt074VqC0+9iAdE4ZNIIBl7nnr59hpeexBTU7alkeReWSJ9 4sOpkfC6MR5XsM/qNS95YN/Rp79nvVJpK/LUM1dNguzk0TtqJ1ckj4jOZffWf1NBFV d7XNkXWMx7sKRASu4sb9o2ZB7hWn7MlUyogwG2ktYWeKq6aClbP22Sf/1rGI5meV6d VVLZmXe6qdoTBR/7wCKQIN/RCTh5YFE1JzAXyYEVc+pDdFCmFwnLte5RoHcl93F7/Y yZfFtplbPqAol/SRjuzeYtkXgQkZ2rV9/kzDjJMqrsv3vtge8xOz9n1T8kBs+sQIYs x5uLtpALa2e682g09kdpw8um7hG0B3ug+VlB7fILYFc6iVejrLbNiGnHlhxlPXg1Av /vSbWqHNkZhJicRI0I7hK2wrlzuvN4OfEdcIzrY0QG4Pv17E19CmlgQvvZc++cC16k fJbKZAs9TykDUYNU5EXCFdDWA1a6h4Y1lSTTWNnHmpdDWeqi9yMG3EL5Svl4cgdRwl TXVq4/5AFt1jpgvINw1HQY0+/9NSEowZwBFug66HnlvS4OBNy5BNLYy2D33xarfYmY Uhz16LWwpso0kp2+mipp2AWcl/UaX7Fc4xqzWN0bd5XcDhsNMr8CDc6DwZgtioLfaT rNOuORK67CKncV/8Mn7kc/fQ= Received: from zn.tnic (p5de8e020.dip0.t-ipconnect.de [93.232.224.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with UTF8SMTPSA id 7577640E0298; Mon, 30 Mar 2026 14:16:48 +0000 (UTC) Date: Mon, 30 Mar 2026 16:16:41 +0200 From: Borislav Petkov To: Roman Storozhenko Cc: "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/msr: Remove misleading "unrecognized" wording in write warning Message-ID: <20260330141641.GCacqFyVoaOSpIea9O@fat_crate.local> References: <20260325-dev_roman_msr_msg-v1-1-cd51e2579018@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260325-dev_roman_msr_msg-v1-1-cd51e2579018@gmail.com> On Wed, Mar 25, 2026 at 06:48:52PM +0100, Roman Storozhenko wrote: > The term "unrecognized" in the warning message > > "Write to unrecognized MSR..." > > creates the impression that the MSR access is invalid or > prohibited, which is not necessarily the case. > > Remove this wording to avoid misleading users about the nature > of the access. > > Signed-off-by: Roman Storozhenko > --- > Additional context: > > A utility that uses direct MSR writes triggered this warning during > post-silicon validation. The message was interpreted as evidence of > incorrect or prohibited MSR access due to the use of the term > "unrecognized". > > This led to confusion among validation teams, although the MSR accesses > were intentional and valid. > > Clarify the message to avoid misleading users in similar scenarios. > --- > arch/x86/kernel/msr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/msr.c b/arch/x86/kernel/msr.c > index 4469c784eaa0..16f6cde7d471 100644 > --- a/arch/x86/kernel/msr.c > +++ b/arch/x86/kernel/msr.c > @@ -98,7 +98,7 @@ static int filter_write(u32 reg) > if (!__ratelimit(&fw_rs)) > return 0; > > - pr_warn("Write to unrecognized MSR 0x%x by %s (pid: %d), tainting CPU_OUT_OF_SPEC.\n", > + pr_warn("Write to MSR 0x%x by %s (pid: %d), tainting CPU_OUT_OF_SPEC.\n", > reg, current->comm, current->pid); > pr_warn("See https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/about for details.\n"); > > > --- # modprobe msr allow_writes=on # grep -r . /sys/module/msr/parameters/allow_writes on -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette