From: Borislav Petkov <bp@alien8.de>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Maciej Wieczor-Retman <m.wieczorretman@pm.me>,
dave.hansen@linux.intel.com, xin@zytor.com,
chang.seok.bae@intel.com, mingo@redhat.com,
elena.reshetova@intel.com, maciej.wieczor-retman@intel.com,
babu.moger@amd.com, sohil.mehta@intel.com,
pawan.kumar.gupta@linux.intel.com, pmladek@suse.com,
nik.borisov@suse.com, ptesarik@suse.com, darwi@linutronix.de,
tglx@kernel.org, peterz@infradead.org, jpoimboe@kernel.org,
ak@linux.intel.com, linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH v12 2/4] x86/cpu: Check if feature string is non-zero
Date: Tue, 31 Mar 2026 00:59:15 +0200 [thread overview]
Message-ID: <20260330225915.GKacsAQ6o_LuNY0hbc@fat_crate.local> (raw)
In-Reply-To: <3CFC48BC-615C-4A39-A660-2B348DF13B9E@zytor.com>
On Mon, Mar 30, 2026 at 02:44:56PM -0700, H. Peter Anvin wrote:
> The Right Thing™ would be to have a table in the kernel which includes *all*
> the feature bit names, not just the ones exported to /proc/cpuinfo, and use
> the unfiltered string table for kernel messages (/proc/cpuinfo being
> filtered via a bitmask, list, or a flag in the table.)
Meh, not convinced. Not sure it is worth the effort and bloating if we can
simply look up the feature from word and bit number.
> It doesn't help one iota, either, that modprobe is supposed to know what the
> numeric bit positions mean, either. It is a pretty egregious design error.
That was designed in ancient times, I'd presume. :)
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2026-03-30 22:59 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 15:10 [PATCH v12 0/4] x86: Capability bits fix and required bits sanity check Maciej Wieczor-Retman
2026-03-27 15:10 ` [PATCH v12 1/4] x86/cpu: Clear feature bits disabled at compile-time Maciej Wieczor-Retman
2026-03-27 15:10 ` [PATCH v12 2/4] x86/cpu: Check if feature string is non-zero Maciej Wieczor-Retman
2026-03-27 17:50 ` Sohil Mehta
2026-03-27 21:28 ` Maciej Wieczor-Retman
2026-03-30 20:00 ` Borislav Petkov
2026-03-30 20:42 ` Maciej Wieczor-Retman
2026-03-30 21:15 ` Borislav Petkov
2026-03-30 21:44 ` H. Peter Anvin
2026-03-30 22:59 ` Borislav Petkov [this message]
2026-03-30 23:42 ` H. Peter Anvin
2026-03-31 2:15 ` H. Peter Anvin
2026-03-31 13:27 ` Borislav Petkov
2026-03-27 15:10 ` [PATCH v12 3/4] x86/cpu: Do a sanity check on required feature bits Maciej Wieczor-Retman
2026-03-27 17:10 ` Pawan Gupta
2026-03-27 17:22 ` Maciej Wieczor-Retman
2026-03-27 15:11 ` [PATCH v12 4/4] x86/cpu: Clear feature bits whose dependencies were cleared Maciej Wieczor-Retman
2026-03-28 2:22 ` H. Peter Anvin
2026-03-30 10:40 ` Maciej Wieczor-Retman
2026-03-30 21:41 ` Ahmed S. Darwish
2026-03-31 11:41 ` Maciej Wieczor-Retman
2026-04-01 15:16 ` Maciej Wieczor-Retman
2026-04-13 14:42 ` Ahmed S. Darwish
2026-03-30 6:11 ` [PATCH v12 0/4] x86: Capability bits fix and required bits sanity check Andi Kleen
2026-03-30 8:52 ` Maciej Wieczor-Retman
2026-03-30 23:40 ` H. Peter Anvin
2026-03-31 14:02 ` Borislav Petkov
2026-03-31 14:27 ` Maciej Wieczor-Retman
2026-03-31 14:46 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260330225915.GKacsAQ6o_LuNY0hbc@fat_crate.local \
--to=bp@alien8.de \
--cc=ak@linux.intel.com \
--cc=babu.moger@amd.com \
--cc=chang.seok.bae@intel.com \
--cc=darwi@linutronix.de \
--cc=dave.hansen@linux.intel.com \
--cc=elena.reshetova@intel.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.wieczorretman@pm.me \
--cc=maciej.wieczor-retman@intel.com \
--cc=mingo@redhat.com \
--cc=nik.borisov@suse.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=ptesarik@suse.com \
--cc=sohil.mehta@intel.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
--cc=xin@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox