From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f202.google.com (mail-dy1-f202.google.com [74.125.82.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C020315D40 for ; Tue, 31 Mar 2026 05:12:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774933949; cv=none; b=Q0TkXLDicIZ33oB1nvmbpTFAyGA+BJ4D42hP8k4RckqcYa2fdZi8LV1vqRq6Jb0Qgzn0F5veWG8gU3tr9dhCjkZK1Ll6u0ZIzeK5euvyiOx84dYDYwEnr/JTBdolmLyKyQn9U/iC9bVvcO3MU+kUMOsggb2XHtlVk3WR8MfD5ic= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774933949; c=relaxed/simple; bh=zcl02xu1BYTixmNxt91kz8xP1HL47BxhYUlh05sD+3U=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=ZkMfWRL/CectiGiq3aXZzSJeN/Y9ake0XXkOoJL+ye9DtK8VRE9dIHrP26QJCbYQlmuRGGRLEpxmW5bUgqetQHW9th1mijcY8nKPopKUDXwr0ioTYrI+ASA6C5oNDsDRN9tc1AzxaGat09hBcxKn3vqujVATM+u5VjHhpmNXbos= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--wnliu.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=FHHePjxz; arc=none smtp.client-ip=74.125.82.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--wnliu.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="FHHePjxz" Received: by mail-dy1-f202.google.com with SMTP id 5a478bee46e88-2c7f2b72c91so3403931eec.1 for ; Mon, 30 Mar 2026 22:12:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1774933946; x=1775538746; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=5fNqPUT4y31sfxi3EaoVPyLAMBJL+AOFGM4l5YSc4ak=; b=FHHePjxz4hHWqzI+5WBWhQZV79g2xUxUGmcLBS6eq16sBo3PjFsC96EG5Pdq5URDg3 gha7F5QfZCdmJmhKbAoaZIXSEbwkZEUcROGqmJPPmiOICrvc4YxicvRfP5h5vZrz1CBE K68qH0EqeFSzc/dhtJ1h8IcGgnW3po6aurk7wr0XVQ7JiGeIRcaLEkDrDiTk8MM8HNcc Od/X1OYaHG0hlMtiMWCAUCY52B4YdDnd5nDOO3Aw91g9vaTRHWOyN9+hVPvFGVd47oIB uaCk3Rvv5vvqF2SrksAh0yGiod9Yo/n2ReKcVso2+OcaVdZvhYn+S4MecjBPF107URIF fX9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774933946; x=1775538746; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5fNqPUT4y31sfxi3EaoVPyLAMBJL+AOFGM4l5YSc4ak=; b=XfWuP8pk3VerC+i+d2AzBXBu2S0Zuvkw6qVZtBc9QojPoBLu/wVBKMinpBL5ykDJkW PIJOSC4nI8IoplvBMrEOgudTAPDSKpqBoydnSQMNYf8RNJcUlsLhya5HvSzNmq0TXcBj goGbxSD2rsS84/b26Md1bWqI/Jtsb7szWtK1YdRvvDz1mOQWylEZ8soW4Z1xHmbrmDHV Erpr5oMeb9A+UD8YMaSfCJk9VldIG/sSIcL1LckcwPg6AIO0OXrsjXE86ue7uR9jnjtP JFEjsQUE+X/IsrOD08zurUBMnTu8sppAb3K/UZjDx/lV7hFxzQF7Wp2QDRAxqyz3dn6t 57gg== X-Forwarded-Encrypted: i=1; AJvYcCV4no9uaPlBBxHLjwzv+gbJLtp7f/Gt0bA3kJJRZpO341n5JeM5JGpX1tWLOuRzwA4bY4Idq0m4TZ9Xs+c=@vger.kernel.org X-Gm-Message-State: AOJu0Yyu1cZLtzWyuwjhyKVjFwrpsQVph2GmeQm98ZI1kauMqJPBp/8/ 2W7K3JyBJp2qgoJILj7m8Yrjq+utXuUx7Gn2J2NG32uHowTFl9ynSBzysODRwDUYJ3FrW2AVHLA zTQ== X-Received: from dyb27.prod.google.com ([2002:a05:693c:631b:b0:2c7:1a46:6250]) (user=wnliu job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7300:724c:b0:2c1:3e6d:2e6e with SMTP id 5a478bee46e88-2c185ce8409mr7961323eec.7.1774933945939; Mon, 30 Mar 2026 22:12:25 -0700 (PDT) Date: Tue, 31 Mar 2026 05:12:24 +0000 In-Reply-To: <20260330084206.9251-4-suravee.suthikulpanit@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260330084206.9251-4-suravee.suthikulpanit@amd.com> X-Mailer: git-send-email 2.53.0.1018.g2bb0e51243-goog Message-ID: <20260331051224.3993081-1-wnliu@google.com> Subject: Re: iommu/amd: Initialize IOMMU Private Address (IPA) space mapping region From: Weinan Liu To: suravee.suthikulpanit@amd.com Cc: chriscli@google.com, dantuluris@google.com, iommu@lists.linux.dev, jay.chen@amd.com, jgg@nvidia.com, jon.grimm@amd.com, joro@8bytes.org, kevin.tian@intel.com, kpsingh@google.com, linux-kernel@vger.kernel.org, nicolinc@nvidia.com, sairaj.arunkodilkar@amd.com, santosh.shukla@amd.com, vasant.hegde@amd.com, wnliu@google.com, wvw@google.com, yi.l.liu@intel.com Content-Type: text/plain; charset="UTF-8" > diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c > @@ -2198,6 +2202,10 @@ static int __init iommu_init_pci(struct amd_iommu *iommu) > if (check_feature(FEATURE_PPR) && amd_iommu_alloc_ppr_log(iommu)) > return -ENOMEM; > > + ret = amd_viommu_init(iommu); > + if (ret) > + pr_err("Failed to initialize vIOMMU.\n"); Should amd_iommu_viommu be set to false if vIOMMU initialization fails? Currently, the following logic will indicate that vIOMMU is enabled even if the initialization process does not succeed: if (iommu->cap & (1UL << IOMMU_CAP_NPCACHE)) { pr_info("Using strict mode due to virtualization\n"); iommu_set_dma_strict(); @@ -2291,6 +2299,9 @@ static void print_iommu_info(void) if (check_feature2(FEATURE_SEVSNPIO_SUP)) pr_cont(" SEV-TIO"); + if (check_feature(FEATURE_VIOMMU)) + pr_cont(" vIOMMU"); + pr_cont("\n"); } @@ -2303,6 +2314,8 @@ static void print_iommu_info(void) pr_info("V2 page table enabled (Paging mode : %d level)\n", amd_iommu_gpt_level); } + if (amd_iommu_viommu) + pr_info("AMD-Vi: vIOMMU enabled\n"); }