From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f202.google.com (mail-dy1-f202.google.com [74.125.82.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEBD0611E for ; Tue, 31 Mar 2026 05:30:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774935029; cv=none; b=sEo5rZD6qcef6O1QnC6xOq9TJ22I/GAhiVqjoFKr0uJCrDXlcLBwiFyr2tNm93zTccZjNH9g+tAZESESkvdGUaZdmhe1LebOXFTgvySfYS7UhWyI5bt7ju/Xk5dbj87WpzBUr8sTZb53/8E+jctNUFNZGJ6YjvAdVNlv5uIO9ZQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774935029; c=relaxed/simple; bh=88WLdxLEDTNu6k9xLQijUGvoPlfUNPqJgQxMuYusay0=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=pQqcPR79xzxhP7YbDMSye0J3aKccht3tCxhQHW21hWepUvUNHeVqzdQCfM4+CAv5oEb1ZwJtG26bF0r2zlRKSU0Vj04C7uSlz4qPguS2K57+WT2IZWUXZjD9G9q6IQL18ofcJxg2Rq+6k2cntLQy4mLaI+EhCjNRph8mi3R2sAg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--wnliu.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=U/VW2l7b; arc=none smtp.client-ip=74.125.82.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--wnliu.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="U/VW2l7b" Received: by mail-dy1-f202.google.com with SMTP id 5a478bee46e88-2ba8013a9e3so4440247eec.0 for ; Mon, 30 Mar 2026 22:30:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1774935026; x=1775539826; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=88WLdxLEDTNu6k9xLQijUGvoPlfUNPqJgQxMuYusay0=; b=U/VW2l7bKrP35OirCOOLWyzKsyj/W9vXvhe9yhdWb6ZCzZ5+2Vb50wTTwVw/8KP15D ydE8K9BUJWN+Lx2zuPh1XTIbeHMwxwS8gU/hY8tUwuIEfsgrn7qBEjr8d8bYRV/FH0Oi jCIUtHYF9bn17QBuBkZm+RU36uFUpBqspgjX/9mfotXNiy/1OtaequQl1tS37aG9DzCa Z8jSRV9MZe8xaSTUfYGCgS09puMFVzW98ZIAkSizfEkWjIsvGwNLrsxZZDCAOiROjQiL xRupP85rIaInuMC70j9Wrni15CmS8Z+VFEKyzpyWBsWB+xw+Zu+hBAizamsrXxJV9jAh ibHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774935026; x=1775539826; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=88WLdxLEDTNu6k9xLQijUGvoPlfUNPqJgQxMuYusay0=; b=GU/ydXL2TKb9ultHNXbhBJCWcqTy1qDRAbImPCIWYq5W1jxBQ0jYydj9sdO38ioafp Tv1OvJdLoutDqMUWPWjCsWuLv/gHdR3XT6ZN9A84CA78aTAtVSo3e3l1rPUFnG0vYG4b vfAYhZ3hjmuAm+QLaI8nNo8LSrlTVaiafOH/q5pV4VZkpOVWE2Ae5gWGzzWFECRB+OKK D7INQm7mhzK7ZuhyCHHTrStsDRG1VIjzztnqXy1uDLET9PuKD7NhPTfvwBOB6LGIdHjH n37jMqi931KwG0dX5wepj2HIf3yV2mFifMld65DrfQW1Sv76f+N7O4vRgCjlABcbkdiM 0U7A== X-Forwarded-Encrypted: i=1; AJvYcCWpkddkccOG3C6nw6YIWuT3486ja8SNP7i2lnav6cpUXWDnZzINOSnMvtWTfLLKLS1p8UXqhW2eY73kba8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6AaKpwIOOegd2P8LJHo8X9v2lHBvH9FLv1MtqYswP6Vpjirht zjdgXYGnLzHG0vwonN17gx2it8GfzzJk9u9mrrAecEafrpuIMfKHnU+L5dn99oU3IltazVuI6cn 01w== X-Received: from dycrq17.prod.google.com ([2002:a05:693c:2c11:b0:2c1:80e6:1768]) (user=wnliu job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7300:d512:b0:2be:83d0:d229 with SMTP id 5a478bee46e88-2c185e45d90mr8113698eec.27.1774935025727; Mon, 30 Mar 2026 22:30:25 -0700 (PDT) Date: Tue, 31 Mar 2026 05:30:22 +0000 In-Reply-To: <20260330084206.9251-7-suravee.suthikulpanit@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260330084206.9251-7-suravee.suthikulpanit@amd.com> X-Mailer: git-send-email 2.53.0.1018.g2bb0e51243-goog Message-ID: <20260331053024.4008333-1-wnliu@google.com> Subject: Re: [PATCH 06/22] iommu/amd: Map vIOMMU VF MMIO and VF Control MMIO regions From: Weinan Liu To: suravee.suthikulpanit@amd.com Cc: chriscli@google.com, dantuluris@google.com, iommu@lists.linux.dev, jay.chen@amd.com, jgg@nvidia.com, jon.grimm@amd.com, joro@8bytes.org, kevin.tian@intel.com, kpsingh@google.com, linux-kernel@vger.kernel.org, nicolinc@nvidia.com, sairaj.arunkodilkar@amd.com, santosh.shukla@amd.com, vasant.hegde@amd.com, wnliu@google.com, wvw@google.com, yi.l.liu@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Mar 30, 2026 at 1:43=E2=80=AFAM Suravee Suthikulpanit wrote: > diff --git a/drivers/iommu/amd/viommu.c b/drivers/iommu/amd/viommu.c > index f4b5f96d4785..887a9eb8122d 100644 > --- a/drivers/iommu/amd/viommu.c > +++ b/drivers/iommu/amd/viommu.c > +static int __init viommu_vf_vfcntl_init(struct amd_iommu *iommu) > +{... > + =C2=A0 =C2=A0 =C2=A0 /* Mapping 256MB of VF and 4MB of VF_CNTL BARs */ > + =C2=A0 =C2=A0 =C2=A0 vf_phys &=3D ~1ULL; > + =C2=A0 =C2=A0 =C2=A0 iommu->vf_base =3D iommu_map_mmio_space(vf_phys, 0= x10000000); > + =C2=A0 =C2=A0 =C2=A0 if (!iommu->vf_base) { > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 pr_err("Can't reserve = vf_base\n"); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return -ENOMEM; > + =C2=A0 =C2=A0 =C2=A0 } > + > + =C2=A0 =C2=A0 =C2=A0 vf_cntl_phys &=3D ~1ULL; > + =C2=A0 =C2=A0 =C2=A0 iommu->vfctrl_base =3D iommu_map_mmio_space(vf_cnt= l_phys, 0x400000); > + > + =C2=A0 =C2=A0 =C2=A0 if (!iommu->vfctrl_base) { If this mapping fails, the previously successful mapping of iommu->vf_base = need to be clean up=C2=A0 > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 pr_err("Can't reserve = vfctrl_base\n"); > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return -ENOMEM; > + =C2=A0 =C2=A0 =C2=A0 } > +