From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 888AB30E0F1 for ; Tue, 31 Mar 2026 06:38:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774939132; cv=none; b=c7JML+6pcwVTGgYq8IPezKb4dj/pSHTlHVmFOFyfwGRmJJKqo/CvMr0PQBhqV92Ln9r1X2zqEQh67y+VnaIEPs04UrRmtt4A/4M3XVASMTC8/WwfGkGYT1W1q2kf8DokFuwVsP8c3vHejDZuRP3EB0nregAYT3j/Eg9jNhGwClU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774939132; c=relaxed/simple; bh=AAzjweJfWa5+uHaZXYOFVqAOxZDcgn+VBsXQU7IqP08=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Q2yxY/PLf0OiD9p+9MDlDUGHUb+cX38MewULX1eVYdAcIybSogZUe92YsuMmB8H4MAADMvlnIbR6mjl2v+jBd+XNk7WTncNSpAl27t+/Hgo54FNqxGMUC3C19pm6gdvVtGszYPuf6KszZBlNB0XTzJirLC7GM95snZ7cObt5ERw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DmXVMszQ; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DmXVMszQ" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-48557c8ad47so40473815e9.0 for ; Mon, 30 Mar 2026 23:38:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774939129; x=1775543929; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QTs/Zu4bDQiKOh3WUoKwq3Cv1zcjbc9lTGiX6ccgekE=; b=DmXVMszQzh6FrdIX7iav3+gROpg4YFc2qj+N/zOA1tCePOd71hmv4s+h2wf76cPDvl W+QMyBbdcGm23Syk5z8FHQ63Nmy2LRCIo2ICAiUEjf4nbLyPX0XfLb4sGei/I8B/cgMD FdbmNBp+Ow5nyCbjpTe8flCMjKMcylV3oMid5EUOJrkLpgI2NfL2d66YnELFixxHgWFC l/4Hon9194ipiOi5fx899GCO5u6To1da1bxlquMHCYl19Y+nBgJYAXJTG38wtuFvRjc2 VboPhaqShwbEoKnFiR1GBBfeBSmfCoF5/ZOYnzOFjLg180qF+oppDNR4lSb6RglytCIH JwGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774939129; x=1775543929; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QTs/Zu4bDQiKOh3WUoKwq3Cv1zcjbc9lTGiX6ccgekE=; b=h5Pbj/pUH/HOHMGquaGczC/BAWIE1Q+z9MJtJL7XW/gJ/XkKVMsyatkuVEVLlI2cg1 d98yCCydEQnlEyU2wXRPpadCdbRFrc6gvyg9sjnk+nxIwxD6s18In6zy3+SaNXbnmYDh GjtH2orjoTffpLyabwT6jfyHuGMCPh+N4IhwLWj6YTw5jjWJVP4/npfcL8kfmfw3JoD0 Yin3mPlMcRRWmTnJHzi/HP5lrS8864WRsMKz7eOZ9QiRYQCDICadtQZoDJnyC6COQ++/ NSgx9Zse+QKfl7KSmmcvYZaA9Its1lz142dp97YQRHcjKmfcUZ5EPZBM7BtkoTeS8aNz 2nDA== X-Forwarded-Encrypted: i=1; AJvYcCUWwjdL5oGeK7X+EGQo4R9y7Pg3FrkKVdwpMtqhDl5ukm31C01ku1QzTq6PStQcp+y+x9Op5JnHNQzrqVA=@vger.kernel.org X-Gm-Message-State: AOJu0YwMexXOyy0i1gNw9UmNfOvX6ktBtj7+Kz2dYQ4YyNSMFJRVGh7H PFyOUO0/uUMvx+W1frrZPupEV31CxTbB+1JISbLBf+odheCfjTD5SuEd X-Gm-Gg: ATEYQzzb4COMK638Mvafcw9Sf3ARHCy6NHazdPycIi9z7BEaMGhyJWnj0vXd0q8KzWE /MnNfc7/JnK4kPjBonOP/Rf/U+cyao3HZAArkgK52HbwORZvXENrqoIFn1wOqQbN6/Ysvxyq+JT APi0t761kSlDgkUxuf32QHAhik4JKEghvBNXRLhyVL8cP0FkelJ6sd6z/oSE5ncp8Bvke6WYZbN W/HGdZvuhSqsqqVZ4ASK336J6QSx2K84b8iX7ZsOcLkD9WpwHMTqdbhzJY7PK3dqrSjJ3vA0eTk cnYrBn8BHmOHXFe5DHc1odVHDmyG6YYqK1Xi+mjavPnFQo97dobeWOTyireKAQKDUBb4Aa2qfpD SlMlAGQkfwG3d9lBt62IVErYW5TGHkuAFImfoI5iuCB0Vnnn+hP81b2w074jPjtZGy+hXfs/6nf 3llQfEnIQVfGyaRWGoKAevCFg83afk0cR2Fc36qsTcxwovZDEWem7PnjWHnNDWUWiWKEmN0uemn F/ffbaObnt5JtZo/B3CVFlgz/iJ//nUe1EsRnJiTMA7 X-Received: by 2002:a05:600c:4e55:b0:485:4533:9c47 with SMTP id 5b1f17b1804b1-48727ec77a9mr258470235e9.22.1774939128643; Mon, 30 Mar 2026 23:38:48 -0700 (PDT) Received: from fedora ([193.77.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887e822227sm13289915e9.4.2026.03.30.23.38.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 23:38:48 -0700 (PDT) From: Uros Bizjak To: x86@kernel.org, linux-kernel@vger.kernel.org Cc: Uros Bizjak , "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen Subject: [PATCH 1/2] x86/segment: Introduce storesegment() helper to write segment selectors to memory Date: Tue, 31 Mar 2026 08:38:18 +0200 Message-ID: <20260331063838.108857-1-ubizjak@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Introduce a new helper, storesegment(), that stores a segment selector directly into a u16 (or compatible) memory location without using an intermediate general-purpose register. To support this, split the existing SAVE_SEGMENT macro into two parts: SAVE_SEGMENT_VAR(): retains the current behavior of reading a segment register into an unsigned long via a register. SAVE_SEGMENT_PTR(): adds a new variant that writes the 16-bit selector directly to memory. The combined SAVE_SEGMENT() macro now generates both helpers for each segment register. The new storesegment() interface is preferred over savesegment() when the value only needs to be stored (e.g. into a struct field), avoiding an unnecessary register move and making the intent clearer. No functional change for existing users of savesegment(). Signed-off-by: Uros Bizjak Suggested-by: "H. Peter Anvin" Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Dave Hansen --- arch/x86/include/asm/segment.h | 30 +++++++++++++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/arch/x86/include/asm/segment.h b/arch/x86/include/asm/segment.h index dbd90fede5e7..b9728c4acd46 100644 --- a/arch/x86/include/asm/segment.h +++ b/arch/x86/include/asm/segment.h @@ -344,7 +344,7 @@ static inline void __loadsegment_fs(u16 value) /* * Save a segment register away: */ -#define SAVE_SEGMENT(seg) \ +#define SAVE_SEGMENT_VAR(seg) \ static inline unsigned long __savesegment_##seg(void) \ { \ unsigned long v; \ @@ -352,6 +352,16 @@ static inline unsigned long __savesegment_##seg(void) \ return v; \ } +#define SAVE_SEGMENT_PTR(seg) \ +static inline void __savesegment_##seg##_ptr(u16 *p) \ +{ \ + asm volatile("movw %%" #seg ",%0" : "=m" (*p)); \ +} + +#define SAVE_SEGMENT(seg) \ + SAVE_SEGMENT_VAR(seg) \ + SAVE_SEGMENT_PTR(seg) + SAVE_SEGMENT(cs) SAVE_SEGMENT(ss) SAVE_SEGMENT(ds) @@ -359,10 +369,28 @@ SAVE_SEGMENT(es) SAVE_SEGMENT(fs) SAVE_SEGMENT(gs) +#undef SAVE_SEGMENT_VAR +#undef SAVE_SEGMENT_PTR #undef SAVE_SEGMENT +/* + * savesegment(seg, var) - Read a segment register into an unsigned long. + * + * Reads the segment selector via a general-purpose register into an + * unsigned long. Preferred when the value is needed in a register for + * subsequent arithmetic or comparison. + */ #define savesegment(seg, var) ((var) = __savesegment_##seg()) +/* + * storesegment(seg, loc) - Store a segment register directly to a u16 location. + * + * Writes the 16-bit segment selector directly to memory, bypassing any + * intermediate general-purpose register. Preferred over savesegment() + * for simply saving a segment register to a u16 (or compatible) field. + */ +#define storesegment(seg, loc) __savesegment_##seg##_ptr(&(loc)) + #endif /* !__ASSEMBLER__ */ #endif /* __KERNEL__ */ -- 2.53.0