From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32087370D65 for ; Tue, 31 Mar 2026 06:38:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774939132; cv=none; b=Q3iA+ft+N5QB9mXw6sKFF8bZFFS5P2p46RMaemkEFnjrPlGso8rWc5JhQ0NF3Dh51/eN4RZbLcAq1GBYKw+vHtPlH4iPMYOvWsUZ//3HbyzgZ5Piw9gKEZNPm2TySODwnPtTffPYz4/IavsgBWTNa56GTRrX0rcL/amGtwuxcOk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774939132; c=relaxed/simple; bh=Jons3wHP/fCDZ2BTyFPbhPTWEO9BhEfvymxYBdWWRQE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MS7bhpYLRFZEZEkkLCVdH57122uRS1Et8ln4G3DYv0z9bDnXeQ4JC4U6S1g/p0UfUKxZPEQJQ9G1x9hb+piQhVt0vTZVnRVkFmj2FXSWYsjlNqozyxW5OWpV3ktAdmFjAyOsVKbyhsJQXecOWqjcS7TyV213gyjuGGHUpuEke/8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pRKHjm2n; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pRKHjm2n" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-48334ee0aeaso46642835e9.1 for ; Mon, 30 Mar 2026 23:38:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774939129; x=1775543929; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=q/0zkzoN8mc44ssx7e38tGau6WnHuqq7COv/Fsa8stc=; b=pRKHjm2nC7gY+ZQXgizAZu/1teklWcKJnZ0rbDPa0/4jlG70O4LJ9Fq+BgIy+0aUiq gmWuWPA4rrteVEa921AwGLRd2dC1oBfaZtIh0LikaJGLsD4LV+gtvJ54oDA8n2Y+zEyh BMHBTEBh0MfsqwmTXWfw0s77w7xnpyl9BFGUQMaoHgNcPjvMWqXSeiDUWLVRoQ4GVB4H hDko1ZN5OwbHa9yvUlvyg6UhPw8enhNM3YyVHvQkOfjvc/M7+gcSVsDKURf5wmWyJ0Ml x/pE7xLKLczESkwo8zljvXQbW+/4wejGSV5cVi5R0HRDq18XF379xwaQpDbUxaNrQWdl 84Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774939129; x=1775543929; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=q/0zkzoN8mc44ssx7e38tGau6WnHuqq7COv/Fsa8stc=; b=U+8LE9pCELG3Ry+OtL6MRWmU2hIBFEY1QFHyER5pqtsXvr5VYk0xojeF44OHfniHPa ngln4qrFQczrvbi8tGjKY0DxOZE0UNqwTwTVzU9PnAYTC14atfeh6bV5S/QDCZtV5O/4 oMaPKZzwlg4O26vg+/0RgbX5qgyWlRzoF1e8uGw5JzMy+fha0pjvM3PiVx0eOvh2TEOs TTy59L6PjFc8t3DT7RxcHib9iNPGKUL3AxEq+w075rf8kvQceR42N8tLXvEzgg6jXz8P W2+OhNOVTT6h/391MdLRsLl9eplVt7n4zB4bH/bmp5DVLNJiCcIS66RDueDvgMRo5Oit +dzA== X-Forwarded-Encrypted: i=1; AJvYcCWvs7MNdJ77h9csoGgLuoRpIJMEh7Wp36ieakMQmcf5Tvna+iqV1NXL9sB73VV6DgD46JJffrOvDYys/aY=@vger.kernel.org X-Gm-Message-State: AOJu0Yzk3/PiP7UpXHQ5C2uz9MCYHSSI/J4sf5q09rMbQcqR3nZd96D+ vAiHAmrmGdBAE/wOHTuKtM1pGeu93kmSzflVOJKcPFLN4qZGh1ot98lu X-Gm-Gg: ATEYQzwxC4yFwEi1Nf9/9KbssnVXwwta9KIqWHvQNU+r/qJ/V0E5bHo/pjK55ZIkIkJ rjloZVbxXTIE/QPzymkUPkfNlYzeNq3oxcLuOXDDQZLzkVp3QWbQo2k0EzuKDiu769ZLvS4yDov QW/q6yVhrD9ZE8T2T5CZu3qI4qXgJo9qRmFwhlGbrW/wW/oNCtk2Bt4B/NnI4SdvDXl+j0o9EiA uItmYdiRRmPMdfamph4WrEGhBedwaL466T8aaDAi+9MXUgzniYdELFZdYOJtq5ffMsGGwxKmDLu 9rWMgW7iyefO33z4v7TKH+Zk3tyWosm7eCzO5eZfsMdX//A0SgvyPwRmkjXJWaX9M9I55lDLPT+ HRi+HP3Pi85BpNOMEb9yaQx0bgyah/NcDKT/Wfz2x9958+ZTVZbNNDO1lqjk7G1PPrbubS3Grrq nylTRMJXK9Qnx+j10p3edKHcjrLFrDNN0aPQ4pKCoS3SUM74BldoNAlPV6XYAv8DPTxA1a6txd/ yKmQrsF16s8do6ZepxnRgPcAgOYDPmXmdr49R5beUm8 X-Received: by 2002:a05:600c:6085:b0:487:288:1198 with SMTP id 5b1f17b1804b1-48727eda73cmr251520345e9.22.1774939129445; Mon, 30 Mar 2026 23:38:49 -0700 (PDT) Received: from fedora ([193.77.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887e822227sm13289915e9.4.2026.03.30.23.38.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 23:38:49 -0700 (PDT) From: Uros Bizjak To: x86@kernel.org, linux-kernel@vger.kernel.org Cc: Uros Bizjak , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Subject: [PATCH 2/2] x86/process: Use storesegment() when saving segment selectors Date: Tue, 31 Mar 2026 08:38:19 +0200 Message-ID: <20260331063838.108857-2-ubizjak@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260331063838.108857-1-ubizjak@gmail.com> References: <20260331063838.108857-1-ubizjak@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Switch segment save sites in copy_thread() and save_fsgs() from savesegment() to the newly introduced storesegment() helper. These call sites only store the segment selector into a u16 field and do not require the value in a general-purpose register. Using storesegment() avoids the unnecessary register intermediate and better matches the intended use. The generated code is improved from, e.g.: 34f: 8c c0 mov %es,%eax 351: 66 89 83 08 0c 00 00 mov %ax,0xc08(%rbx) to a single direct store: 34f: 8c 83 08 0c 00 00 mov %es,0xc08(%rbx) This is a mechanical follow-up to the introduction of storesegment(), with no functional change. Signed-off-by: Uros Bizjak Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Dave Hansen Cc: "H. Peter Anvin" --- arch/x86/kernel/process.c | 4 ++-- arch/x86/kernel/process_64.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c index 4c718f8adc59..10e2ba668a14 100644 --- a/arch/x86/kernel/process.c +++ b/arch/x86/kernel/process.c @@ -197,8 +197,8 @@ int copy_thread(struct task_struct *p, const struct kernel_clone_args *args) p->thread.gsindex = current->thread.gsindex; p->thread.gsbase = current->thread.gsbase; - savesegment(es, p->thread.es); - savesegment(ds, p->thread.ds); + storesegment(es, p->thread.es); + storesegment(ds, p->thread.ds); if (p->mm && (clone_flags & (CLONE_VM | CLONE_VFORK)) == CLONE_VM) set_bit(MM_CONTEXT_LOCK_LAM, &p->mm->context.flags); diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c index b85e715ebb30..fe391961ed86 100644 --- a/arch/x86/kernel/process_64.c +++ b/arch/x86/kernel/process_64.c @@ -275,8 +275,8 @@ static __always_inline void save_base_legacy(struct task_struct *prev_p, static __always_inline void save_fsgs(struct task_struct *task) { - savesegment(fs, task->thread.fsindex); - savesegment(gs, task->thread.gsindex); + storesegment(fs, task->thread.fsindex); + storesegment(gs, task->thread.gsindex); if (static_cpu_has(X86_FEATURE_FSGSBASE)) { /* * If FSGSBASE is enabled, we can't make any useful guesses -- 2.53.0