From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEEAE36BCC2 for ; Tue, 31 Mar 2026 14:46:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774968381; cv=none; b=o1Ff6NWG0/iKieOUwr2QHropV1TPTD32x/0yxec6Yt0qFI+Yf6cLLRgowF9PxWwye7b4p/Kxmql8se/5OMcFJ0fF5YZv7aeJzZJoiX6UJ/ryxoV3EcRUdLNCPgXxYtOXaIphUguRqjFubLg55d16vZI8Qc7tLylBcTszDydFSZw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774968381; c=relaxed/simple; bh=NRgKjnJCKwJduCliXUp6Q5nDSpVe30iRvLQ7lnBey+k=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pDL3Hy+n1jy1jQ1gwP7m6Wg7LGgbjSJhEDTEXybgh9wBd4N0Xz8kykDfgkPiRdlGvo5uon3JnWzW3q7+QW0xNxXyWtVoSPId+n6YHe2lfW/XSdjsQz6qWLBFS+eFgZEtU+Cf1WlwVPtwbyutuAvNR3UCuA+k40SwfePkAXoO390= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1243E1A0251; Tue, 31 Mar 2026 14:46:13 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: rostedt@goodmis.org) by omf03.hostedemail.com (Postfix) with ESMTPA id CA7EE60013; Tue, 31 Mar 2026 14:46:10 +0000 (UTC) Date: Tue, 31 Mar 2026 10:47:08 -0400 From: Steven Rostedt To: Krzysztof Kozlowski Cc: Josh Law , akpm@linux-foundation.org, pmladek@suse.com, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, senozhatsky@chromium.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] lib/vsprintf: always advance args in bstr_printf() pointer path Message-ID: <20260331104708.6dc812ca@gandalf.local.home> In-Reply-To: <2f824be3-7b30-41c6-b517-de1086624171@kernel.org> References: <20260330193440.74268-1-objecting@objecting.org> <20260330193440.74268-2-objecting@objecting.org> <2f824be3-7b30-41c6-b517-de1086624171@kernel.org> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspamout05 X-Rspamd-Queue-Id: CA7EE60013 X-Stat-Signature: 5aa3usehjcrz9kpkcmsz1wqtth7zc8zf X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX19InYdBBmXvQ5VYeg8Nl31ScOwnGRyxLqo= X-HE-Tag: 1774968370-233259 X-HE-Meta: U2FsdGVkX18ZzvAh0nmB/dVCMLhvcbmvVPKjGHWFIR09TCysV3MbtQs3SBat2mjqO+Fq8TNICF8ZAO9wROy/q6S8jcKZMfbGyk4E/hnHh0LM6UQ4Y7gzBBUj8xLGbz2Q89BNH0fqZucDn2PI13ufCH5D0D9jY6QXATErATJWXMf5oEY/cD+Qgp1dUxq3WvZc/c/hJH+btOOXoT5c1xVMvaVMIF61lAVpThN7Fa/OZdNMVi6cdVzJcGHYUoRy0cy23O1D0WxEskzucc90R0GNBzyE/GwA/A01QiqWjKHp403TGZ107rfEIJ9d84Tz30Iw1EFSagp8OLpt/UJjtFKyoP6e/aLSPwjJFlJEOYYd2Ccyzbz89OMpix/16c+MI0U5uz26FMs0GLabmSeZpAz4Qw== On Tue, 31 Mar 2026 09:26:46 +0200 Krzysztof Kozlowski wrote: > On 30/03/2026 21:34, Josh Law wrote: > > When the output buffer is full (str >= end), bstr_printf() skips > > advancing the args pointer past the pre-rendered pointer string in > > bin_buf. This causes all subsequent format specifiers to read from > > the wrong position, corrupting the rest of the output. > > > > Always compute the string length and advance args regardless of > > whether there is space to copy into the output buffer. > > > > Signed-off-by: Josh Law > > NAK > > Questionably origin (multiple identities used), questionable content. Can you expand further on this complaint? -- Steve