From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8329D3E92A5 for ; Tue, 31 Mar 2026 16:25:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774974323; cv=none; b=MMDSvpN3USwNfntP4CLXPTcvLKFsubsObjSwBh7ACj77tYaFx73hp8WuYd2uaqbQLYKpnyDw7DNXn7g0i8gJ9HDsYyPpmeA3GNIuJcj1VDL4nt9MMkxdFqorF5cwz+IUGVRUt7hxSqUCeTlIMVlNyHBW3L6webuO0R6XAj0rClk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774974323; c=relaxed/simple; bh=5t1FqBMRuAaBCjDjDh+ZUpJziqPUYp8Eoc3Ac0ouYOQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pG0ZkccHGyRENC6LehlynAcnXC7gTcFXs4fsRpGYcJqiDTUf/nCLv5y+4WAJmkizsUWLw6FZTlr+IXxrLcVFzmhfDP3ckprPpeB/zHMXyZjxGjTcAHZ4Mhu+Lp/fBwAYyRm4FlNJG/w68JJkIIAHGvkT6EH6oym5tN+vsifXYaY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=XFd71wS1; arc=none smtp.client-ip=209.85.222.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="XFd71wS1" Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-8cfcb045909so734021585a.0 for ; Tue, 31 Mar 2026 09:25:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1774974319; x=1775579119; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LsKEfazYLGr0lh88GcHa3cSE8LWBmMeMFJDl+wqwlHE=; b=XFd71wS1Rs8p8moQZf7YYQ1bdyvSVlDjdrofOcuanuIQLsyW9BEcRiqBkxwJcXfSMR hWnqDI5Cx6p2He9479NozbhNXplxqErjWwzFF+mkcnk0kDtIMYaRsUNWd9RcZxQsybXQ fRb8NxLPvlAExmKLXqCJ81b6Ql0HYlqY2W+GFixNByw2BsUX8gs05MuM9QG636MXQ0s7 IIJq/HAWRfRr4sIh/EE5exVDSCC3ArqutPzND8X46RVLhUYI50nWRuT4HjdcpGLVy5xw qWmnMO4z5oA1RfhxQyIef3jInOEgv00fM/dG/CeuKGo6CfvSEhSt97fQHIv0eYAF4i7i 1y2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774974319; x=1775579119; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LsKEfazYLGr0lh88GcHa3cSE8LWBmMeMFJDl+wqwlHE=; b=ScCqWpNrP0wBfPOWnVj//zfx1aW96Fjcrfx3O22F9N8LMpAnvViUj2TJ9Na4QLCV/k /bBqBDa6TwhpmDBE98bEatO/tuy2qVAuCT7znDCvqYT4HPZDZz/USaCks/kxKXWwwQvI XbHhU6NBvmMMhl+BFsNCdBO8cJ4eBtAYCywDyc4jo2hik96zvfRg5VyS1KROoQPa6hvT wKUZLLdaX6n5o45DjkXBq7tWKfu8maYT62hPWGSXIuUOct662jhjYLALXVxvpmvxKEdA RFXtObs9phWKZUyxNOx/kL+FjRkocNtOExJcwnKUpi7bqEBUyZz52Nr9ZBOUXZMNUcat aLiw== X-Forwarded-Encrypted: i=1; AJvYcCULdOiMLptbn3XGC70PRnLCMIfoIHEECw54e5uGWmk17/Zx2Ojo3vgCFrRyKUyHwBSHg3ZeqQG4fWYuQ/Q=@vger.kernel.org X-Gm-Message-State: AOJu0YwVuyMHQdW0W7R6kCPnPXtcX6XOQiVAZlwU2YKlIOADedrlRdxx 3eyc6tZ4+sCWSF8HEW1BjUU4T/Ms8umVD/wixoHpnH4VeOkIz0ZZDZET107bWYKot1M= X-Gm-Gg: ATEYQzxbAqEsECWqRKli69jbTo2xkrsLqvoGe361mnIOYLuxlASHG7/o9nJgMAUyoq0 TNaWbr2zUnXzp0QwbARf3WKNphBRG2p9sowZbMjzCsOKyzvcFQiL27J3BnjG6itir/bia1m8gWd +O/bc51Mx7Cz3izX+fw3gcYoIUSoajs3k1t1fj8AcnlVsJRqKEAHZEgVlhILGrlghUMaJbmOPHm 6Cj8Qp8KRbvvevEOBA0NsYfnLz3LxDN0VK4SFFlRWWPmfiFv7cYaq3XtdLruxDLeznHCH1QJtoY 8vFyu5MJwO7CUHJMdRYynP7KmE1wtAtP8t1glrb38AQoQYTgei79itq7KwccVE0s/9rG29GGtMB v0nOA/vIo2n8aafe0QaaxNYd2xEXKhq2jSenZ24ru35T6i/3EtFo4M0ydAWuO7iqYWWwL5iD5Df b/h38fKVCOHFFGjICHKumv8N/SOujxS0FG9iECS80ZQ/lJgrB7bp9GNXTefBkXVmSXYPEkCA== X-Received: by 2002:a05:620a:390c:b0:8cd:8d79:6c6e with SMTP id af79cd13be357-8d1b5c67078mr37101785a.69.1774974319269; Tue, 31 Mar 2026 09:25:19 -0700 (PDT) Received: from ziepe.ca (mctnnbsa70w-159-2-73-22.dhcp-dynamic.fibreop.nb.bellaliant.net. [159.2.73.22]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8d027edb7ddsm881241785a.9.2026.03.31.09.25.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2026 09:25:18 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1w7bu1-0000000A1cm-2DKX; Tue, 31 Mar 2026 13:25:17 -0300 Date: Tue, 31 Mar 2026 13:25:17 -0300 From: Jason Gunthorpe To: Zhenzhong Duan Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org, kevin.tian@intel.com, joro@8bytes.org, will@kernel.org, robin.murphy@arm.com, baolu.lu@linux.intel.com, stable@vger.kernel.org Subject: Re: [PATCH] iommufd: Fix return value of iommufd_fault_fops_write() Message-ID: <20260331162517.GJ246076@ziepe.ca> References: <20260330030755.12856-1-zhenzhong.duan@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260330030755.12856-1-zhenzhong.duan@intel.com> On Sun, Mar 29, 2026 at 11:07:55PM -0400, Zhenzhong Duan wrote: > copy_from_user() may return number of bytes failed to copy, we should > not pass over this number to user space to cheat that write() succeed. > Instead, -EFAULT should be returned. > > Cc: stable@vger.kernel.org > Fixes: 07838f7fd529 ("iommufd: Add iommufd fault object") > Signed-off-by: Zhenzhong Duan > Reviewed-by: Lu Baolu > --- > drivers/iommu/iommufd/eventq.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Applied to for-next, thanks Jason