From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 566441A00F0 for ; Wed, 1 Apr 2026 00:37:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775003866; cv=none; b=qX164u68qW0ne4xXBNmkn62pEOWBURVYkGBnAxy6KENZw2EywiJKXESp1LKvlm34v17Oixz3EqxNRcHkueDvr7FPU8M0UtjtCG/ITkp5yi//SORWCAxvWqDngjYkrkd+VkjjKwq1yCw2TXVJvmZKmTqGE6wixYXC0rAYxTIv9Zk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775003866; c=relaxed/simple; bh=EUB6KlhS067OIJFuEHObxGU9Kx1ZmJomYtU/7QHJu70=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=rvQiRjS1jul3M1mpeMRTDGHyRUPa001LqCna3bUBTjIYK4N/67X8iN/qZVTrrZR8l/UEaGojN978TOrJwjlw1u4BCnO1e6XsI1sM9otASKYV7qcbrx/+c1yEfK+nzOHt0PCwtnwgO4NPshyuyq6PzZS4Sj7Tby6OldKjsRWG6dM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=fZ1I4KD5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="fZ1I4KD5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81664C19423; Wed, 1 Apr 2026 00:37:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1775003865; bh=EUB6KlhS067OIJFuEHObxGU9Kx1ZmJomYtU/7QHJu70=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fZ1I4KD5B4mP40k+L0qU+TUYv0CZTJLnn7ymdiXyA14u4IHTZd/YfMrguZta6ws7I XsNcUdzwlhDnt9hXWsiOf1Fh2tajis4CYDisgPKtsUG7X59vItAAEOoxMiwtwLX1It 0Qt2JynzLTJjbeokwOj7el/IZUOvHRCacfvVV+5M= Date: Tue, 31 Mar 2026 17:37:44 -0700 From: Andrew Morton To: "Lorenzo Stoakes (Oracle)" Cc: Julian Braha , vbabka@kernel.org, hannes@cmpxchg.org, mhocko@suse.com, surenb@google.com, rppt@kernel.org, Liam.Howlett@oracle.com, david@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/thp: dead code cleanup in Kconfig Message-Id: <20260331173744.925a6ee6fac299f86a07a7eb@linux-foundation.org> In-Reply-To: References: <20260331070730.33915-1-julianbraha@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 31 Mar 2026 08:22:32 +0100 "Lorenzo Stoakes (Oracle)" wrote: > On Tue, Mar 31, 2026 at 08:07:30AM +0100, Julian Braha wrote: > > There is already an 'if TRANSPARENT_HUGEPAGE' condition wrapping several > > config options e.g. 'READ_ONLY_THP_FOR_FS', making > > the 'depends on' statement for each of these a duplicate dependency > > (dead code). > > > > I propose leaving the outer 'if TRANSPARENT_HUGEPAGE...endif' and removing > > the individual 'depends on TRANSPARENT_HUGEPAGE' statement from each > > option. > > > > This dead code was found by kconfirm, a static analysis tool for Kconfig. > > Thanks for acking tooling used :) much appreciated. OK, I give up. Where do I learn about kconfirm? > > > > Signed-off-by: Julian Braha > > Unless there's some weird semantics I'm not aware of, this LGTM, so: > > Reviewed-by: Lorenzo Stoakes (Oracle) Thanks. I'll add this to my (small!) post-rc1 pile.