From: Dan Williams <dan.j.williams@intel.com>
To: mcgrof@kernel.org, russ.weight@linux.dev, dakr@kernel.org
Cc: linux-kernel@vger.kernel.org, Chao Gao <chao.gao@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: [PATCH 0/3] firmware_loader: Fix shutdown ordering and reference counting
Date: Tue, 31 Mar 2026 14:47:23 -0700 [thread overview]
Message-ID: <20260331214726.903274-1-dan.j.williams@intel.com> (raw)
Chao Gao raised a module reference circular dependency report resulting
from *correct* usage of the firmware_upload_register() API [1]. The
module reference count is not necessary nor sufficient for protecting
against racing unregister against in-flight requests. After that is
fixed, a couple more cleanups fall out.
[1]: https://sashiko.dev/#/patchset/20260326084448.29947-1-chao.gao%40intel.com?patch=10705
Dan Williams (3):
firmware_loader: Stop pinning modules on registration
firmware_loader: Stop pinning parent device per workqueue invocation
treewide: firmware_loader: Drop the unused @module argument
.../driver-api/firmware/fw_upload.rst | 2 +-
include/linux/firmware.h | 15 +++---
drivers/base/firmware_loader/sysfs_upload.c | 48 ++++++++-----------
drivers/cxl/core/memdev.c | 4 +-
drivers/firmware/microchip/mpfs-auto-update.c | 2 +-
drivers/fpga/intel-m10-bmc-sec-update.c | 4 +-
drivers/greybus/gb-beagleplay.c | 2 +-
drivers/media/i2c/thp7312.c | 2 +-
drivers/net/pse-pd/pd692x0.c | 4 +-
lib/test_firmware.c | 3 +-
10 files changed, 38 insertions(+), 48 deletions(-)
base-commit: f338e77383789c0cae23ca3d48adcc5e9e137e3c
--
2.53.0
next reply other threads:[~2026-03-31 21:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 21:47 Dan Williams [this message]
2026-03-31 21:47 ` [PATCH 1/3] firmware_loader: Stop pinning modules on registration Dan Williams
2026-03-31 21:47 ` [PATCH 2/3] firmware_loader: Stop pinning parent device per workqueue invocation Dan Williams
2026-03-31 21:47 ` [PATCH 3/3] treewide: firmware_loader: Drop the unused @module argument Dan Williams
2026-04-09 16:06 ` Conor Dooley
2026-04-07 19:24 ` [PATCH 0/3] firmware_loader: Fix shutdown ordering and reference counting Russ Weight
2026-04-08 2:26 ` Chao Gao
2026-04-08 2:34 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260331214726.903274-1-dan.j.williams@intel.com \
--to=dan.j.williams@intel.com \
--cc=chao.gao@intel.com \
--cc=dakr@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=rafael@kernel.org \
--cc=russ.weight@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®