From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id D27EF392836;
	Wed,  1 Apr 2026 07:47:06 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1775029626; cv=none; b=UW4QZdBwtm3V3nhTuu9iukUSGQ7Uc5ukmrqbj96C/f2u+1LG0zkQKGPpvjK0qnwyK6fckGVi9CGrXYrsMdtbYG6XXpBAZBxu0D+WCYvkt+xRvTW1IzVR0ISQZBeyXyvfXzM+vbF0xMCe5s2k5w4+7kNtsJYzxk/KhWa30HDttkM=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1775029626; c=relaxed/simple;
	bh=lzWX3iUS0cGBKwvQbYvLCMFCiE+hsgup2maX2G5+fRU=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=XuiwyMswbtsF+hMTyEWthHCRyIe5/nmDhS9lJFPN+u3BqMmqP6KlWLK5iK1uuSC2jZeWnEY3eUA3qbeckrLWXry8upNXCfdENVeebcC9ANvPa2vRWBxSoWniJNNGlmrxc5+6gbfnLlDAdqxz8TwMEfav8U6pd3uNvmToFDlPsSs=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=q33gf0na; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="q33gf0na"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id DCC25C4CEF7;
	Wed,  1 Apr 2026 07:47:05 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1775029626;
	bh=lzWX3iUS0cGBKwvQbYvLCMFCiE+hsgup2maX2G5+fRU=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=q33gf0na9FgTmniWilMtyme65kNyXWY9hOXQH8PxqqvxmVLF5KQEqlgUNp0iPFCHK
	 7yveG1omdQbPZYX0MEnCX++PN4kKVLtgtTkXriqw/Qaihm54nLe44MTucaoxSzDsOx
	 xPH32/6bukn0lJdOJlayInKBvOiqh9TwLtoko1l1bfVc7K8YVmoUVMPtCaCY2gz7De
	 n3rT3QP8D81tRPwoK/eCH10H54E3g6BrYQi47q3P/1CZMa13B0ZQE/A1IezUg/Axp2
	 8DoM//zzJE6+Lf2sLjXIRQMIeemZJu5BCHGjY3rOwvaRieW1mGzX8LpoxL10m+d1PK
	 FExdQDBX0tfWw==
Date: Wed, 1 Apr 2026 09:47:04 +0200
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Yu-Chun Lin <eleanor.lin@realtek.com>
Cc: linusw@kernel.org, brgl@kernel.org, robh@kernel.org, 
	krzk+dt@kernel.org, conor+dt@kernel.org, afaerber@suse.com, tychang@realtek.com, 
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, 
	linux-arm-kernel@lists.infradead.org, linux-realtek-soc@lists.infradead.org, cy.huang@realtek.com, 
	stanley_chang@realtek.com, james.tai@realtek.com
Subject: Re: [PATCH 1/3] dt-bindings: gpio: realtek: Add realtek,rtd1625-gpio
Message-ID: <20260401-idealistic-grinning-wallaby-8c3cd5@quoll>
References: <20260331113835.3510341-1-eleanor.lin@realtek.com>
 <20260331113835.3510341-2-eleanor.lin@realtek.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20260331113835.3510341-2-eleanor.lin@realtek.com>

On Tue, Mar 31, 2026 at 07:38:33PM +0800, Yu-Chun Lin wrote:
> +  reg:
> +    items:
> +      - description: GPIO controller registers
> +      - description: GPIO interrupt registers
> +
> +  interrupts:
> +    items:
> +      - description: Interrupt number of the assert GPIO interrupt, which is
> +                     triggered when there is a rising edge.
> +      - description: Interrupt number of the deassert GPIO interrupt, which is
> +                     triggered when there is a falling edge.
> +      - description: Interrupt number of the level-sensitive GPIO interrupt,
> +                     triggered by a configured logic level.
> +
> +  interrupt-controller: true
> +
> +  "#interrupt-cells":
> +    const: 2
> +
> +  gpio-ranges: true
> +
> +  gpio-controller: true
> +
> +  "#gpio-cells":
> +    const: 2
> +
> +required:
> +  - compatible
> +  - reg
> +  - gpio-ranges
> +  - gpio-controller
> +  - "#gpio-cells"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    gpio@89120 {
> +      compatible = "realtek,rtd1625-isom-gpio";
> +      reg = <0x89120 0x10>,

0x10 feels very short range.

> +            <0x89100 0x20>;

And this means it's continuous. Are you sure these are two separate
address spaces?

Best regards,
Krzysztof