mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Dillon Varone <Dillon.Varone@amd.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
	Alex Deucher <alexander.deucher@amd.com>,
	Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>,
	Fangzhi Zuo <jerry.zuo@amd.com>
Subject: drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_srv.c:961 dmub_srv_wait_for_pending() warn: inconsistent indenting
Date: Wed, 01 Apr 2026 04:16:54 +0800	[thread overview]
Message-ID: <202604010451.mxTKtQnZ-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   d0c3bcd5b8976159d835a897254048e078f447e6
commit: a3b7dc4a1ec4e184f48c2f8205d2ec88d31310fe drm/amd/display: Add Support for reg inbox0 for host->DMUB CMDs
date:   12 months ago
config: x86_64-randconfig-161-20260329 (https://download.01.org/0day-ci/archive/20260401/202604010451.mxTKtQnZ-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
rustc: rustc 1.88.0 (6b00bc388 2025-06-23)
smatch: v0.5.0-9004-gb810ac53

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202604010451.mxTKtQnZ-lkp@intel.com/

New smatch warnings:
drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_srv.c:961 dmub_srv_wait_for_pending() warn: inconsistent indenting

Old smatch warnings:
drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_srv.c:862 dmub_srv_fb_cmd_execute() warn: inconsistent indenting
drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_srv.c:994 dmub_srv_wait_for_idle() warn: inconsistent indenting

vim +961 drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_srv.c

   940	
   941	enum dmub_status dmub_srv_wait_for_pending(struct dmub_srv *dmub,
   942						uint32_t timeout_us)
   943	{
   944		uint32_t i;
   945		const uint32_t polling_interval_us = 1;
   946		struct dmub_srv_inbox scratch_reg_inbox0 = dmub->reg_inbox0;
   947		struct dmub_srv_inbox scratch_inbox1 = dmub->inbox1;
   948		const volatile struct dmub_srv_inbox *reg_inbox0 = &dmub->reg_inbox0;
   949		const volatile struct dmub_srv_inbox *inbox1 = &dmub->inbox1;
   950	
   951		if (!dmub->hw_init ||
   952				!dmub->hw_funcs.get_inbox1_wptr)
   953			return DMUB_STATUS_INVALID;
   954	
   955		/* take a snapshot of the required mailbox state */
   956		scratch_inbox1.rb.wrpt = dmub->hw_funcs.get_inbox1_wptr(dmub);
   957	
   958		for (i = 0; i <= timeout_us; i += polling_interval_us) {
   959				scratch_inbox1.rb.rptr = dmub->hw_funcs.get_inbox1_rptr(dmub);
   960	
 > 961			scratch_reg_inbox0.is_pending = scratch_reg_inbox0.is_pending &&
   962					dmub->hw_funcs.read_reg_inbox0_rsp_int_status &&
   963					!dmub->hw_funcs.read_reg_inbox0_rsp_int_status(dmub);
   964	
   965			if (scratch_inbox1.rb.rptr > dmub->inbox1.rb.capacity)
   966				return DMUB_STATUS_HW_FAILURE;
   967	
   968			/* check current HW state first, but use command submission vs reported as a fallback */
   969			if ((dmub_rb_empty(&scratch_inbox1.rb) ||
   970					inbox1->num_reported >= scratch_inbox1.num_submitted) &&
   971					(!scratch_reg_inbox0.is_pending ||
   972					reg_inbox0->num_reported >= scratch_reg_inbox0.num_submitted))
   973				return DMUB_STATUS_OK;
   974	
   975			udelay(polling_interval_us);
   976		}
   977	
   978		return DMUB_STATUS_TIMEOUT;
   979	}
   980	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

             reply	other threads:[~2026-03-31 20:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-31 20:16 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-12-15  0:01 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202604010451.mxTKtQnZ-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=Dillon.Varone@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=jerry.zuo@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicholas.kazlauskas@amd.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®