From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BDE44086A for ; Wed, 1 Apr 2026 20:31:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775075507; cv=none; b=Sh9vNsJY1tEC+n6w6lwmRxlmT5gj2ZuUZFER5U8dYPdAAMk76IsvnmE6grNBJbl0+PtcEVh7zYvb1h7F1I/J8fU8gq9cH0ZAfcSh80hdPYoWgfh2sIBS13UFuqFHaeBNhmI2QvQQKKXM6v7f0rOdo6ZjDhXNY/oiLz1UbVisHRg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775075507; c=relaxed/simple; bh=KCK2cUrZ/ubOAvnVxJj+KHP+CUfSw+QVN0xXkKOMlCo=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=ILSe9DBy9rCbrC4BUi0RdUIDiecy1ssSsZGEIqeybVYGyNMxYQagt5qNCQOYbC476IT7GhDelswy5p43XZeuOyDI6viDQSFfpByJ7TyDGkyrHHDG0grINi5yaTTVm2bRnJWa0XphcWwNqo3rQsM1yqr2JA0DHF8Hecg15DA7wmQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=QFGj+Tqx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="QFGj+Tqx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA0D3C4CEF7; Wed, 1 Apr 2026 20:31:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1775075507; bh=KCK2cUrZ/ubOAvnVxJj+KHP+CUfSw+QVN0xXkKOMlCo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QFGj+TqxNjuAOC4xK35vi4qTlGzbma1asJSTBAuT62kreNNb7np8i7TmwsVRyg8UI OxmukRYd2bxsaWBktv16rVLBFXvb3v2mFlvBM/kzUFyZ5F6sYRbWc0nREE341whOMe ySXEQSYPpDmI2f9w8oB483hg9vRLQlz6VVIQCrhg= Date: Wed, 1 Apr 2026 13:31:45 -0700 From: Andrew Morton To: "Lorenzo Stoakes (Oracle)" Cc: Nico Pache , "David Hildenbrand (Arm)" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, aarcange@redhat.com, anshuman.khandual@arm.com, apopple@nvidia.com, baohua@kernel.org, baolin.wang@linux.alibaba.com, byungchul@sk.com, catalin.marinas@arm.com, cl@gentwo.org, corbet@lwn.net, dave.hansen@linux.intel.com, dev.jain@arm.com, gourry@gourry.net, hannes@cmpxchg.org, hughd@google.com, jackmanb@google.com, jack@suse.cz, jannh@google.com, jglisse@google.com, joshua.hahnjy@gmail.com, kas@kernel.org, lance.yang@linux.dev, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, mathieu.desnoyers@efficios.com, matthew.brost@intel.com, mhiramat@kernel.org, mhocko@suse.com, peterx@redhat.com, pfalcato@suse.de, rakie.kim@sk.com, raquini@redhat.com, rdunlap@infradead.org, richard.weiyang@gmail.com, rientjes@google.com, rostedt@goodmis.org, rppt@kernel.org, ryan.roberts@arm.com, shivankg@amd.com, sunnanyong@huawei.com, surenb@google.com, thomas.hellstrom@linux.intel.com, tiwai@suse.de, usamaarif642@gmail.com, vbabka@suse.cz, vishal.moola@gmail.com, wangkefeng.wang@huawei.com, will@kernel.org, willy@infradead.org, yang@os.amperecomputing.com, ying.huang@linux.alibaba.com, ziy@nvidia.com, zokeefe@google.com Subject: Re: [PATCH mm-unstable v4 5/5] mm/khugepaged: unify khugepaged and madv_collapse with collapse_single_pmd() Message-Id: <20260401133145.90b094a7b87bdceb0013b5af@linux-foundation.org> In-Reply-To: <87b83f7b-f0b1-4184-93a0-3b4b574c813b@lucifer.local> References: <20260325114022.444081-1-npache@redhat.com> <20260325114022.444081-6-npache@redhat.com> <7760c811-e100-4d40-9217-0813c28314be@lucifer.local> <0223d45b-e8b4-49a7-882b-477250d0c14d@kernel.org> <26fcec86-ee78-4f5c-8ca5-0e6230699cfd@kernel.org> <440d6b8a-d299-43eb-83b5-6625f9468e5e@lucifer.local> <37132e09-9c03-4afc-bc73-4bca416c5343@kernel.org> <9d5a4703-a15e-4be6-926b-af2d98db40c0@kernel.org> <87b83f7b-f0b1-4184-93a0-3b4b574c813b@lucifer.local> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 1 Apr 2026 09:14:35 +0100 "Lorenzo Stoakes (Oracle)" wrote: > From: "Lorenzo Stoakes (Oracle)" > Date: Tue, 31 Mar 2026 13:11:18 +0100 > Subject: [PATCH] mm/khugepaged: fix issue with tracking lock > > We are incorrectly treating lock_dropped to track both whether the lock is > currently held and whether or not the lock was ever dropped. > > Update this change to account for this. > > Signed-off-by: Lorenzo Stoakes (Oracle) Not sure if I should add this? Should it have Fixes: 330f3758a3bc ("mm/khugepaged: unify khugepaged and madv_collapse with collapse_single_pmd()")?