mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrea Mayer <andrea.mayer@uniroma2.it>
To: nicolas.dichtel@6wind.com
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
	dsahern@kernel.org, david.lebrun@uclouvain.be,
	stefano.salsano@uniroma2.it, paolo.lungaroni@uniroma2.it,
	linux-kernel@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
	linux-kselftest@vger.kernel.org,
	Andrea Mayer <andrea.mayer@uniroma2.it>
Subject: Re: [PATCH net 2/2] selftests: seg6: add test for dst_cache isolation in seg6 lwtunnel
Date: Wed, 1 Apr 2026 15:03:01 +0200	[thread overview]
Message-ID: <20260401150301.37fc2584bb5add3a922999f4@uniroma2.it> (raw)
In-Reply-To: <b6ec7b55-d883-45fd-a227-db8fb29e48f2@6wind.com>

On Tue, 31 Mar 2026 18:15:31 +0200
Nicolas Dichtel <nicolas.dichtel@6wind.com> wrote:

> Le 31/03/2026 à 13:07, Andrea Mayer a écrit :
> > Add a selftest that verifies the dst_cache in seg6 lwtunnel is not
> > shared between the input (forwarding) and output (locally generated)
> > paths.
> > 
> > The test creates three namespaces (ns_src, ns_router, ns_dst)
> > connected in a line. An SRv6 encap route on ns_router encapsulates
> > traffic destined to cafe::1 with SID fc00::100. The SID is
> > reachable only for forwarded traffic (from ns_src) via an ip rule
> > matching the ingress interface (iif veth-r0 lookup 100), and
> > blackholed in the main table.
> > 
> > The test verifies that:
> > 
> >   1. A packet generated locally on ns_router does not reach
> >      ns_dst with an empty cache, since the SID is blackholed;
> >   2. A forwarded packet from ns_src populates the input cache
> >      from table 100 and reaches ns_dst;
> >   3. A packet generated locally on ns_router still does not
> >      reach ns_dst after the input cache is populated,
> >      confirming the output path does not reuse the input
> >      cache entry.
> > 
> > Both the forwarded and local packets are pinned to the same CPU
> > with taskset, since dst_cache is per-cpu.
> > 
> > Cc: Shuah Khan <shuah@kernel.org>
> > Cc: linux-kselftest@vger.kernel.org
> > Signed-off-by: Andrea Mayer <andrea.mayer@uniroma2.it>
> > ---
> 
> [snip]
> 
> > +test_cache_isolation()
> > +{
> > +	RET=0
> > +
> > +	# local ping with empty cache: must fail (SID is blackholed)
> > +	if ip netns exec "${NS_RTR}" taskset -c 0 \
> > +			ping6 -c 1 -W 2 "${DEST}" &>/dev/null; then
> > +		echo "SKIP: local ping succeeded with empty cache"
> Nit: maybe the same message as the forwarding case:
> "SKIP: local ping succeeded, topology broken"
> 

Makes sense, will fix in v2.


> > +		exit "${ksft_skip}"
> > +	fi
> > +
> > +	# forward from ns_src to populate the input cache
> > +	if ! ip netns exec "${NS_SRC}" taskset -c 0 \
> > +			ping6 -c 1 -W 2 "${DEST}" &>/dev/null; then
> > +		echo "SKIP: forwarded ping failed, topology broken"
> > +		exit "${ksft_skip}"
> > +	fi
> > +
> [snip]
> 
> After that:
> Reviewed-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>

Thanks for the review.

Ciao,
Andrea

      reply	other threads:[~2026-04-01 13:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-31 11:07 [PATCH net 0/2] seg6: fix dst_cache sharing " Andrea Mayer
2026-03-31 11:07 ` [PATCH net 1/2] seg6: separate dst_cache for input and output paths " Andrea Mayer
2026-03-31 16:01   ` Nicolas Dichtel
2026-03-31 11:07 ` [PATCH net 2/2] selftests: seg6: add test for dst_cache isolation " Andrea Mayer
2026-03-31 16:15   ` Nicolas Dichtel
2026-04-01 13:03     ` Andrea Mayer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260401150301.37fc2584bb5add3a922999f4@uniroma2.it \
    --to=andrea.mayer@uniroma2.it \
    --cc=davem@davemloft.net \
    --cc=david.lebrun@uclouvain.be \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    --cc=pabeni@redhat.com \
    --cc=paolo.lungaroni@uniroma2.it \
    --cc=shuah@kernel.org \
    --cc=stefano.salsano@uniroma2.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®