From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98179361666 for ; Wed, 1 Apr 2026 19:15:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775070903; cv=none; b=VUnxMQlJuKegVFyQgR5Ty/CfNwFpbiGrFXTAdxDGqo65nn329ZlTzori/FI3RtNzY6J4CrI4qQuomX/1O3QYAGvZKIdsAIuZxxUQZ0MaUg1fv+kkP0fmNNascZv3PrezROPuqwv7A05n4+32jo/5cr53EsVNsgOdY2Dq6EcJH5c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775070903; c=relaxed/simple; bh=aOQvwFmNxOkcH3hY6TC/0qXbXfPYEsiczqDbdm09a6I=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HOVEP003NOdOhjNnvOuATPb9yhNRRuSJkFMSwylAmwWASGTDcMvTaE18ZIkCwPPbyQHlr7ZaJnKgpAWepLBChhRmePSYrdSM869aeXUY4wgU6N/TSUYN/k2ZrLNx8Ze+3ZnQXzt6k47Hx8/5BMp1zbWWEsltMMFeripfm6+xALI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SPs+WcT3; arc=none smtp.client-ip=209.85.167.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SPs+WcT3" Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-5a133b686f7so194273e87.0 for ; Wed, 01 Apr 2026 12:15:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775070899; x=1775675699; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=a53m1M0yPC+0hsBR8rulFA+iVXVX4Qv0HU8oZpgQDvA=; b=SPs+WcT3v/bRdlDxN9A7VdqtjQsZhAcnCa/O3aU8I2KGNozjUJ9Owk3Dpld1ZfOnNp JvoSf5Vmyr7j2sFW3vxoHUC+O2lW4YQ+uOfEcrmT8ooEfakJRg6kZftc+MMOHA08oKDO rBTKUZx25xcSnD7PB/ykliWflY8/3CzUl46w6QKWVKrLyyrh8uef+JHV9QcGbMnRAT5W j5xs7WRu2L+4ArZOLIyGC0EWcusNV4uBPZJ9YKXVy1gjzcR9Kq8tuQrSCyRE5W0N5Kgw 1syeEsRPfwH41exSB64u8BOYJqyy2Ed/46eQzNTiT9+gxvHIF/GWAusWBLzkxasGGjDN LaZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775070899; x=1775675699; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=a53m1M0yPC+0hsBR8rulFA+iVXVX4Qv0HU8oZpgQDvA=; b=gqr3vrUWZzWheM3VcjmYjOe8CeeE5U1Mdp6Tl2d1lke/uNcu038d6PzXMTbz8A5aV9 VnK5v0pH5OLC1ySekPbF2988TzqwLd4n7t1O5eV9GgJSI2Cvrsu9TkmhJJ3n1+Z/ih0W ri5Fqzu6uKmkNg2HO47gqgunG5ZqPu9esWyymNYGhLNpFXM7T5DpZieq9Mq7kwXnmDYw feqLmKrzZW8ahbmcOEDLDGxEvHDJZIwJfuuVPYhx9EyVfDgM2zpzC8Gudzp+8WiR5xSH Whu0rsQRSaVU5hFEqyDYBhonpLoM6IiDWAIMoPdEdPajbuESBW/rhsbR/XGvaM025OF7 E8Zg== X-Forwarded-Encrypted: i=1; AJvYcCUNK4kYfHSY72VBdLFYVxo/lj1NGpKq5b8/nSPxcqONCPYBfTC5LaY/D/UNOPmsOlt5IiRfoshK4L3Q38o=@vger.kernel.org X-Gm-Message-State: AOJu0YzfPnn2MnH+juby8hWkP6WwdjvpY4N8rkQZKDZRNhpkSrN93IFg CwUmhXd05UScN1ATI4UXv9UbjYnNIwL4lUcBB+Q7NJ3Vp/GG9cBvYpI+ X-Gm-Gg: ATEYQzw8MLuJh9v7wXYE7J0f6s9th+eghqZUz5CEenVzIcPsEIqMMEGB4zZUVrDSErj 2vgu4L8eOiZmB9wt0CCCQgpzdKQMwcgxmxA6Fg9WfMW/Py/7+eCH2UEQPpOosHki187k8Qf1OAe 4bdbLWK+288bo562RIa5rXTHhUSrQBM8jbuK0Vx5+Qy1MS97fMbMutyLUuK3hidbcOmmSNhv6q3 Ho6lz1zAlYSzoxY99pajtXjOfprrZBuYptqUyjRbnjIq7rtZSLXe2lK9TVEwEynYeD2/D7yTH+9 GEOMBaYM50foCzxxtFcvQ2qGCtx2sUEwXj+VM7apiRELDOJZq5f5fX+PmH1Dw85l72A9rsbNlKw +kUDg5y7TppG1OMmrdpq93hWU4SyI9QwrZ3r4AE9TLrKMJdXQi9jh9Z5FLQ0RpnaA73yVLO1l/+ QRiZhIyAu9q9cgp7C7jjiPzrT61Q== X-Received: by 2002:a05:6512:3b87:b0:5a2:78fa:2700 with SMTP id 2adb3069b0e04-5a2c1f3c4d5mr1943599e87.23.1775070898394; Wed, 01 Apr 2026 12:14:58 -0700 (PDT) Received: from new-nest ([94.19.228.143]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a2c6ccca2dsm141855e87.60.2026.04.01.12.14.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 12:14:57 -0700 (PDT) From: Andrey Skvortsov To: Maxime Ripard , Paul Kocialkowski , Mauro Carvalho Chehab , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Hans Verkuil , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Andrey Skvortsov Subject: [PATCH 1/2] media: cedrus: Fix missing cleanup in error path Date: Wed, 1 Apr 2026 22:14:40 +0300 Message-ID: <20260401191441.1217646-1-andrej.skvortzov@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Samuel Holland From: Samuel Holland According to the documentation struct v4l2_fh has to be cleaned up with v4l2_fh_exit() before being freed. [1] 1. https://docs.kernel.org/driver-api/media/v4l2-fh.html Signed-off-by: Samuel Holland Signed-off-by: Andrey Skvortsov Fixes: 50e761516f2b ("media: platform: Add Cedrus VPU decoder driver") --- drivers/staging/media/sunxi/cedrus/cedrus.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c b/drivers/staging/media/sunxi/cedrus/cedrus.c index 6600245dff0e2..1d2130f35fffc 100644 --- a/drivers/staging/media/sunxi/cedrus/cedrus.c +++ b/drivers/staging/media/sunxi/cedrus/cedrus.c @@ -391,6 +391,7 @@ static int cedrus_open(struct file *file) err_m2m_release: v4l2_m2m_ctx_release(ctx->fh.m2m_ctx); err_free: + v4l2_fh_exit(&ctx->fh); kfree(ctx); mutex_unlock(&dev->dev_mutex); -- 2.51.0