From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3572C2C11E4 for ; Wed, 1 Apr 2026 19:15:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775070915; cv=none; b=hPvPPvHwSURSrSdNFIoY2ZmeFhdWRTKgTJUvPV+iLLxPm+GmF+R2GPIw4Kq2ZLqckj3E/jVdzvU9LjQvnhgW+WtpoH0XFfdgKB4Y6voTml77mf1kxkNyb889y/w6HtsuhMgIgxkWteeuASBwW3w5fsDA6Z3uyRh0kQIv+dkFZ9A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775070915; c=relaxed/simple; bh=OJ8d86r1cv2Dz9K0VOKzDX9IeSSniN4yMPUR9rzI5RM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B9wI7DTmSd9J5Hlfn21AzwQEl4ESp/6oqK4OZ7e4p83wBHdJSPxcAh0sq2gLz1Do7zHiAz61EsgYdy/aMXPtC1+J87Q5IetdBMfV4FbQ0fdGKUC1SFuh1oaP4jJYloaPvS9WpNURM0e/YdRnjlfKG1xCR+u1+hvJxZ6qqfv5UoU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Dny7CnpC; arc=none smtp.client-ip=209.85.167.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Dny7CnpC" Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-5a0ff30b240so192949e87.0 for ; Wed, 01 Apr 2026 12:15:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775070912; x=1775675712; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=r8KcYzflmFoH6kQuwH+mgkFuRmADtPPTvOe6lcVTKSM=; b=Dny7CnpCNdlmv3iC6DadIPaxvVN9/2eIvGIRRAm7mZOFh4HdnoaGtAdUG/hlmRrVNN u4jQN1lfVL+mvFD65dcVVdqY/1yGj2QGbdsW0abfsfEmJ7QjyCQn5A9k9XqzSOjXLx7d crvVhhIKuGbBHiIFplj+nqw1ukvhpLSP/3Hcq5HH8uEl6otDu9u9hdF7jOVoyiqyvm1v SJRnoKEW5hjWm6ZFoYbI/y+eTUPImevBcX+/Yhscx7S3Ut8QWL97/upzeg1kx/D5HVyu xUUed8oqHFzhEZTn2zKtgKXrJ1MKCOGvn4TrE//VQjBRxO8g8TVseVS1q8uBC3Io+O7B DP5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775070912; x=1775675712; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=r8KcYzflmFoH6kQuwH+mgkFuRmADtPPTvOe6lcVTKSM=; b=cbeZHDtUl+Hhnhi5Vui/DP/wZeXfEK8DYBtz3SzuIXOG9lZlc8FY3qwDctgc5KMLsq kEr5BOocVwMvx0YcdrTSEzS6xVVrv2yqEQgSOfmSS7Etwunp3bTyEhB4Kqf9lshIUrt7 sx534UEB0woEBAVWYz97xHCg+gpzi5fGG3nAC7HKHtt0yA2fvRDi8cQaxbYRFLlAWnrv FYzyf+0bhDXXfHBdS/xRy9GQcCieHZQOC6Xvxy/rYgVTv84rAGNAmqn9SlGPs8NyKOim w3W1o+DmpZVTvAa9PyaRlg5A23A16K2HAVHh9hPx+ZDSzt9fWDFf8hlLyxtF3WGTKeMF nNtw== X-Forwarded-Encrypted: i=1; AJvYcCVHQ0YTGUO/6X+eR9jJ80uVCZkAl32HbZmOk7dXaViypHdiOK6Gs1Oxhsinmc0SZYRrjZHhQoT1oF06jrs=@vger.kernel.org X-Gm-Message-State: AOJu0YwDWBbY8sTQR9UpAD1wU1hkw5mLcOOOBz1GSoCyhHOSVzsVwap5 pF815Cn+UyJaSsV5te0JJHZnxT0nS5OvbGvQO3BAQSRdi6c5V0fpCKsq X-Gm-Gg: ATEYQzzurXSDpsGUMktsYlk/AEo0QRX0oStKunPNKN0wVi/ftjY40QXAuFGKOk0LTh7 MBthmEkIqzK7WtIsvpbrubTbZvaTB8IcbygWgniuuXwQCzx9S0KQfSVHVqQcyDGl2FovKGSi42Z uIXtB2J/qm4SIOWxTnST07qHswC16iE0StgS1qy7M/VeApcpdIe5dg/LGdkMNNaHeVKSDlqkunj kiW20lcY0qDh/f/jSeMrXq7F7QgSquioTSDyLAo88zynPiKVDDk6iKZUC4uX8sgmK8te/oEBq5S jElEIL5/2IfBRjXL6SxUn+fjvbZt0nxVUIg+2V+linR3TpRkVUer469sekRwErqRnCDqh5/RK4u EjccLlvwvgDL9hL9OG22hOjg8pZxQVsrq/a8TUfRroPgcjm0WzknR4WauR6ZMCRNkF5h0Ho3m5r aN+ZTa4HyZVSucTBfJe3UCaAHZWz/fBwa4nE7E X-Received: by 2002:a05:6512:318e:b0:5a2:961a:f7c7 with SMTP id 2adb3069b0e04-5a2c7676402mr92043e87.21.1775070912245; Wed, 01 Apr 2026 12:15:12 -0700 (PDT) Received: from new-nest ([94.19.228.143]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a2c6ccca2dsm141855e87.60.2026.04.01.12.15.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 12:15:11 -0700 (PDT) From: Andrey Skvortsov To: Maxime Ripard , Paul Kocialkowski , Mauro Carvalho Chehab , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Hans Verkuil , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Andrey Skvortsov Subject: [PATCH 2/2] media: cedrus: Fix failure to clean up hardware on probe failure Date: Wed, 1 Apr 2026 22:14:41 +0300 Message-ID: <20260401191441.1217646-2-andrej.skvortzov@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260401191441.1217646-1-andrej.skvortzov@gmail.com> References: <20260401191441.1217646-1-andrej.skvortzov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Samuel Holland From: Samuel Holland cedrus_hw_remove undoes, that was done by cedrus_hw_probe previously, like disabling runtime power management, releasing claimed sram. Signed-off-by: Samuel Holland Signed-off-by: Andrey Skvortsov Fixes: 50e761516f2b ("media: platform: Add Cedrus VPU decoder driver") --- drivers/staging/media/sunxi/cedrus/cedrus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c b/drivers/staging/media/sunxi/cedrus/cedrus.c index 1d2130f35fffc..ee0e286add67d 100644 --- a/drivers/staging/media/sunxi/cedrus/cedrus.c +++ b/drivers/staging/media/sunxi/cedrus/cedrus.c @@ -477,7 +477,7 @@ static int cedrus_probe(struct platform_device *pdev) ret = v4l2_device_register(&pdev->dev, &dev->v4l2_dev); if (ret) { dev_err(&pdev->dev, "Failed to register V4L2 device\n"); - return ret; + goto err_hw; } vfd = &dev->vfd; @@ -538,6 +538,8 @@ static int cedrus_probe(struct platform_device *pdev) v4l2_m2m_release(dev->m2m_dev); err_v4l2: v4l2_device_unregister(&dev->v4l2_dev); +err_hw: + cedrus_hw_remove(dev); return ret; } -- 2.51.0