From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F297C3630A0 for ; Thu, 2 Apr 2026 08:18:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775117891; cv=none; b=YEM2fworZqaDxlByk8QV2Zjx//nYZEnAGX4Gf8gomxWMFWNROLh/I6RqBBp9m/hnbKpW2DSTlsOYFdJYeX6vrfjUt8dllibk1FdiWswXv+XAn2MXWz3otxrjIRJhZ8vWzQoImXiVNS5MSb9bsL5l/0nkk6dKKIky6aafwPzgcbY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775117891; c=relaxed/simple; bh=Gv4j5F5kmYPN2toSNOT0NUM+Ds/EorTosVmZDSuDh0M=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=M3nqf6t6GRd1+No+2YS451tcMgx2qodGhHd4gmievWUE1X9uULVoCORAl4c6lltWgbW4lv5yurshxF1vv8OoDPxRc2/wsYI2MazZBBL9bbWa6yq8Mm//EBoyBlcEkGsTIlOUA7N8wJq8qQQMZq+2FoYKoWglTgNVJsBrH2BPvZ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MUF21cVG; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=W6UBu7Yo; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MUF21cVG"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="W6UBu7Yo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775117889; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=t6mFCTOwHARpB/AAY05EQ/dyhhMmoktNcIHAMGcB1vg=; b=MUF21cVGU39ZYm0qWQ2N/lQjdfZ09+YuRLC2c0I/D3qDZdgg3vZ1DDwOhqx9TMJKfDGwDp l3kNfm96BI0oX20RHv5nsE84Fu+DMSRmsmjtjvSCh6a3yUej+e1wvDO6wjs5tBLu4DKyFx WpHf7BSBYY6BsXjk0T0xKYEoaEG+K9I= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-86-3Qdrus4aNtidC-WpVYcNHA-1; Thu, 02 Apr 2026 04:18:05 -0400 X-MC-Unique: 3Qdrus4aNtidC-WpVYcNHA-1 X-Mimecast-MFC-AGG-ID: 3Qdrus4aNtidC-WpVYcNHA_1775117885 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-486fa07f2bbso5538155e9.2 for ; Thu, 02 Apr 2026 01:18:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1775117884; x=1775722684; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=t6mFCTOwHARpB/AAY05EQ/dyhhMmoktNcIHAMGcB1vg=; b=W6UBu7YoWWWnVoXkcpjZxrWDhOCU111Vcd1eLd+fAvnPiSoIUADdCdTneNlQsZ99bv CSA3FrdSG6GTVNk1pRNNp4lgpvP9f+sBl9leKwW9EkVCflqFkto2xPPDe+g7rN3l/Aug evn7y+tG6QN6bedZsCJ2r7znGrwR345Ci1UvxFnqFIRrDr1ycgY7EFTK1OhScKCAoz98 eRPjCHgrMp6q9z+CzBwNy082JHjxLeFQbkw25RZ3d9B1fLV3s9o9Z7FV6dfd1HpsLY0g +OZuI72Tqy1PVoRPGYQ6Xny1YCtIGJV78FsnZlL1MvK+xnSKhovAdli3n5W96Bt+Gm25 BcEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775117884; x=1775722684; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=t6mFCTOwHARpB/AAY05EQ/dyhhMmoktNcIHAMGcB1vg=; b=V4IFWrNeoiSibcxjJMPHUh4HvJOT1hWrbUfT2Wx2npv/rJfVCihb4ddLDlUedzR15J 2opBzAzoushf5d1agUksQJ3z+K61u+qSyeeO7ZUO98B55md4QWhWalZ3AuZqkdIHHtpb YXcNTlC6K3w52VGdFVbKjN0v6DVsZ4NluzSGGB2PKTLfNd5ddhNwEh60gIREEFcKJqck 9ROX8XmVyp/P/9StMZbXSJ/7H+KmkRLqsL7v8VL1mhZoRyqn1GvHBaInIkon1F5A4r1b VVpNgyi8TIGAkR5xp1+Bqvwi1f4wXno4xfcuY+yUbsefoSb9Z0dhj/p2brnSYbJvmi+K upZA== X-Forwarded-Encrypted: i=1; AJvYcCWeCoPrZen/5Vf4hIv3fY7TLN46S7jiWSBn+Yu+6VTRe1zZGvpJ+5WL0POYaT3ezkrMuJfRzQBpoAlFvTY=@vger.kernel.org X-Gm-Message-State: AOJu0YxhEdnH0K0ID3z4IUqAAJl1iXk5ofqhGmPQ8aFDXCdebqmmv1kt l7uO4ME6tY28kwLVhRbPwHtpcBGVZQuf11d82UdZEoO7FXvYo9LC11S62sgeLzL7DTmZFbFUPNU hVDN6Bh18q7m/waOt794nP4l/9nl/kXhM/6xdb9Yk0BX4v20wBsTr/M4MXmELdPLfT6QfBlll17 +E X-Gm-Gg: ATEYQzzYEJTjvE+BoUNSADfkSukpxYciJtEvrEyodpOmJKCpE66HODgSJZqdMPt7Evz QFyg8oOGJ8BDF/tCbW3KkYOKEpHZVlKVqzTmWRlVo3m8RuDDHnQE4uJsfEdasYDxn5RUqzEyuf5 o7in1Rjb/KoZpOJGBpeXYT4UAHOAS0FeCV7gXPdzbS5XsFpOcZHhe/KbAHw4ZD104/OovMC4zOs 9GZPxbIZ544eyxd858l1Vap5XBkgOwM4PKb2zHjblHyP5jy12Xopv8Asc4C9ijXp1VWE+NIzfdo DBDe2aqj/OKZB1SjvAixZJ45Nooul2LyrctCdQAnOnDrN9vM5yEpYuE4QP4qBfaytTOwsONXMyp 8YF1YbDil7J57faUtDkQglsra1Mhps3gZY7IjdEjFrHKLXh1jmMeD2RaDMllq X-Received: by 2002:a05:600c:45c5:b0:485:3193:6ddb with SMTP id 5b1f17b1804b1-4888356a036mr110318925e9.3.1775117884410; Thu, 02 Apr 2026 01:18:04 -0700 (PDT) X-Received: by 2002:a05:600c:45c5:b0:485:3193:6ddb with SMTP id 5b1f17b1804b1-4888356a036mr110318555e9.3.1775117883944; Thu, 02 Apr 2026 01:18:03 -0700 (PDT) Received: from lleonard-thinkpadx1carbongen13.rmtit.csb ([176.206.19.176]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887e735532sm214476005e9.0.2026.04.02.01.18.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2026 01:18:03 -0700 (PDT) From: Luigi Leonardi Subject: [PATCH net 0/2] vsock/virtio: fix MSG_PEEK calculation on bytes to copy Date: Thu, 02 Apr 2026 10:18:00 +0200 Message-Id: <20260402-fix_peek-v1-0-ad274fcef77b@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAAAAAAAC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDEwND3bTMiviC1NRsXTMLY/MkC2MTM8tUYyWg8oKiVKAc2KhopbzUEqX Y2loAioNizF8AAAA= X-Change-ID: 20260401-fix_peek-6837b83469e3 To: Stefan Hajnoczi , Stefano Garzarella , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?utf-8?q?Eugenio_P=C3=A9rez?= , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Arseniy Krasnov Cc: kvm@vger.kernel.org, virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luigi Leonardi X-Mailer: b4 0.14.2 `virtio_transport_stream_do_peek`, when calculating the number of bytes to copy, didn't consider the `offset`, caused by partial reads that happend before. This might cause out-of-bounds read that lead to an EFAULT. More details in the commit. Commit 1 introduces the fix Commit 2 introduces a test that checks for this bug to avoid future regressions. Signed-off-by: Luigi Leonardi --- Luigi Leonardi (2): vsock/virtio: fix MSG_PEEK ignoring skb offset when calculating bytes to copy vsock/test: add MSG_PEEK after partial recv test net/vmw_vsock/virtio_transport_common.c | 5 ++- tools/testing/vsock/vsock_test.c | 64 +++++++++++++++++++++++++++++++++ 2 files changed, 66 insertions(+), 3 deletions(-) --- base-commit: 9147566d801602c9e7fc7f85e989735735bf38ba change-id: 20260401-fix_peek-6837b83469e3 Best regards, -- Luigi Leonardi