From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sen Wang <sen@ti.com>
Cc: linux-sound@vger.kernel.org, broonie@kernel.org,
lgirdwood@gmail.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, devicetree@vger.kernel.org, perex@perex.cz,
tiwai@suse.com, shenghao-ding@ti.com, kevin-lu@ti.com,
baojun.xu@ti.com, niranjan.hy@ti.com, l-badrinarayanan@ti.com,
devarsht@ti.com, v-singh1@ti.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] ASoC: codecs: Add TAS675x quad-channel audio amplifier driver
Date: Thu, 2 Apr 2026 09:54:36 +0200 [thread overview]
Message-ID: <20260402-righteous-gifted-kestrel-0ae70e@quoll> (raw)
In-Reply-To: <20260401223239.1638881-3-sen@ti.com>
On Wed, Apr 01, 2026 at 05:28:43PM -0500, Sen Wang wrote:
> +
> +static const struct dev_pm_ops tas675x_pm_ops = {
> + SYSTEM_SLEEP_PM_OPS(tas675x_system_suspend, tas675x_system_resume)
> + RUNTIME_PM_OPS(tas675x_runtime_suspend, tas675x_runtime_resume, NULL)
> +};
> +
> +static const struct of_device_id tas675x_of_match[] = {
> + { .compatible = "ti,tas6754", .data = (void *)TAS6754 },
> + { .compatible = "ti,tas67524", .data = (void *)TAS6754 },
I did not look detailed, but this ^^^
> + { }
> +};
> +MODULE_DEVICE_TABLE(of, tas675x_of_match);
> +
> +static const struct i2c_device_id tas675x_i2c_id[] = {
> + { "tas6754", TAS6754 },
> + { "tas67524", TAS6754 },
... and this ^^^ clearly states devices are compatible, unlike your
binding is stating
> + { }
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-04-02 7:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <message-id-of-your-RFC-cover-letter>
2026-04-01 22:28 ` [PATCH v2 0/4] ASoC: Add TAS675x quad-channel Class-D " Sen Wang
2026-04-01 22:28 ` [PATCH v2 1/4] dt-bindings: sound: Add ti,tas675x Sen Wang
2026-04-02 7:53 ` Krzysztof Kozlowski
2026-04-03 0:40 ` Sen Wang
2026-04-03 7:19 ` Krzysztof Kozlowski
2026-04-04 3:40 ` Sen Wang
2026-04-04 5:20 ` Krzysztof Kozlowski
2026-04-01 22:28 ` [PATCH v2 2/4] ASoC: codecs: Add TAS675x quad-channel audio amplifier driver Sen Wang
2026-04-02 7:54 ` Krzysztof Kozlowski [this message]
2026-04-02 17:10 ` Mark Brown
2026-04-03 1:16 ` Sen Wang
2026-04-01 22:28 ` [PATCH v2 3/4] Documentation: sound: Add TAS675x codec mixer controls documentation Sen Wang
2026-04-01 22:28 ` [PATCH v2 4/4] MAINTAINERS: add entry for TAS675x audio amplifier Sen Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260402-righteous-gifted-kestrel-0ae70e@quoll \
--to=krzk@kernel.org \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devarsht@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kevin-lu@ti.com \
--cc=krzk+dt@kernel.org \
--cc=l-badrinarayanan@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=niranjan.hy@ti.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=sen@ti.com \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.com \
--cc=v-singh1@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®